fix

Author: staabm

src/Report/Xml/Facade.php

@@ -183,11 +183,13 @@ private function processFile(FileNode $file, Directory $context): void
 
         $this->xmlWriter->endElement();
 
+        $this->xmlWriter->startElement('source');
         $fileReport->source()->setSourceCode(
             file_get_contents($file->pathAsString()),
         );
-        $fileReport->finalize();
+        $this->xmlWriter->endElement();
 
+        $fileReport->finalize();
         $this->saveDocument($fileReport->asDom(), $file->id());
     }
 
@@ -218,6 +220,8 @@ private function processUnit(ProcessedClassType|ProcessedTraitType $unit, Report
         }
 
         foreach ($unit->methods as $method) {
+            $this->xmlWriter->startElement('method');
+
             $unitObject->addMethod(
                 $method->methodName,
                 $method->signature,
@@ -228,6 +232,8 @@ private function processUnit(ProcessedClassType|ProcessedTraitType $unit, Report
                 (string) $method->coverage,
                 $method->crap,
             );
+
+            $this->xmlWriter->endElement();
         }
 
         $this->xmlWriter->endElement();

src/Report/Xml/Method.php

@@ -10,16 +10,17 @@
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
 use DOMElement;
+use XMLWriter;
 
 /**
  * @internal This class is not covered by the backward compatibility promise for phpunit/php-code-coverage
  */
 final readonly class Method
 {
-    private DOMElement $contextNode;
+    private XMLWriter $xmlWriter;
 
     public function __construct(
-        DOMElement $context,
+        XMLWriter $xmlWriter,
         string $name,
         string $signature,
         string $start,
@@ -29,21 +30,21 @@ public function __construct(
         string $coverage,
         string $crap
     ) {
-        $this->contextNode = $context;
+        $this->xmlWriter = $xmlWriter;
 
-        $this->contextNode->setAttribute('name', $name);
-        $this->contextNode->setAttribute('signature', $signature);
+        $this->xmlWriter->writeAttribute('name', $name);
+        $this->xmlWriter->writeAttribute('signature', $signature);
 
-        $this->contextNode->setAttribute('start', $start);
+        $this->xmlWriter->writeAttribute('start', $start);
 
         if ($end !== null) {
-            $this->contextNode->setAttribute('end', $end);
+            $this->xmlWriter->writeAttribute('end', $end);
         }
 
-        $this->contextNode->setAttribute('crap', $crap);
+        $this->xmlWriter->writeAttribute('crap', $crap);
 
-        $this->contextNode->setAttribute('executable', $executable);
-        $this->contextNode->setAttribute('executed', $executed);
-        $this->contextNode->setAttribute('coverage', $coverage);
+        $this->xmlWriter->writeAttribute('executable', $executable);
+        $this->xmlWriter->writeAttribute('executed', $executed);
+        $this->xmlWriter->writeAttribute('coverage', $coverage);
     }
 }

src/Report/Xml/Report.php

@@ -107,15 +107,6 @@ public function traitObject(
 
     public function source(): Source
     {
-        $source = $this->contextNode()->appendChild(
-            $this->dom->createElementNS(
-                Facade::XML_NAMESPACE,
-                'source',
-            ),
-        );
-
-        assert($source instanceof DOMElement);
-
-        return new Source($source);
+        return new Source($this->xmlWriter);
     }
 }

src/Report/Xml/Unit.php

@@ -9,6 +9,7 @@
  */
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
+use XMLWriter;
 use function assert;
 use DOMElement;
 
@@ -17,34 +18,28 @@
  */
 final readonly class Unit
 {
-    private DOMElement $contextNode;
+    private XMLWriter $xmlWriter;
 
     public function __construct(
-        DOMElement $context,
+        XMLWriter $xmlWriter,
         string $name,
         string $namespace,
         int $start,
         int $executable,
         int $executed,
         float $crap
     ) {
-        $this->contextNode = $context;
+        $this->xmlWriter = $xmlWriter;
 
-        $this->contextNode->setAttribute('name', $name);
-        $this->contextNode->setAttribute('start', (string) $start);
-        $this->contextNode->setAttribute('executable', (string) $executable);
-        $this->contextNode->setAttribute('executed', (string) $executed);
-        $this->contextNode->setAttribute('crap', (string) $crap);
+        $this->xmlWriter->writeAttribute('name', $name);
+        $this->xmlWriter->writeAttribute('start', (string) $start);
+        $this->xmlWriter->writeAttribute('executable', (string) $executable);
+        $this->xmlWriter->writeAttribute('executed', (string) $executed);
+        $this->xmlWriter->writeAttribute('crap', (string) $crap);
 
-        $node = $this->contextNode->appendChild(
-            $this->contextNode->ownerDocument->createElementNS(
-                Facade::XML_NAMESPACE,
-                'namespace',
-            ),
-        );
-        assert($node instanceof DOMElement);
-
-        $node->setAttribute('name', $namespace);
+        $this->xmlWriter->startElement('namespace');
+        $this->xmlWriter->writeAttribute('name', $namespace);
+        $this->xmlWriter->endElement();
     }
 
     public function addMethod(
@@ -57,17 +52,8 @@ public function addMethod(
         string $coverage,
         string $crap
     ): void {
-        $node = $this->contextNode->appendChild(
-            $this->contextNode->ownerDocument->createElementNS(
-                Facade::XML_NAMESPACE,
-                'method',
-            ),
-        );
-
-        assert($node instanceof DOMElement);
-
         new Method(
-            $node,
+            $this->xmlWriter,
             $name,
             $signature,
             $start,