Skip to content

Commit 9e446b4

Browse files
sbernauerTechassi
andauthored
Apply suggestions from code review
Co-authored-by: Techassi <[email protected]>
1 parent f7a3828 commit 9e446b4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

docs/design.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ Read on the [scaling page](./scaling/index.md) for more details.
9696

9797
## 6. Proxy modes
9898

99-
trino-lb can be configured to either proxy all calls to the underlying Trino clusters or only the initial `POST` and instruct the client to connect directly to the Trino cluster for the subsequent polling requests.
99+
trino-lb can be configured to either proxy all calls to the underlying Trino clusters or only the initial `POST` request and instruct the client to connect directly to the Trino cluster for the subsequent polling requests.
100100

101101
Read on the [proxy modes page](./proxy-modes.md) for more details.
102102

docs/proxy-modes.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Proxy mode
22

3-
trino-lb can be configured to either proxy all calls to the underlying Trino clusters or only the initial `POST` and instruct the client to connect directly to the Trino cluster for the subsequent polling requests.
3+
trino-lb can be configured to either proxy all calls to the underlying Trino clusters or only the initial `POST` request and instruct the client to connect directly to the Trino cluster for the subsequent polling requests.
44
It also needs to keep track of all started and finished queries on the Trino clusters, so that it can correctly calculate the number of running queries.
55

66
You can configure the proxy mode using
@@ -21,11 +21,11 @@ Benefits:
2121

2222
Downsides:
2323

24-
- Query run times can be increased in when a lot of data is transferred from the Trino coordinator to the Trino client due to network delay added by trino-lb (see the [performance research task](https://github.com/stackabletech/trino-lb/issues/72) for details)
24+
- Increased query run times when a lot of data is transferred from the Trino coordinator to the Trino client due to network delay added by trino-lb (see the [performance research task](https://github.com/stackabletech/trino-lb/issues/72) for details)
2525

2626
## Proxy first call
2727

28-
In this mode, the client only sends the initial `POST` to trino-lb. All following requests will be send to the Trino cluster directly.
28+
In this mode, the client only sends the initial `POST` request to trino-lb. All following requests will be send to the Trino cluster directly.
2929

3030
As trino-lb cannot inspect the traffic in the subsequent calls, it would have no knowledge of the started and finished queries. However, an [HTTP event listener](https://trino.io/docs/current/admin/event-listeners-http.html) can be configured in Trino to inform trino-lb about all query starts and completions.
3131

0 commit comments

Comments
 (0)