Skip to content

Commit 1f5041d

Browse files
authored
feat(playground): ga removing feature flag (#957)
* feat(playground): ga removing feature flag * feat(playground): removing config for playground feature flag
1 parent 6e894ea commit 1f5041d

File tree

3 files changed

+25
-36
lines changed

3 files changed

+25
-36
lines changed

main/src/feature-flags.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@ interface FeatureFlagOptions {
1313
}
1414

1515
const featureFlagOptions: Record<FeatureFlagKey, FeatureFlagOptions> = {
16-
[featureFlagKeys.PLAYGROUND]: {
17-
isDisabled: false,
18-
defaultValue: false,
19-
},
2016
[featureFlagKeys.GROUPS]: {
2117
isDisabled: false,
2218
defaultValue: false,

renderer/src/common/components/layout/top-nav/index.tsx

Lines changed: 25 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,9 @@ import { Separator } from '../../ui/separator'
1515
import { useConfirmQuit } from '@/common/hooks/use-confirm-quit'
1616
import { QuitConfirmationListener } from './quit-confirmation-listener'
1717
import { SettingsIcon } from 'lucide-react'
18-
import { useFeatureFlag } from '@/common/hooks/use-feature-flag'
1918
import { useRouterState } from '@tanstack/react-router'
2019

2120
function TopNavLinks() {
22-
const isPlaygroundEnabled = useFeatureFlag('playground')
2321
const pathname = useRouterState({ select: (s) => s.location.pathname })
2422
const isGroupRoute = pathname.startsWith('/group/')
2523

@@ -82,35 +80,31 @@ function TopNavLinks() {
8280
</NavigationMenuLink>
8381
</NavigationMenuItem>
8482

85-
{isPlaygroundEnabled && (
86-
<NavigationMenuItem>
87-
<NavigationMenuLink
88-
className="app-region-no-drag text-muted-foreground
89-
hover:text-foreground focus:text-foreground
90-
data-[status=active]:text-foreground
91-
data-[status=active]:before:bg-foreground
92-
focus-visible:ring-ring/50 relative px-3 py-2 text-sm
93-
transition-all outline-none hover:bg-transparent
94-
focus:bg-transparent focus-visible:ring-[3px]
95-
focus-visible:outline-1 data-[status=active]:bg-transparent
96-
data-[status=active]:before:absolute
97-
data-[status=active]:before:right-3
98-
data-[status=active]:before:bottom-[-14px]
99-
data-[status=active]:before:left-3
100-
data-[status=active]:before:h-0.5
101-
data-[status=active]:before:rounded-t-[1px]
102-
data-[status=active]:before:opacity-90
103-
data-[status=active]:before:content-['']
104-
data-[status=active]:hover:bg-transparent
105-
data-[status=active]:focus:bg-transparent"
106-
asChild
107-
>
108-
<LinkViewTransition to="/playground">
109-
Playground
110-
</LinkViewTransition>
111-
</NavigationMenuLink>
112-
</NavigationMenuItem>
113-
)}
83+
<NavigationMenuItem>
84+
<NavigationMenuLink
85+
className="app-region-no-drag text-muted-foreground
86+
hover:text-foreground focus:text-foreground
87+
data-[status=active]:text-foreground
88+
data-[status=active]:before:bg-foreground
89+
focus-visible:ring-ring/50 relative px-3 py-2 text-sm
90+
transition-all outline-none hover:bg-transparent
91+
focus:bg-transparent focus-visible:ring-[3px]
92+
focus-visible:outline-1 data-[status=active]:bg-transparent
93+
data-[status=active]:before:absolute
94+
data-[status=active]:before:right-3
95+
data-[status=active]:before:bottom-[-14px]
96+
data-[status=active]:before:left-3
97+
data-[status=active]:before:h-0.5
98+
data-[status=active]:before:rounded-t-[1px]
99+
data-[status=active]:before:opacity-90
100+
data-[status=active]:before:content-['']
101+
data-[status=active]:hover:bg-transparent
102+
data-[status=active]:focus:bg-transparent"
103+
asChild
104+
>
105+
<LinkViewTransition to="/playground">Playground</LinkViewTransition>
106+
</NavigationMenuLink>
107+
</NavigationMenuItem>
114108
<NavigationMenuItem>
115109
<NavigationMenuLink
116110
className="app-region-no-drag text-muted-foreground

utils/feature-flags.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
export const featureFlagKeys = {
2-
PLAYGROUND: 'playground',
32
GROUPS: 'groups',
43
CUSTOMIZE_TOOLS: 'customize_tools',
54
EDIT_WORKLOAD: 'edit_workload',

0 commit comments

Comments
 (0)