Revert "feat: add disabled state for the mcp servers page (#894)"

This reverts commit ab213ea.

Author: kantord

renderer/src/common/components/ui/button.tsx

@@ -13,8 +13,6 @@ const buttonVariants = cva(
           'bg-primary text-primary-foreground shadow-xs hover:bg-primary/90',
         destructive:
           'bg-destructive text-white shadow-xs hover:bg-destructive/90 focus-visible:ring-destructive/20 dark:focus-visible:ring-destructive/40 dark:bg-destructive/60',
-        enable:
-          'bg-green-600 text-white shadow-xs hover:bg-green-700 focus-visible:ring-green-500/20 dark:bg-green-600/80',
         outline:
           'border bg-background shadow-xs hover:bg-accent hover:text-accent-foreground dark:bg-input/30 dark:border-input dark:hover:bg-input/50',
         secondary:

renderer/src/features/clients/components/__tests__/enable-group-button.test.tsx

@@ -9,6 +9,8 @@ import { http, HttpResponse } from 'msw'
 import { PromptProvider } from '@/common/contexts/prompt/provider'
 import { mswEndpoint } from '@/common/mocks/customHandlers'
 
+// Use the shared request recorder from mocks/node.ts for consistency
+
 describe('ManageClientsButton – BDD flows', () => {
   let queryClient: QueryClient
 
@@ -86,22 +88,26 @@ describe('ManageClientsButton – BDD flows', () => {
         body: { name: 'cursor', groups: ['default'] },
       },
     ])
+    // no-op: global recorder persists; we reset via recordRequests() per test
   })
 
   it('enables a single client when none are enabled (clients API returns null)', async () => {
+    // Given: no clients are registered in the group
     server.use(
       http.get(mswEndpoint('/api/v1beta/groups'), () =>
         HttpResponse.json({
           groups: [{ name: 'default', registered_clients: [] }],
         })
       ),
+      // Simulate backend returning null for current clients list
       http.get(mswEndpoint('/api/v1beta/clients'), () =>
         HttpResponse.json(null)
       )
     )
 
     const rec = recordRequests()
 
+    // When: the user enables only VS Code and saves
     const user = userEvent.setup()
     renderWithProviders({ groupName: 'default' })
     await user.click(
@@ -110,6 +116,7 @@ describe('ManageClientsButton – BDD flows', () => {
     await user.click(await screen.findByRole('switch', { name: 'vscode' }))
     await user.click(await screen.findByRole('button', { name: /save/i }))
 
+    // Then: exactly one POST registration should be sent
     await waitFor(() =>
       expect(
         rec.recordedRequests.filter(

renderer/src/features/clients/components/__tests__/manage-clients-button.test.tsx

@@ -1,6 +1,13 @@
+import { usePrompt } from '@/common/hooks/use-prompt'
+import type { UseFormReturn } from 'react-hook-form'
+import { Label } from '@/common/components/ui/label'
 import { Button } from '@/common/components/ui/button'
+import { Switch } from '@/common/components/ui/switch'
 import { Code } from 'lucide-react'
-import { useManageClientsDialog } from '../hooks/use-manage-clients-dialog'
+import { z } from 'zod/v4'
+import { zodV4Resolver } from '@/common/lib/zod-v4-resolver'
+import { useManageClients } from '../hooks/use-manage-clients'
+import { useToastMutation } from '@/common/hooks/use-toast-mutation'
 
 interface ManageClientsButtonProps {
   groupName: string
@@ -19,12 +26,81 @@ export function ManageClientsButton({
   variant = 'outline',
   className,
 }: ManageClientsButtonProps) {
-  const { openDialog } = useManageClientsDialog(groupName)
+  const promptForm = usePrompt()
+
+  const {
+    installedClients,
+    defaultValues,
+    reconcileGroupClients,
+    getClientFieldName,
+  } = useManageClients(groupName)
+
+  const { mutateAsync: saveClients } = useToastMutation({
+    mutationFn: reconcileGroupClients,
+    loadingMsg: 'Saving client settings...',
+    successMsg: 'Client settings saved',
+    errorMsg: 'Failed to save client settings',
+  })
+
+  const handleManageClients = async () => {
+    const formSchema = z.object(
+      installedClients.reduce(
+        (acc, client) => {
+          const fieldName = getClientFieldName(client.client_type!)
+          acc[fieldName] = z.boolean()
+          return acc
+        },
+        {} as Record<string, z.ZodBoolean>
+      )
+    )
+
+    const result = await promptForm({
+      title: 'Manage Clients',
+      defaultValues,
+      resolver: zodV4Resolver(formSchema),
+      fields: (form: UseFormReturn<Record<string, boolean>>) => (
+        <div className="rounded-xl border">
+          {installedClients.map((client) => {
+            const fieldName = getClientFieldName(client.client_type!)
+            const displayName = client.client_type!
+
+            return (
+              <div
+                key={client.client_type}
+                className="flex items-start gap-2 border-b p-4 align-middle last:border-b-0"
+              >
+                <Switch
+                  id={fieldName}
+                  checked={form.watch(fieldName) as boolean}
+                  onCheckedChange={(checked) => {
+                    form.setValue(fieldName, checked)
+                    form.trigger(fieldName)
+                  }}
+                />
+
+                <Label htmlFor={fieldName} className="text-sm font-medium">
+                  {displayName}
+                </Label>
+              </div>
+            )
+          })}
+        </div>
+      ),
+      buttons: {
+        confirm: 'Save',
+        cancel: 'Cancel',
+      },
+    })
+
+    if (result) {
+      await saveClients(result)
+    }
+  }
 
   return (
     <Button
       variant={variant}
-      onClick={() => openDialog()}
+      onClick={handleManageClients}
       className={className}
     >
       <Code className="mr-2 h-4 w-4" />

renderer/src/features/clients/components/enable-group-button.tsx

@@ -94,15 +94,13 @@ export function CardMcpServer({
   url,
   remote,
   transport,
-  isInDisabledGroup,
 }: {
   name: string
   status: CoreWorkload['status']
   statusContext: CoreWorkload['status_context']
   remote?: CoreWorkload['remote']
   url: string
   transport: CoreWorkload['transport_type']
-  isInDisabledGroup?: boolean
 }) {
   const isRemoteMcpEnabled = useFeatureFlag(featureFlagKeys.REMOTE_MCP)
   const nameRef = useRef<HTMLElement | null>(null)
@@ -154,7 +152,6 @@ export function CardMcpServer({
         'transition-all duration-300 ease-in-out',
         isNewServer ? 'ring-2' : undefined,
         isDeleting ? 'pointer-events-none opacity-50' : undefined,
-        isInDisabledGroup ? 'opacity-50 grayscale' : undefined,
         (isTransitioning || hadRecentStatusChange) && 'animate-diagonal-ring',
         isStopped && 'bg-card/65'
       )}