fix: check isMaximized, warning tooltip, unreliable isToolhiveRunning and log severity (#907)

* fix: skip isMaximized if main window is not valid

* refactor: change from error to to info dor thv stderr

* fix: add staleTime 0 for thv running check

* fix: Tooltip was changing from controlled to uncontrolled

Author: samuv

main/src/main-window.ts

@@ -308,7 +308,10 @@ export function toggleMaximizeMainWindow(): void {
  */
 export function isMainWindowMaximized(): boolean {
   try {
-    return mainWindow?.isMaximized() ?? false
+    if (!isMainWindowValid()) {
+      return false
+    }
+    return mainWindow!.isMaximized()
   } catch (error) {
     log.error('Failed to check if window is maximized:', error)
     return false

main/src/toolhive-manager.ts

@@ -154,7 +154,7 @@ export async function startToolhive(tray?: Tray): Promise<void> {
         if (output.includes('A new version of ToolHive is available')) {
           return
         }
-        log.error(`[ToolHive stderr] ${output}`)
+        log.info(`[ToolHive stderr] ${output}`)
         scope.addBreadcrumb({
           category: 'debug',
           message: `[ToolHive stderr] ${output}`,

renderer/src/common/components/ui/tooltip.tsx

@@ -35,12 +35,19 @@ function Tooltip({ onlyWhenTruncated = false, ...props }: TooltipProps) {
     [onlyWhenTruncated]
   )
 
-  const effectiveOpen = onlyWhenTruncated
-    ? // if not truncated, force closed; otherwise respect consumer control
-      isTruncated
-      ? props.open
-      : false
-    : props.open
+  const effectiveOpen = React.useMemo(() => {
+    if (!onlyWhenTruncated) {
+      return props.open
+    }
+
+    // When onlyWhenTruncated is enabled, only show tooltip if text is truncated
+    if (!isTruncated) {
+      return false
+    }
+
+    // Text is truncated, respect consumer control or default to false
+    return props.open ?? false
+  }, [onlyWhenTruncated, isTruncated, props.open])
 
   return (
     <TooltipProvider>

renderer/src/routes/__root.tsx

@@ -100,6 +100,7 @@ export const Route = createRootRouteWithContext<{
       },
       retry: 3,
       retryDelay: 300,
+      staleTime: 0,
     })
     try {
       await queryClient.ensureQueryData({