changes from review

Author: taskbot

cmd/thv/app/proxy_stdio.go

@@ -13,14 +13,14 @@ import (
 )
 
 var proxyStdioCmd = &cobra.Command{
-	Use:   "stdio WORKLOAD-NAME SERVER_NAME",
+	Use:   "stdio WORKLOAD-NAME",
 	Short: "Create a stdio-based proxy for an MCP server",
 	Long: `Create a stdio-based proxy that connects stdin/stdout to a target MCP server.
 
 Example:
-  thv proxy stdio my-workload my-server-proxy
+  thv proxy stdio my-workload
 `,
-	Args: cobra.ExactArgs(2),
+	Args: cobra.ExactArgs(1),
 	RunE: proxyStdioCmdFunc,
 }
 
@@ -29,8 +29,6 @@ func proxyStdioCmdFunc(cmd *cobra.Command, args []string) error {
 	defer cancel()
 
 	workloadName := args[0]
-	serverName := args[1]
-
 	workloadManager, err := workloads.NewManager(ctx)
 	if err != nil {
 		return fmt.Errorf("failed to create workload manager: %w", err)
@@ -39,7 +37,7 @@ func proxyStdioCmdFunc(cmd *cobra.Command, args []string) error {
 	if err != nil {
 		return fmt.Errorf("failed to get workload %q: %w", workloadName, err)
 	}
-	logger.Infof("Starting stdio proxy for server=%q -> %s", serverName, workloadName)
+	logger.Infof("Starting stdio proxy for workload=%q", workloadName)
 
 	bridge, err := transport.NewStdioBridge(stdioWorkload.URL)
 	if err != nil {

docs/cli/thv_proxy_stdio.md

@@ -22,21 +22,19 @@ func generateUniqueProxyStdioServerName(prefix string) string {
 
 var _ = Describe("Proxy Stdio E2E", Serial, func() {
 	var (
-		config          *e2e.TestConfig
-		proxyCmd        *exec.Cmd
-		mcpServerName   string
-		workloadName    string
-		proxyServerName string
-		transportType   types.TransportType
-		proxyMode       string // e.g. "sse" or "streamable-http"
+		config        *e2e.TestConfig
+		proxyCmd      *exec.Cmd
+		mcpServerName string
+		workloadName  string
+		transportType types.TransportType
+		proxyMode     string // e.g. "sse" or "streamable-http"
 	)
 
 	BeforeEach(func() {
 		config = e2e.NewTestConfig()
 		err := e2e.CheckTHVBinaryAvailable(config)
 		Expect(err).ToNot(HaveOccurred())
 		workloadName = generateUniqueProxyStdioServerName("mcpserver-proxy-stdio--target")
-		proxyServerName = generateUniqueProxyStdioServerName("mcpserver-proxy-test")
 	})
 
 	JustBeforeEach(func() {
@@ -94,7 +92,6 @@ var _ = Describe("Proxy Stdio E2E", Serial, func() {
 			proxyCmd, stdin, outputBuffer := startProxyStdioForMCP(
 				config,
 				workloadName,
-				proxyServerName,
 			)
 
 			// Ensure the proxy started
@@ -146,7 +143,6 @@ var _ = Describe("Proxy Stdio E2E", Serial, func() {
 			proxyCmd, stdin, outputBuffer := startProxyStdioForMCP(
 				config,
 				workloadName,
-				proxyServerName,
 			)
 
 			// Ensure the proxy started
@@ -198,7 +194,6 @@ var _ = Describe("Proxy Stdio E2E", Serial, func() {
 			proxyCmd, stdin, outputBuffer := startProxyStdioForMCP(
 				config,
 				workloadName,
-				proxyServerName,
 			)
 
 			// Ensure the proxy started
@@ -230,12 +225,11 @@ var _ = Describe("Proxy Stdio E2E", Serial, func() {
 })
 
 // Helper functions
-func startProxyStdioForMCP(config *e2e.TestConfig, workloadName string, proxyServerName string) (*exec.Cmd, io.WriteCloser, *bytes.Buffer) {
+func startProxyStdioForMCP(config *e2e.TestConfig, workloadName string) (*exec.Cmd, io.WriteCloser, *bytes.Buffer) {
 	args := []string{
 		"proxy",
 		"stdio",
 		workloadName,
-		proxyServerName,
 	}
 
 	// Log the command for debugging