Fix failing single test and operator deployment from custom helm chart values. (#1063)

    * Fix TestDefaultPlatformDetector_DetectPlatform test for case when OPERATOR_OPENSHIFT env var is true.
    * Add empty runAsUser to values-openshift.yaml to allow OpenShift to set it.

Signed-off-by: Roddie Kieley <[email protected]>
Co-authored-by: Cursor claude-4 <[email protected]>

Author: RoddieKieley

deploy/charts/operator/values-openshift.yaml

@@ -50,6 +50,7 @@ operator:
     allowPrivilegeEscalation: false
     readOnlyRootFilesystem: true
     runAsNonRoot: true
+    runAsUser:
     capabilities:
       drop:
       - ALL

pkg/container/kubernetes/common_test.go

@@ -60,14 +60,23 @@ func TestDefaultPlatformDetector_DetectPlatform(t *testing.T) {
 		Host: "http://localhost:12345", // Non-existent endpoint
 	}
 
-	// The first call should return an error
+	// The first call should return either an error or success based on environment
 	platform1, err1 := detector.DetectPlatform(config)
-	assert.Error(t, err1)
-	assert.Equal(t, PlatformKubernetes, platform1) // Default value when error occurs
 
-	// The second call should return the same error (cached)
+	// The second call should return the same result (cached)
 	platform2, err2 := detector.DetectPlatform(config)
-	assert.Error(t, err2)
+
+	// Verify that both calls return the same result (caching works)
 	assert.Equal(t, platform1, platform2)
-	assert.Equal(t, err1.Error(), err2.Error())
+
+	// Verify error consistency
+	if err1 != nil {
+		assert.Error(t, err2, "Both calls should return the same error state")
+		assert.Equal(t, err1.Error(), err2.Error())
+		assert.Equal(t, PlatformKubernetes, platform1) // Default value when error occurs
+	} else {
+		assert.NoError(t, err2, "Both calls should return the same error state")
+		// When OPERATOR_OPENSHIFT=true, we expect OpenShift platform
+		assert.Equal(t, PlatformOpenShift, platform1)
+	}
 }