fixes from review

Author: taskbot

pkg/transport/proxy/transparent/transparent_proxy.go

@@ -126,14 +126,13 @@ func (t *tracingTransport) watchEventStream(r io.Reader, w *io.PipeWriter) {
 			if sid == "" {
 				sid = m[2]
 			}
-
+			t.setServerInitialized()
 			if _, ok := t.p.sessionManager.Get(sid); !ok {
-				_, err := t.p.sessionManager.AddWithID(sid)
+				err := t.p.sessionManager.AddWithID(sid)
 				if err != nil {
 					logger.Errorf("Failed to create session from event stream: %v", err)
 				}
 			}
-			t.setServerInitialized()
 		}
 	}
 
@@ -167,7 +166,7 @@ func (t *tracingTransport) RoundTrip(req *http.Request) (*http.Response, error)
 		if ct != "" {
 			logger.Infof("Detected Mcp-Session-Id header: %s", ct)
 			if _, ok := t.p.sessionManager.Get(ct); !ok {
-				if _, err := t.p.sessionManager.AddWithID(ct); err != nil {
+				if err := t.p.sessionManager.AddWithID(ct); err != nil {
 					logger.Errorf("Failed to create session from header %s: %v", ct, err)
 				}
 			}

pkg/transport/session/manager.go

@@ -49,21 +49,21 @@ func (m *Manager) cleanupRoutine() {
 
 // AddWithID creates (and adds) a new session with the provided ID.
 // Returns error if ID is empty or already exists.
-func (m *Manager) AddWithID(id string) (Session, error) {
+func (m *Manager) AddWithID(id string) error {
 	if id == "" {
-		return nil, fmt.Errorf("session ID cannot be empty")
+		return fmt.Errorf("session ID cannot be empty")
 	}
 
 	m.mu.Lock()
 	defer m.mu.Unlock()
 
 	if _, exists := m.sessions[id]; exists {
-		return nil, fmt.Errorf("session ID %q already exists", id)
+		return fmt.Errorf("session ID %q already exists", id)
 	}
 
 	s := NewProxySession(id)
 	m.sessions[id] = s
-	return s, nil
+	return nil
 }
 
 // Get retrieves a session by ID. Returns (session, true) if found,