Skip to content

Commit d3ba6e2

Browse files
danbarrChrisJBurns
andauthored
Fix mkp manifest example (#1705)
Updates the example manifest for the MKP MCP server to correctly assign the service account for the workload pod. Also added an example ServiceAccount and ClusterRoleBinding resource for example purposes. --------- Signed-off-by: Dan Barr <[email protected]> Co-authored-by: Dan Barr <[email protected]> Co-authored-by: Chris Burns <[email protected]>
1 parent 97116b6 commit d3ba6e2

File tree

1 file changed

+33
-12
lines changed

1 file changed

+33
-12
lines changed

examples/operator/mcp-servers/mcpserver_mkp.yaml

Lines changed: 33 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,43 @@ metadata:
55
namespace: toolhive-system
66
spec:
77
image: ghcr.io/stackloklabs/mkp/server
8-
transport: sse
8+
transport: streamable-http
9+
targetPort: 8080
910
port: 8080
11+
args:
12+
# Change to true for read-write access.
13+
- --read-write=false
1014
permissionProfile:
1115
type: builtin
1216
name: network
13-
podTemplateSpec:
14-
spec:
15-
# this will not be needed once we have implemented separate
16-
# service accounts for each MCP server and its proxyrunner
17-
serviceAccountName: mkp-proxy-runner
18-
containers:
19-
- name: mcp
17+
# We create this service account below with the desired permissions.
18+
serviceAccount: mkp-sa
2019
resources:
2120
limits:
22-
cpu: "100m"
23-
memory: "128Mi"
21+
cpu: '100m'
22+
memory: '128Mi'
2423
requests:
25-
cpu: "50m"
26-
memory: "64Mi"
24+
cpu: '50m'
25+
memory: '64Mi'
26+
---
27+
apiVersion: v1
28+
kind: ServiceAccount
29+
metadata:
30+
name: mkp-sa
31+
namespace: toolhive-system
32+
---
33+
# NOTE: This ClusterRoleBinding uses cluster-admin for example purposes only.
34+
# In production, you should create a custom ClusterRole with the minimum
35+
# permissions required by your MCP server instead of using cluster-admin.
36+
apiVersion: rbac.authorization.k8s.io/v1
37+
kind: ClusterRoleBinding
38+
metadata:
39+
name: mkp-sa-cluster-admin
40+
subjects:
41+
- kind: ServiceAccount
42+
name: mkp-sa
43+
namespace: toolhive-system
44+
roleRef:
45+
kind: ClusterRole
46+
name: cluster-admin
47+
apiGroup: rbac.authorization.k8s.io

0 commit comments

Comments
 (0)