Skip to content

Conversation

@francesco-stacks
Copy link

@francesco-stacks francesco-stacks commented Nov 25, 2025

Description

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

@francesco-stacks francesco-stacks self-assigned this Nov 25, 2025
@francesco-stacks francesco-stacks added the aac Avoiding Accidental Consensus label Nov 25, 2025
@francesco-stacks francesco-stacks added the aac-testing Avoiding Accidental Consensus Testing Specific Task label Nov 25, 2025
@francesco-stacks francesco-stacks moved this to Status: In Review in Stacks Core Eng Nov 25, 2025
@francesco-stacks francesco-stacks marked this pull request as ready for review November 25, 2025 15:02
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 94.31818% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.59%. Comparing base (44fdf84) to head (74b0a77).

Files with missing lines Patch % Lines
...slib/src/chainstate/tests/static_analysis_tests.rs 94.31% 5 Missing ⚠️

❌ Your project check has failed because the head coverage (75.59%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6716      +/-   ##
===========================================
+ Coverage    73.67%   75.59%   +1.91%     
===========================================
  Files          577      577              
  Lines       357795   357883      +88     
===========================================
+ Hits        263596   270529    +6933     
+ Misses       94199    87354    -6845     
Files with missing lines Coverage Δ
...slib/src/chainstate/tests/static_analysis_tests.rs 86.83% <94.31%> (+2.73%) ⬆️

... and 316 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44fdf84...74b0a77. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jacinta-stacks
jacinta-stacks previously approved these changes Nov 25, 2025
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Nov 25, 2025
@jacinta-stacks jacinta-stacks added this pull request to the merge queue Nov 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aac Avoiding Accidental Consensus aac-testing Avoiding Accidental Consensus Testing Specific Task

Projects

Status: Status: 💻 In Progress

Development

Successfully merging this pull request may close these issues.

4 participants