Add mean argument to pre-specified laplace likelihoods #1523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1523 +/- ##
=======================================
Coverage 89.77% 89.77%
=======================================
Files 66 66
Lines 9904 9904
=======================================
Hits 8891 8891
Misses 1013 1013
🚀 New features to boost your workflow:
|
26 tasks
4 tasks
SteveBronder
reviewed
Jul 8, 2025
SteveBronder
reviewed
Jul 8, 2025
SteveBronder
requested changes
Jul 8, 2025
|
Good catch, all updated |
SteveBronder
reviewed
Jul 8, 2025
Comment on lines
589
to
597
| Ill-typed arguments supplied to function 'laplace_latent_tol_neg_binomial_2_log_rng' | ||
| for the likelihood: | ||
| The fourth argument must be vector but got <F1>. | ||
| where F1 = (array[] vector, int, real, real) => matrix | ||
| Expected the arguments to start with: | ||
| (array[] int, array[] int, vector, vector) | ||
| Recieved 0 control arguments at the end of the call to 'laplace_latent_tol_neg_binomial_2_log_rng'. | ||
| Expected 6 arguments for the control parameters instead. |
There was a problem hiding this comment.
Is this supposed to be different?
There was a problem hiding this comment.
Yes, you were looking only at the one commit diff. If you look at the overall diff of the PR you will see the message did not change.
SteveBronder
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart to stan-dev/math#3210. Similarly, it is branched off of #1521 to avoid conflicts
Submission Checklist
Release notes
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)