Continued cleanup of old AppleJavaExtrensions and moving to Java 11

Delete other old files related to AppleJavaExtensions
Clean up button ordering and dialog titles in TregexGUI
Change build files to specify Java 11

Author: manning

build.gradle

@@ -7,8 +7,8 @@ apply plugin: 'eclipse'
 apply plugin: 'application'
 
 // Gradle java plugin
-sourceCompatibility = 1.8
-targetCompatibility = 1.8
+sourceCompatibility = 11
+targetCompatibility = 11
 compileJava.options.encoding = 'UTF-8'
 
 version = '4.5.10'

build.xml

@@ -16,8 +16,8 @@
   <property name="compile.debug"       value="true"/>
   <property name="compile.deprecation" value="false"/>
   <property name="compile.optimize"    value="true"/>
-  <property name="compile.source"      value="1.8" />
-  <property name="compile.target"      value="1.8" />
+  <property name="compile.source"      value="11" />
+  <property name="compile.target"      value="11" />
   <property name="compile.encoding"    value="utf-8" />
 
   <target name="classpath" description="Sets the classpath">
@@ -56,7 +56,7 @@
     <javadoc destdir="${javadoc.path}"
              maxmemory="1200m"
              author="true"
-             source="1.8"
+             source="11"
              Overview="${basedir}/src/edu/stanford/nlp/overview.html"
              Doctitle="Stanford JavaNLP API Documentation"
              Windowtitle="Stanford JavaNLP API"
@@ -81,7 +81,7 @@
       </classpath>
 
       <bottom><![CDATA[<font size="2"><a href="https://nlp.stanford.edu" target="_top">Stanford NLP Group</a></font>]]></bottom>
-      <link href="http://docs.oracle.com/javase/8/docs/api/"/>
+      <link href="https://docs.oracle.com/en/java/javase/11/docs/api/"/>
     </javadoc>
 
   </target>

module_core.xml

@@ -6,7 +6,7 @@
   <property name="module.jdk.bin.core" value="${project.jdk.bin}"/>
   <property name="module.jdk.classpath.core" value="${project.jdk.classpath}"/>
 
-  <property name="compiler.args.core" value="-encoding UTF-8 -source 8 ${compiler.args}"/>
+  <property name="compiler.args.core" value="-encoding UTF-8 -source 11 ${compiler.args}"/>
 
   <property name="core.output.dir" value="${module.core.basedir}/../action_parsing/out/production/core"/>
   <property name="core.testoutput.dir" value="${module.core.basedir}/../action_parsing/out/test/core"/>
@@ -81,4 +81,4 @@
     <delete dir="${core.output.dir}"/>
     <delete dir="${core.testoutput.dir}"/>
   </target>
-</project>
+</project>

pom-java-11.xml

@@ -35,8 +35,6 @@
     </developer>
   </developers>
   <properties>
-    <maven.compiler.source>1.8</maven.compiler.source>
-    <maven.compiler.target>1.8</maven.compiler.target>
     <encoding>UTF-8</encoding>
   </properties>
   <dependencies>
@@ -158,7 +156,7 @@
       <artifactId>jaxb-api</artifactId>
       <version>2.4.0-b180830.0359</version>
     </dependency>
-    
+
     <dependency>
       <groupId>com.sun.istack</groupId>
       <artifactId>istack-commons-runtime</artifactId>
@@ -199,6 +197,14 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>3.8.1</version>
+        <configuration>
+            <release>11</release>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 </project>

pom.xml

@@ -130,10 +130,14 @@ public void addMacro(String original, String replacement) {
    * @throws TregexParseException If the expression is syntactically invalid
    */
   public TregexPattern compile(String tregex) {
+    if (tregex == null || tregex.isEmpty()) {
+      throw new TregexParseException("Empty Tregex expression", null);
+    }
     for (Pair<String, String> macro : macros) {
       tregex = tregex.replaceAll(macro.first(), macro.second());
     }
     TregexPattern pattern;
+
     try {
       TregexParser parser = new TregexParser(new StringReader(tregex + '\n'),
                                              basicCatFunction, headFinder);

src/edu/stanford/nlp/trees/tregex/TregexPatternCompiler.java

@@ -261,21 +261,20 @@ private void addMatch(TreeFromFile match, List<Tree> matchedParts) {
   }
 
   void showPrevMatchedPart() {
-    if (matchedPartCoordinates.size() == 0)
+    if (matchedPartCoordinates == null || matchedPartCoordinates.size() == 0) {
       return;
-    else if (matchedPartCoordinateIdx <= 0)
+    } else if (matchedPartCoordinateIdx <= 0)
       matchedPartCoordinateIdx = matchedPartCoordinates.size();
 
     matchedPartCoordinateIdx--;
     showMatchedPart(matchedPartCoordinateIdx);
   }
 
   void showNextMatchedPart() {
-    if (matchedPartCoordinates.size() == 0)
+    if (matchedPartCoordinates == null || matchedPartCoordinates.size() == 0) {
       return;
-
-    matchedPartCoordinateIdx =
-      ++matchedPartCoordinateIdx % matchedPartCoordinates.size();
+    }
+    matchedPartCoordinateIdx = ++matchedPartCoordinateIdx % matchedPartCoordinates.size();
     showMatchedPart(matchedPartCoordinateIdx);
   }