[5.x] Fixed preProcessIndex options labels for numeric keys #12840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes select option key is shown on index instead of label Might fix statamic#12667 as well
mmodler
changed the title
Contributor
Author
|
After digging deeper into test fails i updated my fix. @jasonvarga There are no tests for preProcessIndex with labels yet? |
Member
|
@mmodler Would you be able to better explain the issue that this is fixing? It seems to work fine without it. 
|
Contributor
Author
|
@jasonvarga You're absolutely right, I was on the wrong track. It only occurred in Runway collections when the value was passed to getLabel() as a string. I just changed the db column type to integer and everything works fine. |
Member
|
Awesome, thanks for following up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes select option key is shown on index instead of label
Might fix #12667 as well