Fix several compiler warnings

Hammie · Hammie · commit 63faa88b9b21 · 2023-04-19T14:18:35.000+02:00
diff --git a/src/libs/animation/src/animation_imp.cpp b/src/libs/animation/src/animation_imp.cpp
@@ -240,6 +240,7 @@ void AnimationImp::BuildAnimationMatrices()
 
     // Auto normalization
     if (normBlend != 0.0f)
+    {
         if (plCnt > 1)
         {
             normBlend = 1.0f / normBlend;
@@ -381,6 +382,7 @@ void AnimationImp::BuildAnimationMatrices()
             //    for(int32_t j = 0; j < nbones; j++)
             //        aniInfo->GetBone(j).BlendFrame(frame);
         }
+    }
     for (int32_t j = 0; j < nbones; j++)
     {
         auto &bn = aniInfo->GetBone(j);
diff --git a/src/libs/battle_interface/src/battle_command.cpp b/src/libs/battle_interface/src/battle_command.cpp
@@ -272,7 +272,8 @@ void BICommandList::Init()
             sscanf(pAList->GetAttribute("CommandNoteOffset"), "%d,%d", &m_NoteOffset.x, &m_NoteOffset.y);
 
         // Setting values for arrows (up / down)
-        if (attr = pAList->GetAttribute("UDArrow_Texture"))
+        attr = pAList->GetAttribute("UDArrow_Texture");
+        if (attr)
             m_sUpDownArrowTexture = attr;
         BIUtils::ReadRectFromAttr(pAList, "UDArrow_UV_Up", m_frUpArrowUV, m_frUpArrowUV);
         BIUtils::ReadRectFromAttr(pAList, "UDArrow_UV_Down", m_frDownArrowUV, m_frDownArrowUV);
@@ -283,7 +284,8 @@ void BICommandList::Init()
         BIUtils::ReadPosFromAttr(pAList, "UDArrow_Offset_Down", m_pntDownArrowOffset.x, m_pntDownArrowOffset.y,
                                  m_pntDownArrowOffset.x, m_pntDownArrowOffset.y);
 
-        if (attr = pAList->GetAttribute("LRArrow_Texture"))
+        attr = pAList->GetAttribute("LRArrow_Texture");
+        if (attr)
             m_sLeftRightArrowTexture = attr;
         BIUtils::ReadRectFromAttr(pAList, "LRArrow_UV_Left", m_frLeftArrowUV, m_frLeftArrowUV);
         BIUtils::ReadRectFromAttr(pAList, "LRArrow_UV_Right", m_frRightArrowUV, m_frRightArrowUV);
@@ -295,15 +297,17 @@ void BICommandList::Init()
                                  m_pntRightArrowOffset.x, m_pntRightArrowOffset.y);
 
         // set values for the menu activity icon
-        if (attr = pAList->GetAttribute("ActiveIcon_Texture"))
+        attr = pAList->GetAttribute("ActiveIcon_Texture");
+        if (attr)
             m_sActiveIconTexture = attr;
         BIUtils::ReadPosFromAttr(pAList, "ActiveIcon_Offset", m_pntActiveIconOffset.x, m_pntActiveIconOffset.y,
                                  m_pntActiveIconOffset.x, m_pntActiveIconOffset.y);
         BIUtils::ReadPosFromAttr(pAList, "ActiveIcon_Size", m_pntActiveIconSize.x, m_pntActiveIconSize.y,
                                  m_pntActiveIconSize.x, m_pntActiveIconSize.y);
         BIUtils::ReadRectFromAttr(pAList, "ActiveIcon_UV1", m_frActiveIconUV1, m_frActiveIconUV1);
         BIUtils::ReadRectFromAttr(pAList, "ActiveIcon_UV2", m_frActiveIconUV2, m_frActiveIconUV2);
-        if (attr = pAList->GetAttribute("ActiveIcon_Note"))
+        attr = pAList->GetAttribute("ActiveIcon_Note");
+        if (attr)
             m_sActiveIconNote = attr;
     }
 
diff --git a/src/libs/battle_interface/src/battle_sign.cpp b/src/libs/battle_interface/src/battle_sign.cpp
@@ -164,7 +164,11 @@ void BISignIcon::Init(ATTRIBUTES *pRoot, ATTRIBUTES *pA)
 
         pcTmp = pA->GetAttribute("fontoffset");
         if (pcTmp)
-            sscanf(pcTmp, "%ld,%ld", &m_SignTextFontOffset.x, &m_SignTextFontOffset.y);
+        {
+            long x{}, y{};
+            sscanf(pcTmp, "%ld,%ld", &x, &y);
+            m_SignTextFontOffset = {x, y};
+        }
 
         pcTmp = pA->GetAttribute("backtexturename");
         if (pcTmp)
diff --git a/src/libs/battle_interface/src/item_entity/item_entity.cpp b/src/libs/battle_interface/src/item_entity/item_entity.cpp
@@ -26,10 +26,16 @@ bool ItemEntity::Init()
 void ItemEntity::Realize(uint32_t delta_time)
 {
     if (m_bVisible && m_pModel)
+    {
         if (m_bTieToLocator)
+        {
             DrawIntoLocator();
+        }
         else
+        {
             m_pModel->ProcessStage(Stage::realize, delta_time);
+        }
+    }
 }
 
 uint64_t ItemEntity::ProcessMessage(MESSAGE &message)
@@ -107,7 +113,8 @@ bool ItemEntity::ReadAndCreate()
     auto *const pcTechnique = BIUtils::GetStringFromAttr(AttributesPointer, "technique", "");
     if (pcModelName)
     {
-        if (m_eidModel = core.CreateEntity("modelr"))
+        m_eidModel = core.CreateEntity("modelr");
+        if (m_eidModel)
         {
             core.Send_Message(m_eidModel, "ls", MSG_MODEL_LOAD_GEO, pcModelName);
             m_pModel = static_cast<MODEL *>(core.GetEntityPointer(m_eidModel));
diff --git a/src/libs/battle_interface/src/sea/battle_ship_sign.cpp b/src/libs/battle_interface/src/sea/battle_ship_sign.cpp
@@ -195,7 +195,11 @@ void BIShipIcon::Init(ATTRIBUTES *pRoot, ATTRIBUTES *pA)
         // ugeen 150920
         pcTmp = pA->GetAttribute("sailorfontoffset");
         if (pcTmp)
-            sscanf(pcTmp, "%ld,%ld", &m_SailorFontOffset.x, &m_SailorFontOffset.y);
+        {
+            long x{}, y{};
+            sscanf(pcTmp, "%ld,%ld", &x, &y);
+            m_SailorFontOffset = {x, y};
+        }
 
         pcTmp = pA->GetAttribute("shipnamefontid");
         if (pcTmp)
@@ -205,7 +209,11 @@ void BIShipIcon::Init(ATTRIBUTES *pRoot, ATTRIBUTES *pA)
 
         pcTmp = pA->GetAttribute("shipnamefontoffset");
         if (pcTmp)
-            sscanf(pcTmp, "%ld,%ld", &m_ShipNameFontOffset.x, &m_ShipNameFontOffset.y);
+        {
+            long x{}, y{};
+            sscanf(pcTmp, "%ld,%ld", &x, &y);
+            m_ShipNameFontOffset = {x, y};
+        }
 
         pcTmp = pA->GetAttribute("backtexturename");
         if (pcTmp)
diff --git a/src/libs/battle_interface/src/sea/island_descr.cpp b/src/libs/battle_interface/src/sea/island_descr.cpp
@@ -65,12 +65,14 @@ void ISLAND_DESCRIBER::SetIsland(ATTRIBUTES *pAIsland)
         {
             int32_t lTmp;
             if (pvdat->Get(lTmp, 0))
+            {
                 if (lTmp == 0)
                     m_pLocators[i].locatorType = ISLAND_LOCATOR_LAND;
                 else if (lTmp == 1)
                     m_pLocators[i].locatorType = ISLAND_LOCATOR_FORT;
                 else
                     m_pLocators[i].locatorType = ISLAND_LOCATOR_TOWN;
+            }
             if (pvdat->Get(lTmp, 1))
                 m_pLocators[i].relation = lTmp;
             if (pvdat->Get(lTmp, 2))
diff --git a/src/libs/blot/src/blots.cpp b/src/libs/blot/src/blots.cpp
@@ -76,9 +76,7 @@ uint64_t Blots::ProcessMessage(MESSAGE &message)
         if (pCharAttributeRoot)
         {
             blotsInfo = pCharAttributeRoot->CreateSubAClass(pCharAttributeRoot, "ship.blots");
-            char buf[32];
-            sprintf_s(buf, "%i", BLOTS_MAX);
-            blotsInfo->SetValue(buf);
+            blotsInfo->SetValue(std::to_string(BLOTS_MAX));
             for (int32_t i = 0; i < BLOTS_MAX; i++)
                 LoadBlot(i);
         }
diff --git a/src/libs/core/src/core_impl.h b/src/libs/core/src/core_impl.h
@@ -13,17 +13,17 @@
 class CoreImpl final : public CorePrivate
 {
   public:
-    void Init();
+    void Init() override;
 
-    void InitBase();
-    void ReleaseBase();
+    void InitBase() override;
+    void ReleaseBase() override;
 
-    void CleanUp();
+    void CleanUp() override;
 
     void SetWindow(std::shared_ptr<storm::OSWindow> window) override;
     bool Initialize();
     void ResetCore();
-    bool Run();
+    bool Run() override;
     bool LoadClassesTable();
 
     void ProcessExecute();
@@ -43,7 +43,7 @@ class CoreImpl final : public CorePrivate
     void EraseEntities();
     void ClearEvents();
     void *MakeClass(const char *class_name);
-    void AppState(bool state);
+    void AppState(bool state) override;
     uint32_t MakeHashValue(const char *string);
     VMA *FindVMA(const char *class_name);
     VMA *FindVMA(int32_t hash);
@@ -133,9 +133,9 @@ class CoreImpl final : public CorePrivate
     bool IsLayerFrozen(layer_index_t index) const override;
     void ForEachEntity(const std::function<void(entptr_t)>& f) override;
 
-    void collectCrashInfo() const;
+    void collectCrashInfo() const override;
 
-    [[nodiscard]] bool initialized() const
+    [[nodiscard]] bool initialized() const override
     {
         return Initialized;
     }
diff --git a/src/libs/core/src/data.cpp b/src/libs/core/src/data.cpp
@@ -402,9 +402,9 @@ void DATA::Set(const char *attribute_name, const char *attribute_value)
             return;
         }
 
-        AttributesClass = new ATTRIBUTES(pVCompiler->GetVSC());
+        AttributesClass = new ATTRIBUTES(*pVCompiler->GetVSC());
     }
-    AttributesClass->SetAttribute(attribute_name, attribute_value);
+    AttributesClass->SetAttribute(std::string_view(attribute_name), std::string_view(attribute_value));
     // Attributes.SetAttribute(attribute_name,attribute_value);
 }
 
@@ -2357,7 +2357,7 @@ ATTRIBUTES *DATA::GetAClass()
             return nullptr;
         }
 
-        AttributesClass = new ATTRIBUTES(pVCompiler->GetVSC());
+        AttributesClass = new ATTRIBUTES(*pVCompiler->GetVSC());
     }
     return AttributesClass;
 }
diff --git a/src/libs/core/src/message.cpp b/src/libs/core/src/message.cpp
@@ -1,5 +1,3 @@
-#pragma once
-
 #include "message.h"
 
 #include <algorithm>
diff --git a/src/libs/island/src/island.cpp b/src/libs/island/src/island.cpp
@@ -9,6 +9,8 @@
 #include "tga.h"
 #include <cstdio>
 
+using storm::Sqr;
+
 CREATE_CLASS(ISLAND)
 
 CREATE_CLASS(CoastFoam)
diff --git a/src/libs/math/include/math3d.h b/src/libs/math/include/math3d.h
@@ -94,13 +94,13 @@ inline float sqrf(float f)
 // Random number
 inline float Rnd(float max = 1.0f)
 {
-    return rand() * (max * (1.0f / RAND_MAX));
+    return storm::RandomFloat(max);
 }
 
 // Random number
 inline float RRnd(float min, float max)
 {
-    return min + rand() * ((max - min) * (1.0f / RAND_MAX));
+    return min + storm::RandomFloat(max - min);
 }
 
 // Limit float
diff --git a/src/libs/math/include/math3d/vector.h b/src/libs/math/include/math3d/vector.h
@@ -6,8 +6,9 @@
 
 #pragma once
 
-#include <math.h>
-#include <stdlib.h>
+#include "../math_common.hpp"
+
+#include <cstdlib>
 
 #pragma pack(push, 1)
 
@@ -1042,32 +1043,32 @@ inline Vector &Vector::Reflection(const Vector &normal)
 // Fill with a unit vector with a random direction
 inline Vector &Vector::Rand()
 {
-    Make2D(rand() * ((2.0f * 3.141592654f) / RAND_MAX));
+    Make2D(storm::RandomFloat(2.0f * 3.141592654f));
     y = z;
     z = 0.0f;
-    return Rotate(rand() * ((2.0f * 3.141592654f) / RAND_MAX));
+    return Rotate(storm::RandomFloat(2.0f * 3.141592654f));
 }
 
 // Fill with unit vector with random direction in XZ
 inline Vector &Vector::Rand2D()
 {
-    return Make2D(rand() * ((2.0f * 3.141592654f) / RAND_MAX));
+    return Make2D(storm::RandomFloat(2.0f * 3.141592654f));
 }
 
 // Fill with random values in a given ABB
 inline Vector &Vector::Rand(const Vector &min, const Vector &max)
 {
-    x = min.x + rand() * ((max.x - min.x) * (1.0f / RAND_MAX));
-    y = min.y + rand() * ((max.y - min.y) * (1.0f / RAND_MAX));
-    z = min.z + rand() * ((max.z - min.z) * (1.0f / RAND_MAX));
+    x = min.x + storm::RandomFloat(max.x - min.x);
+    x = min.y + storm::RandomFloat(max.y - min.y);
+    x = min.z + storm::RandomFloat(max.z - min.z);
     return *this;
 }
 
 // Fill with random values in a given sphere
 inline Vector &Vector::Rand(const Vector &pos, float radius)
 {
     Rand();
-    *this *= rand() * (radius * (1.0f / RAND_MAX));
+    *this *= storm::RandomFloat(radius);
     return *this;
 }
 
diff --git a/src/libs/math/include/math_common.hpp b/src/libs/math/include/math_common.hpp
@@ -0,0 +1,25 @@
+#pragma once
+
+#include <cmath>
+
+#ifdef SQR
+#undef SQR
+#endif
+
+#define SQR(x) ::storm::Sqr(x)
+#define FRAND(x) ::storm::RandomFloat(x)
+
+namespace storm {
+
+constexpr const float kRandMaxFloat = static_cast<float>(RAND_MAX);
+
+inline float RandomFloat(const float x) {
+    return x * static_cast<float>(rand()) / storm::kRandMaxFloat;
+}
+
+template<typename T>
+inline T Sqr(const T x) {
+    return x * x;
+}
+
+} // namespace storm
diff --git a/src/libs/math/include/math_inlines.h b/src/libs/math/include/math_inlines.h
@@ -1,14 +1,14 @@
 #pragma once
 
+#include "math_common.hpp"
+
 #include <cstdint>
 #include <cmath>
 
 #include <xmmintrin.h>
 
 #include "c_vector.h"
 
-#define SQR(a) ((a) * (a))
-#define FRAND(x) ((x) * (float)rand() / (float)RAND_MAX)
 #define SIGN(x) ((x) < 0 ? -1.0f : 1.0f)
 #define SIGNZ(x) ((x) == 0.0f ? 0.0f : ((x) < 0.0f ? -1.0f : 1.0f))
 #define MAX(x, y) (((x) > (y)) ? (x) : (y))
@@ -63,11 +63,6 @@ template <class T> T Max(T t1, T t2)
     return ((t1 > t2) ? t1 : t2);
 };
 
-template <class T> T Sqr(T t1)
-{
-    return (t1 * t1);
-};
-
 constexpr float PI = 3.14159265358979323846f;
 constexpr float PIm2 = (PI * 2.0f);
 constexpr float PId2 = (PI / 2.0f);
diff --git a/src/libs/math/include/types3d.h b/src/libs/math/include/types3d.h
@@ -1,14 +1,10 @@
 #pragma once
 
+#include "math_common.hpp"
+
 #pragma pack(push)
 #pragma pack(1)
 
-#ifdef SQR
-#undef SQR
-#endif
-
-#define SQR(x) ((x) * (x))
-
 typedef struct
 {
     float x;
diff --git a/src/libs/sea/src/sea.cpp b/src/libs/sea/src/sea.cpp
@@ -12,6 +12,8 @@
 #include "tga.h"
 #include "v_file_service.h"
 
+using storm::Sqr;
+
 CREATE_CLASS(SEA)
 
 //#define OLD_WORLD_POS
diff --git a/src/libs/sea_ai/src/ai_balls.cpp b/src/libs/sea_ai/src/ai_balls.cpp
@@ -3,6 +3,8 @@
 #include "math_inlines.h"
 #include "shared/messages.h"
 
+using storm::Sqr;
+
 AIBalls *AIBalls::pAIBalls = nullptr;
 
 AIBalls::AIBalls()
diff --git a/src/libs/util/include/utf8.h b/src/libs/util/include/utf8.h
@@ -114,7 +114,7 @@ inline int Utf8ToCodepoint(const char *utf8)
     if (u0 >= 0xC0 && u0 <= 0xDF)
         return (u0 - 192) * 64 + (u1 - 128);
 
-    if (utf8[0] == 0xed && (utf8[1] & 0xa0) == 0xa0)
+    if (u0 == 0xed && (u1 & 0xa0) == 0xa0)
         return -1; // code points, 0xd800 to 0xdfff
 
     if (l < 3)
diff --git a/src/libs/xinterface/testsuite/options_parser.cpp b/src/libs/xinterface/testsuite/options_parser.cpp

Original file line number	Diff line number	Diff line change
`@@ -240,6 +240,7 @@ void AnimationImp::BuildAnimationMatrices()`
`240`	`240`
`241`	`241`	`// Auto normalization`
`242`	`242`	`if (normBlend != 0.0f)`
	`243`	`+ {`
`243`	`244`	`if (plCnt > 1)`
`244`	`245`	`{`
`245`	`246`	`normBlend = 1.0f / normBlend;`
`@@ -381,6 +382,7 @@ void AnimationImp::BuildAnimationMatrices()`
`381`	`382`	`// for(int32_t j = 0; j < nbones; j++)`
`382`	`383`	`// aniInfo->GetBone(j).BlendFrame(frame);`
`383`	`384`	`}`
	`385`	`+ }`
`384`	`386`	`for (int32_t j = 0; j < nbones; j++)`
`385`	`387`	`{`
`386`	`388`	`auto &bn = aniInfo->GetBone(j);`
Original file line number	Diff line number	Diff line change
`@@ -76,9 +76,7 @@ uint64_t Blots::ProcessMessage(MESSAGE &message)`
`76`	`76`	`if (pCharAttributeRoot)`
`77`	`77`	`{`
`78`	`78`	`blotsInfo = pCharAttributeRoot->CreateSubAClass(pCharAttributeRoot, "ship.blots");`
`79`		`- char buf[32];`
`80`		`- sprintf_s(buf, "%i", BLOTS_MAX);`
`81`		`- blotsInfo->SetValue(buf);`
	`79`	`+ blotsInfo->SetValue(std::to_string(BLOTS_MAX));`
`82`	`80`	`for (int32_t i = 0; i < BLOTS_MAX; i++)`
`83`	`81`	`LoadBlot(i);`
`84`	`82`	`}`
Original file line number	Diff line number	Diff line change
`@@ -402,9 +402,9 @@ void DATA::Set(const char attribute_name, const char attribute_value)`
`402`	`402`	`return;`
`403`	`403`	`}`
`404`	`404`
`405`		`- AttributesClass = new ATTRIBUTES(pVCompiler->GetVSC());`
	`405`	`+ AttributesClass = new ATTRIBUTES(*pVCompiler->GetVSC());`
`406`	`406`	`}`
`407`		`- AttributesClass->SetAttribute(attribute_name, attribute_value);`
	`407`	`+ AttributesClass->SetAttribute(std::string_view(attribute_name), std::string_view(attribute_value));`
`408`	`408`	`// Attributes.SetAttribute(attribute_name,attribute_value);`
`409`	`409`	`}`
`410`	`410`
`@@ -2357,7 +2357,7 @@ ATTRIBUTES *DATA::GetAClass()`
`2357`	`2357`	`return nullptr;`
`2358`	`2358`	`}`
`2359`	`2359`
`2360`		`- AttributesClass = new ATTRIBUTES(pVCompiler->GetVSC());`
	`2360`	`+ AttributesClass = new ATTRIBUTES(*pVCompiler->GetVSC());`
`2361`	`2361`	`}`
`2362`	`2362`	`return AttributesClass;`
`2363`	`2363`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-#pragma once`
`2`		`-`
`3`	`1`	`#include "message.h"`
`4`	`2`
`5`	`3`	`#include <algorithm>`