[WIP] Automating First Order Initialisation When Using MUSCL #2544
+146
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshkellyjak
reviewed
Oct 1, 2025
| * \return yes/no. | ||
| */ | ||
| bool GetFirst_Order_Init(void) const { return First_Order_Initialization; } | ||
| void SetFirst_Order_Init(bool val_update) { First_Order_Initialization = val_update; } |
There was a problem hiding this comment.
Add similar documentation
| /*! | ||
| * \brief Perform a first order simulation as an initial solution before running MUSCL reconstructed flow. | ||
| */ | ||
| void FirstOrderInit(); |
There was a problem hiding this comment.
Can this be expanded to multizone?
There was a problem hiding this comment.
Hi Josh, I'm planning on refactoring the logic to the Iteration class then call it in the Solver. Once its running I'll work on the MZ solver.
I also want to look into the idea Tom and Juan mentioned at the conference about progressively ramping up the MUSCL reconstruction which I think can be done by gradually scaling the gradient limiters over some iterations.
There was a problem hiding this comment.
Sounds good.
For the gradual ramping we have a ramp feature in the turbomachinery world you may find useful for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
A first order simulation is commonly used as an initial solution when performing a second order (MUSCL) reconstructed simulation. This PR aims to automate this process rather than having to do it manually, saving some time.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.