✅(frontend) enhance tests

- Removed 'feature/doc-dnd' branch from the Docker Hub workflow to
streamline deployment processes.
- Updated document creation tests to replace 'New page' button
references with 'New doc' for consistency.
- Enhanced test cases to improve clarity and ensure accurate
verification of document functionalities.
- Added new utility function for creating root subpages, improving test
maintainability.

Author: PanchoutNathan

.github/workflows/docker-hub.yml

@@ -6,7 +6,6 @@ on:
   push:
     branches:
       - 'main'
-      - 'feature/doc-dnd'
     tags:
       - 'v*'
   pull_request:

env.d/development/common.e2e.dist

@@ -2,4 +2,8 @@
 BURST_THROTTLE_RATES="200/minute"
 COLLABORATION_API_URL=http://y-provider:4444/collaboration/api/
 SUSTAINED_THROTTLE_RATES="200/hour"
-Y_PROVIDER_API_BASE_URL=http://y-provider:4444/api/
+Y_PROVIDER_API_BASE_URL=http://y-provider:4444/api/
+THEME_CUSTOMIZATION_FILE_PATH="" #force theme_customization to be empty
+#COLLABORATION_API_URL=http://y-provider:4444/collaboration/api/
+#Y_PROVIDER_API_BASE_URL=http://y-provider:4444/api/
+

src/frontend/apps/e2e/__tests__/app-impress/common.ts

@@ -90,7 +90,7 @@ export const createDoc = async (
 
     await page
       .getByRole('button', {
-        name: isChild ? 'New page' : 'New doc',
+        name: 'New doc',
       })
       .click();
 
@@ -220,6 +220,7 @@ export const updateDocTitle = async (page: Page, title: string) => {
   await input.click();
   await input.fill(title);
   await input.click();
+  await input.blur();
   await verifyDocName(page, title);
 };
 
@@ -302,48 +303,64 @@ export const mockedListDocs = async (page: Page, data: object[] = []) => {
 };
 
 export const mockedInvitations = async (page: Page, json?: object) => {
+  let result = [
+    {
+      id: '120ec765-43af-4602-83eb-7f4e1224548a',
+      abilities: {
+        destroy: true,
+        update: true,
+        partial_update: true,
+        retrieve: true,
+      },
+      created_at: '2024-10-03T12:19:26.107687Z',
+      email: '[email protected]',
+      document: '4888c328-8406-4412-9b0b-c0ba5b9e5fb6',
+      role: 'editor',
+      issuer: '7380f42f-02eb-4ad5-b8f0-037a0e66066d',
+      is_expired: false,
+      ...json,
+    },
+  ];
   await page.route('**/invitations/**/', async (route) => {
     const request = route.request();
     if (
       request.method().includes('GET') &&
       request.url().includes('invitations') &&
       request.url().includes('page=')
     ) {
+      console.log('GET');
       await route.fulfill({
         json: {
           count: 1,
           next: null,
           previous: null,
-          results: [
-            {
-              id: '120ec765-43af-4602-83eb-7f4e1224548a',
-              abilities: {
-                destroy: true,
-                update: true,
-                partial_update: true,
-                retrieve: true,
-              },
-              created_at: '2024-10-03T12:19:26.107687Z',
-              email: '[email protected]',
-              document: '4888c328-8406-4412-9b0b-c0ba5b9e5fb6',
-              role: 'editor',
-              issuer: '7380f42f-02eb-4ad5-b8f0-037a0e66066d',
-              is_expired: false,
-              ...json,
-            },
-          ],
+          results: result,
         },
       });
     } else {
       await route.continue();
     }
   });
+
+  await page.route(
+    '**/invitations/120ec765-43af-4602-83eb-7f4e1224548a/**/',
+    async (route) => {
+      const request = route.request();
+      if (request.method().includes('DELETE')) {
+        result = [];
+
+        await route.fulfill({
+          json: {},
+        });
+      }
+    },
+  );
 };
 
 export const mockedAccesses = async (page: Page, json?: object) => {
   await page.route('**/accesses/**/', async (route) => {
     const request = route.request();
-    console.log('oui');
+
     if (
       request.method().includes('GET') &&
       request.url().includes('accesses')

src/frontend/apps/e2e/__tests__/app-impress/doc-export.spec.ts

@@ -72,6 +72,7 @@ test.describe('Doc Export', () => {
     await page
       .getByRole('button', {
         name: 'download',
+        exact: true,
       })
       .click();
 
@@ -82,6 +83,7 @@ test.describe('Doc Export', () => {
     void page
       .getByRole('button', {
         name: 'Download',
+        exact: true,
       })
       .click();
 
@@ -120,6 +122,7 @@ test.describe('Doc Export', () => {
     await page
       .getByRole('button', {
         name: 'download',
+        exact: true,
       })
       .click();
 
@@ -129,6 +132,7 @@ test.describe('Doc Export', () => {
     await expect(
       page.getByRole('button', {
         name: 'Download',
+        exact: true,
       }),
     ).toBeVisible();
 
@@ -139,6 +143,7 @@ test.describe('Doc Export', () => {
     void page
       .getByRole('button', {
         name: 'Download',
+        exact: true,
       })
       .click();
 
@@ -312,12 +317,14 @@ test.describe('Doc Export', () => {
     await page
       .getByRole('button', {
         name: 'download',
+        exact: true,
       })
       .click();
 
     await expect(
       page.getByRole('button', {
         name: 'Download',
+        exact: true,
       }),
     ).toBeVisible();
 
@@ -328,6 +335,7 @@ test.describe('Doc Export', () => {
     void page
       .getByRole('button', {
         name: 'Download',
+        exact: true,
       })
       .click();
 

src/frontend/apps/e2e/__tests__/app-impress/doc-grid.spec.ts

@@ -226,6 +226,8 @@ test.describe('Documents filters', () => {
 
     await allDocs.click();
 
+    await page.waitForURL('**/?target=all_docs');
+
     let url = new URL(page.url());
     let target = url.searchParams.get('target');
     expect(target).toBe('all_docs');

src/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.ts

@@ -98,7 +98,7 @@ test.describe('Doc Header', () => {
 
     await expect(
       page.getByText(
-        `Are you sure you want to delete the document "${randomDoc}"?`,
+        `This document will be permanently deleted. This action is irreversible.`,
       ),
     ).toBeVisible();
 
@@ -161,32 +161,31 @@ test.describe('Doc Header', () => {
     await expect(shareModal).toBeVisible();
     await expect(page.getByText('Share the document')).toBeVisible();
 
-    // await expect(page.getByPlaceholder('Type a name or email')).toBeVisible();
-
     const invitationCard = shareModal.getByLabel('List invitation card');
     await expect(invitationCard).toBeVisible();
     await expect(
       invitationCard.getByText('[email protected]').first(),
     ).toBeVisible();
-    await expect(invitationCard.getByLabel('doc-role-dropdown')).toBeVisible();
+    const invitationRole = invitationCard.getByLabel('doc-role-dropdown');
+    await expect(invitationRole).toBeVisible();
 
-    await invitationCard.getByRole('button', { name: 'more_horiz' }).click();
+    await invitationRole.click();
 
-    await expect(page.getByLabel('Delete')).toBeEnabled();
-    await invitationCard.click();
+    await page.getByRole('menuitem', { name: 'Remove access' }).click();
+    await expect(invitationCard).toBeHidden();
 
     const memberCard = shareModal.getByLabel('List members card');
+    const roles = memberCard.getByLabel('doc-role-dropdown');
     await expect(memberCard).toBeVisible();
     await expect(
       memberCard.getByText('[email protected]').first(),
     ).toBeVisible();
-    await expect(memberCard.getByLabel('doc-role-dropdown')).toBeVisible();
-    await expect(
-      memberCard.getByRole('button', { name: 'more_horiz' }),
-    ).toBeVisible();
-    await memberCard.getByRole('button', { name: 'more_horiz' }).click();
+    await expect(roles).toBeVisible();
 
-    await expect(page.getByLabel('Delete')).toBeEnabled();
+    await roles.click();
+    await expect(
+      page.getByRole('menuitem', { name: 'Remove access' }),
+    ).toBeEnabled();
   });
 
   test('it checks the options available if editor', async ({ page }) => {