Skip to content

Commit c1867c9

Browse files
bmcgavinAntoLC
authored andcommitted
🐛(helm) charts generate invalid YAML for collaboration API / WS
Closes #890 Remove the service blocks outside the conditionals in the collaboration API and WS templates. Signed-off-by: Richard Jones <[email protected]>
1 parent ac0c16a commit c1867c9

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ and this project adheres to
1212

1313
- ⚡️(docker) Optimize Dockerfile to use apk with --no-cache #743
1414

15+
## Fixed
16+
17+
- 🐛(helm) charts generate invalid YAML for collaboration API / WS #890
18+
1519
## [3.4.1] - 2025-07-15
1620

1721
### Fixed
@@ -134,7 +138,6 @@ and this project adheres to
134138
- 🐛(backend) race condition create doc #633
135139
- 🐛(frontend) fix breaklines in custom blocks #908
136140

137-
138141
## [3.1.0] - 2025-04-07
139142

140143
## Added

src/helm/impress/templates/ingress_collaboration_api.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ spec:
5151
pathType: ImplementationSpecific
5252
{{- end }}
5353
backend:
54-
service:
55-
name: {{ include "impress.yProvider.fullname" . }}
56-
port:
57-
number: {{ .Values.yProvider.service.port }}
5854
{{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
5955
service:
6056
name: {{ include "impress.yProvider.fullname" . }}

src/helm/impress/templates/ingress_collaboration_ws.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ spec:
5151
pathType: ImplementationSpecific
5252
{{- end }}
5353
backend:
54-
service:
55-
name: {{ include "impress.yProvider.fullname" . }}
56-
port:
57-
number: {{ .Values.yProvider.service.port }}
5854
{{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
5955
service:
6056
name: {{ include "impress.yProvider.fullname" . }}

0 commit comments

Comments
 (0)