Skip to content

Commit d31db98

Browse files
committed
🚚(frontend) move useUpdateDocLink to doc-share feature
Move the `useUpdateDocLink` hook from the `doc-management` feature to the `doc-share` feature to better align with its functionality related to document sharing.
1 parent 9766202 commit d31db98

File tree

5 files changed

+7
-19
lines changed

5 files changed

+7
-19
lines changed

src/frontend/apps/impress/src/features/docs/doc-management/api/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,3 @@ export * from './useDuplicateDoc';
99
export * from './useRestoreDoc';
1010
export * from './useSubDocs';
1111
export * from './useUpdateDoc';
12-
export * from './useUpdateDocLink';
Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,7 @@ import { useMutation, useQueryClient } from '@tanstack/react-query';
33
import { useTranslation } from 'react-i18next';
44

55
import { APIError, errorCauses, fetchAPI } from '@/api';
6-
import { useBroadcastStore } from '@/stores';
7-
8-
import { Doc } from '../types';
9-
10-
import { KEY_DOC } from './useDoc';
6+
import { Doc } from '@/docs/doc-management';
117

128
export type UpdateDocLinkParams = Pick<Doc, 'id' | 'link_reach'> &
139
Partial<Pick<Doc, 'link_role'>>;
@@ -43,22 +39,18 @@ export function useUpdateDocLink({
4339
listInvalideQueries,
4440
}: UpdateDocLinkProps = {}) {
4541
const queryClient = useQueryClient();
46-
const { broadcast } = useBroadcastStore();
4742
const { toast } = useToastProvider();
4843
const { t } = useTranslation();
4944

5045
return useMutation<Doc, APIError, UpdateDocLinkParams>({
5146
mutationFn: updateDocLink,
52-
onSuccess: (data, variable) => {
47+
onSuccess: (data) => {
5348
listInvalideQueries?.forEach((queryKey) => {
5449
void queryClient.invalidateQueries({
5550
queryKey: [queryKey],
5651
});
5752
});
5853

59-
// Broadcast to every user connected to the document
60-
broadcast(`${KEY_DOC}-${variable.id}`);
61-
6254
toast(
6355
t('The document visibility has been updated.'),
6456
VariantType.SUCCESS,

src/frontend/apps/impress/src/features/docs/doc-share/components/DocDesynchronized.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,9 @@ import { css } from 'styled-components';
44

55
import { Box, Text } from '@/components';
66
import { useCunninghamTheme } from '@/cunningham';
7-
import {
8-
Doc,
9-
KEY_DOC,
10-
KEY_LIST_DOC,
11-
useUpdateDocLink,
12-
} from '@/docs/doc-management';
7+
import { Doc, KEY_DOC, KEY_LIST_DOC } from '@/docs/doc-management';
8+
9+
import { useUpdateDocLink } from '../api/useUpdateDocLink';
1310

1411
import Desync from './../assets/desynchro.svg';
1512
import Undo from './../assets/undo.svg';

src/frontend/apps/impress/src/features/docs/doc-share/components/DocShareMember.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ export const QuickSearchGroupMember = ({
112112
elements: members,
113113
endActions: undefined,
114114
};
115-
}, [membersQuery, t]);
115+
}, [membersQuery.data, t]);
116116

117117
return (
118118
<Box aria-label={t('List members card')} $padding={{ bottom: '3xs' }}>

src/frontend/apps/impress/src/features/docs/doc-share/components/DocVisibility.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ import {
1919
getDocLinkReach,
2020
getDocLinkRole,
2121
useDocUtils,
22-
useUpdateDocLink,
2322
} from '@/docs/doc-management';
2423
import { useResponsiveStore } from '@/stores';
2524

25+
import { useUpdateDocLink } from '../api/useUpdateDocLink';
2626
import { useTranslatedShareSettings } from '../hooks/';
2727

2828
import { DocDesynchronized } from './DocDesynchronized';

0 commit comments

Comments
 (0)