✨(api) add labels info on Thread

Add details of labels info on thread list

Author: sdemagny

src/backend/core/api/serializers.py

@@ -1,6 +1,6 @@
 """Client serializers for the messages core app."""
 
-from django.db.models import Count, Q
+from django.db.models import Count, Q, Exists, OuterRef
 
 from drf_spectacular.utils import extend_schema_field
 from rest_framework import serializers
@@ -141,6 +141,7 @@ class ThreadSerializer(serializers.ModelSerializer):
     sender_names = serializers.ListField(child=serializers.CharField(), read_only=True)
     user_role = serializers.SerializerMethodField()
     accesses = serializers.SerializerMethodField()
+    labels = serializers.SerializerMethodField()
 
     @extend_schema_field(ThreadAccessDetailSerializer(many=True))
     def get_accesses(self, instance):
@@ -170,6 +171,22 @@ def get_user_role(self, instance):
                     return None
         return None
 
+    def get_labels(self, instance):
+        """Get labels for the thread, filtered by user's mailbox access."""
+        request = self.context.get("request")
+        if not request or not hasattr(request, "user"):
+            return []
+        
+        labels = instance.labels.filter(
+            Exists(
+                models.MailboxAccess.objects.filter(
+                    mailbox=OuterRef("mailbox"),
+                    user=request.user,
+                )
+            )
+        ).distinct()
+        return LabelSerializer(labels, many=True).data
+
     class Meta:
         model = models.Thread
         fields = [
@@ -188,6 +205,7 @@ class Meta:
             "updated_at",
             "user_role",
             "accesses",
+            "labels",
         ]
         read_only_fields = fields  # Mark all as read-only for safety
 

src/backend/core/api/viewsets/thread.py

@@ -19,7 +19,10 @@
 
 
 class ThreadViewSet(
-    viewsets.GenericViewSet, mixins.ListModelMixin, mixins.DestroyModelMixin
+    viewsets.GenericViewSet,
+    mixins.ListModelMixin,
+    mixins.RetrieveModelMixin,
+    mixins.DestroyModelMixin,
 ):
     """ViewSet for Thread model."""
 

src/backend/core/tests/api/test_thread_labels.py

@@ -0,0 +1,148 @@
+"""Tests for label functionality in thread responses."""
+
+import pytest
+from django.urls import reverse
+from rest_framework import status
+
+from core import enums, factories, models
+
+pytestmark = pytest.mark.django_db
+
+
+@pytest.fixture
+def user():
+    """Create a test user."""
+    return factories.UserFactory()
+
+
+@pytest.fixture
+def mailbox(user):
+    """Create a mailbox with user access."""
+    mailbox = factories.MailboxFactory()
+    factories.MailboxAccessFactory(
+        mailbox=mailbox,
+        user=user,
+        role=enums.MailboxRoleChoices.EDITOR,
+    )
+    return mailbox
+
+
+@pytest.fixture
+def thread(mailbox):
+    """Create a thread with mailbox access and a message."""
+    thread = factories.ThreadFactory()
+    factories.ThreadAccessFactory(
+        mailbox=mailbox,
+        thread=thread,
+        role=enums.ThreadAccessRoleChoices.EDITOR,
+    )
+    # Add a message to the thread
+    factories.MessageFactory(thread=thread)
+    thread.update_stats()
+    return thread
+
+
+@pytest.fixture
+def label(mailbox):
+    """Create a label in the mailbox."""
+    return factories.LabelFactory(mailbox=mailbox)
+
+
+def test_thread_includes_labels(api_client, user, thread, label):
+    """Test that thread responses include labels."""
+    # Add the label to the thread
+    thread.labels.add(label)
+    
+    api_client.force_authenticate(user=user)
+    response = api_client.get(reverse("threads-list"))
+    
+    assert response.status_code == status.HTTP_200_OK
+    assert response.data["count"] == 1  # We should have exactly one thread
+    thread_data = response.data["results"][0]  # Get the first (and only) thread
+    assert "labels" in thread_data
+    assert len(thread_data["labels"]) == 1
+    label_data = thread_data["labels"][0]
+    assert label_data["id"] == str(label.id)
+    assert label_data["name"] == label.name
+    assert label_data["slug"] == label.slug
+    assert label_data["color"] == label.color
+    assert label_data["mailbox"] == label.mailbox.id
+
+
+def test_thread_labels_filtered_by_access(api_client, user, thread, mailbox):
+    """Test that thread responses only include labels from mailboxes the user has access to."""
+    # Create a label in a mailbox the user has access to
+    accessible_label = factories.LabelFactory(mailbox=mailbox)
+    
+    # Create a label in a mailbox the user doesn't have access to
+    other_mailbox = factories.MailboxFactory()
+    inaccessible_label = factories.LabelFactory(mailbox=other_mailbox)
+    
+    # Add both labels to the thread
+    thread.labels.add(accessible_label, inaccessible_label)
+    
+    api_client.force_authenticate(user=user)
+    response = api_client.get(reverse("threads-list"))
+    
+    assert response.status_code == status.HTTP_200_OK
+    assert response.data["count"] == 1  # We should have exactly one thread
+    thread_data = response.data["results"][0]  # Get the first (and only) thread
+    assert "labels" in thread_data
+    assert len(thread_data["labels"]) == 1
+    assert thread_data["labels"][0]["id"] == str(accessible_label.id)
+
+
+def test_thread_labels_empty_when_no_labels(api_client, user, thread):
+    """Test that thread responses include an empty labels list when the thread has no labels."""
+    api_client.force_authenticate(user=user)
+    response = api_client.get(reverse("threads-list"))
+    
+    assert response.status_code == status.HTTP_200_OK
+    assert response.data["count"] == 1  # We should have exactly one thread
+    thread_data = response.data["results"][0]  # Get the first (and only) thread
+    assert "labels" in thread_data
+    assert thread_data["labels"] == []
+
+
+def test_thread_labels_updated_after_label_changes(api_client, user, thread, label):
+    """Test that thread responses reflect label changes."""
+    # Add the label to the thread
+    thread.labels.add(label)
+    
+    api_client.force_authenticate(user=user)
+    
+    # Check initial state
+    response = api_client.get(reverse("threads-list"))
+    assert response.status_code == status.HTTP_200_OK
+    assert response.data["count"] == 1  # We should have exactly one thread
+    thread_data = response.data["results"][0]  # Get the first (and only) thread
+    assert len(thread_data["labels"]) == 1
+    
+    # Remove the label
+    thread.labels.remove(label)
+    
+    # Check updated state
+    response = api_client.get(reverse("threads-list"))
+    assert response.status_code == status.HTTP_200_OK
+    assert response.data["count"] == 1  # We should have exactly one thread
+    thread_data = response.data["results"][0]  # Get the first (and only) thread
+    assert thread_data["labels"] == []
+
+
+def test_thread_labels_in_detail_view(api_client, user, thread, label):
+    """Test that labels are included in thread detail view."""
+    # Add the label to the thread
+    thread.labels.add(label)
+    
+    api_client.force_authenticate(user=user)
+    response = api_client.get(reverse("threads-detail", args=[thread.id]))
+    
+    assert response.status_code == status.HTTP_200_OK
+    assert "labels" in response.data
+    assert len(response.data["labels"]) == 1
+    label_data = response.data["labels"][0]
+    assert label_data["id"] == str(label.id)
+    assert label_data["name"] == label.name
+    assert label_data["slug"] == label.slug
+    assert label_data["color"] == label.color
+    assert label_data["mailbox"] == label.mailbox.id