Skip to content

Conversation

@johnstonmatt
Copy link
Contributor

@johnstonmatt johnstonmatt commented Oct 29, 2025

What kind of change does this PR introduce?

Feature DEVWF-756

What is the current behavior?

  • supabase functions download foo spins up an edge-runtime container to download the eszip bundle and writes it to the filesystem

What is the new behavior?

  • supabase functions download foo --use-api calls the mgmt-api to unbundle the eszip on the server, then returns it as a multipart response and writes it to the filesystem

Parity

We expect that whether you choose to --use-api or not you should end up with the same files on disk.

Additional context

Add any other context or screenshots.

@johnstonmatt johnstonmatt requested a review from a team as a code owner October 29, 2025 08:46
@coveralls
Copy link

coveralls commented Oct 29, 2025

Pull Request Test Coverage Report for Build 19331858962

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 94 of 139 (67.63%) changed or added relevant lines in 2 files are covered.
  • 156 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.4%) to 55.051%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/functions.go 0 13 0.0%
internal/functions/download/download.go 94 126 74.6%
Files with Coverage Reduction New Missed Lines %
internal/bans/get/get.go 1 0.0%
internal/storage/rm/rm.go 2 80.61%
internal/utils/api.go 2 87.63%
internal/branches/get/get.go 3 0.0%
internal/gen/keys/keys.go 5 12.9%
internal/functions/deploy/bundle.go 8 85.32%
internal/utils/connect.go 15 89.04%
internal/projects/create/create.go 18 43.0%
internal/link/link.go 22 73.8%
internal/bootstrap/bootstrap.go 24 28.85%
Totals Coverage Status
Change from base Build 19220886525: 0.4%
Covered Lines: 6507
Relevant Lines: 11820

💛 - Coveralls

@johnstonmatt johnstonmatt disabled auto-merge October 31, 2025 09:20
@johnstonmatt johnstonmatt force-pushed the DEVWF-756/server-side-unbundle branch 2 times, most recently from 3444cce to fb7041d Compare November 3, 2025 18:04
@johnstonmatt johnstonmatt force-pushed the DEVWF-756/server-side-unbundle branch from fb7041d to 3eedb2c Compare November 3, 2025 18:07
@johnstonmatt johnstonmatt enabled auto-merge (squash) November 10, 2025 15:45
@sweatybridge sweatybridge merged commit cbbe7ec into develop Nov 13, 2025
20 checks passed
@sweatybridge sweatybridge deleted the DEVWF-756/server-side-unbundle branch November 13, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants