Skip to content

Commit 143d17f

Browse files
JackDraRich-Harris
andauthored
FIX: Separate playwrite templates for js vs ts (#4479)
* FIX: Separate playwrite templates for js vs ts Playwrite file when building with typescript requires the playwrite.config file to have extension .ts * package.json shoudnt be duplicated * install @playwright/test as dev dep to remove the red squigglies * make the .ts file actually use typescript * oops, typo * bump version * fix merging * use next version of @playwright/test for TS users Co-authored-by: Rich Harris <[email protected]>
1 parent aa2e2c4 commit 143d17f

File tree

6 files changed

+113
-29
lines changed

6 files changed

+113
-29
lines changed

packages/create-svelte/index.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,11 @@ function merge(target, source) {
105105
throw new Error('Mismatched values');
106106
}
107107

108-
merge(target_value, source_value);
108+
if (typeof source_value === 'object') {
109+
merge(target_value, source_value);
110+
} else {
111+
target[key] = source_value;
112+
}
109113
} else {
110114
target[key] = source[key];
111115
}

packages/create-svelte/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
"prompts": "^2.4.2"
1616
},
1717
"devDependencies": {
18+
"@playwright/test": "^1.20.1",
1819
"@sveltejs/kit": "workspace:*",
1920
"@types/gitignore-parser": "^0.0.0",
2021
"@types/prettier": "^2.4.2",
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"devDependencies": {
3+
"@playwright/test": "next"
4+
}
5+
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
import type { PlaywrightTestConfig } from '@playwright/test';
2+
3+
const config: PlaywrightTestConfig = {
4+
webServer: {
5+
command: 'npm run build && npm run preview',
6+
port: 3000
7+
}
8+
};
9+
10+
export default config;
File renamed without changes.

pnpm-lock.yaml

Lines changed: 92 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)