Return both breif & full doc in codeCompleteDocumentation request

Author: a7medev

Sources/SwiftSourceKitPlugin/CompletionProvider.swift

@@ -264,17 +264,11 @@ actor CompletionProvider {
   func handleCompletionDocumentation(_ request: SKDRequestDictionaryReader) throws -> SKDResponseDictionaryBuilder {
     let info = try handleExtendedCompletionRequest(request)
 
-    let response = request.sourcekitd.responseDictionary([
-      request.sourcekitd.keys.associatedUSRs: info.associatedUSRs as [SKDResponseValue]?
+    return request.sourcekitd.responseDictionary([
+      request.sourcekitd.keys.docBrief: info.briefDocumentation,
+      request.sourcekitd.keys.docFullAsXML: info.fullDocumentation,
+      request.sourcekitd.keys.associatedUSRs: info.associatedUSRs as [SKDResponseValue]?,
     ])
-
-    if let fullDocumentation = info.fullDocumentation {
-      response.set(request.sourcekitd.keys.docFullAsXML, to: fullDocumentation)
-    } else {
-      response.set(request.sourcekitd.keys.docBrief, to: info.briefDocumentation)
-    }
-
-    return response
   }
 
   func handleCompletionDiagnostic(_ dict: SKDRequestDictionaryReader) throws -> SKDResponseDictionaryBuilder {

Tests/SwiftSourceKitPluginTests/SwiftSourceKitPluginTests.swift

@@ -457,6 +457,7 @@ final class SwiftSourceKitPluginTests: XCTestCase {
       </Function>
       """
     )
+    XCTAssertEqual(sym1Doc.docBrief, "Protocol P foo1")
     XCTAssertEqual(sym1Doc.associatedUSRs, ["s:1a1SV4foo1yyF", "s:1a1PP4foo1yyF"])
 
     let sym2Doc = try await sourcekitd.completeDocumentation(id: sym2.id)
@@ -473,10 +474,12 @@ final class SwiftSourceKitPluginTests: XCTestCase {
       </Function>
       """
     )
+    XCTAssertEqual(sym2Doc.docBrief, "Struct S foo2")
     XCTAssertEqual(sym2Doc.associatedUSRs, ["s:1a1SV4foo2yyF"])
 
     let sym3Doc = try await sourcekitd.completeDocumentation(id: sym3.id)
     XCTAssertNil(sym3Doc.docFullAsXML)
+    XCTAssertNil(sym3Doc.docBrief)
     XCTAssertEqual(sym3Doc.associatedUSRs, ["s:1a1SV4foo3yyF"])
   }