Rename build system to build server in most cases #2201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
build-server-rename
branch
from
2320a9b to
38bbd8d
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
reviewed
Jul 14, 2025
Comment on lines
+22
to
+23
| /// The details necessary to create a `BuildServerAdapter`. | ||
| package struct BuildServerSpec { |
There was a problem hiding this comment.
This one is a little weird given buildServer is one of the options 😅
There was a problem hiding this comment.
Good catch. I’ll rename the buildServer case to externalBuildServer.
|
|
||
| /// A type that outwardly acts as a BSP build server and internally uses a `BuiltInBuildSystem` to satisfy the requests. | ||
| actor BuiltInBuildSystemAdapter: QueueBasedMessageHandler { | ||
| /// A type that outwardly acts as a BSP build server and internally uses a `BuiltInBuildServer` to satisfy the requests. |
There was a problem hiding this comment.
It seems like BuiltInBuildServer really is still BuiltInBuildSystem right?
There was a problem hiding this comment.
No, I think BuiltInBuildServer makes sense because it’s essentially a BSP server that is built into SourceKit-LSP.
ahoppen
force-pushed
the
build-server-rename
branch
from
38bbd8d to
901804f
Compare
ahoppen
force-pushed
the
build-server-rename
branch
from
901804f to
87361af
Compare
|
@swift-ci Please test |
The term *build system* predated our wide-spread adoption of BSP for communicating between SourceKit-LSP to the build system and was never really the correct term anyway – ie. a `JSONCompilationDatabaseBuildSystem` never really sounded right. We now have a correct term for the communication layer between SourceKit-LSP: A build server. Rename most occurrences of *build system* to *build server* to reflect this. There are unfortunately a couple lingering instances of *build system* that we can’t change, most notably: `fallbackBuildSystem` in the config file, the `workspace/waitForBuildSystemUpdates` BSP extension request and the `synchronize-for-build-system-updates` experimental feature.
ahoppen
force-pushed
the
build-server-rename
branch
from
87361af to
7f4f92e
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term build system predated our wide-spread adoption of BSP for communicating between SourceKit-LSP to the build system and was never really the correct term anyway – ie. a
JSONCompilationDatabaseBuildSystemnever really sounded right. We now have a correct term for the communication layer between SourceKit-LSP: A build server. Rename most occurrences of build system to build server to reflect this. There are unfortunately a couple lingering instances of build system that we can’t change, most notably:fallbackBuildSystemin the config file, theworkspace/waitForBuildSystemUpdatesBSP extension request and thesynchronize-for-build-system-updatesexperimental feature.