Fix bugs on Windows

Author: stevapple

Sources/TSCBasic/Process.swift

@@ -326,19 +326,19 @@ public final class Process: ObjectIdentifierProtocol {
                 currentWorkingDirectory: localFileSystem.currentWorkingDirectory
             )
 #if os(Windows)
-            var searchPaths = [String]()
-            let buffer = UnsafeMutablePointer<String>.allocate(capacity: 260)
+            var searchPaths = Array<AbsolutePath>()
+            var buffer = Array<WCHAR>(repeating: 0, count: Int(MAX_PATH + 1))
 
             // The 32-bit Windows system directory
-            GetSystemDirectoryW(buffer, 260)
-            searchPaths += buffer.pointee
+            GetSystemDirectoryW(&buffer, .init(MAX_PATH + 1))
+            searchPaths.append(AbsolutePath(String(decodingCString: buffer, as: UTF16.self)))
 
             // The 16-bit Windows system directory
-            searchPaths += "\(ProcessEnv.vars["systemdrive"] ?? "C:")\\System"
+            searchPaths.append(AbsolutePath("\(ProcessEnv.vars["systemdrive"] ?? "C:")\\System"))
 
             // The Windows directory
-            GetWindowsDirectoryW(buffer, 260)
-            searchPaths += buffer.pointee
+            GetWindowsDirectoryW(&buffer, .init(MAX_PATH + 1))
+            searchPaths.append(AbsolutePath(String(decodingCString: buffer, as: UTF16.self)))
 
             searchPaths.append(contentsOf: envSearchPaths)
 #else

Sources/TSCBasic/misc.swift

@@ -92,7 +92,7 @@ public func lookupExecutablePath(
         return nil
     }
     let isPath = value.contains("\\")
-    if !isPath && value.contains(".") {
+    if !isPath && !value.contains(".") {
         value.append(executableFileSuffix)
     }
 #else

Tests/TSCBasicTests/TemporaryFileTests.swift

@@ -137,6 +137,7 @@ class TemporaryFileTests: XCTestCase {
         XCTAssertFalse(localFileSystem.isDirectory(pathTwo))
     }
 
+  #if !os(Windows) // `fileDescriptor` is currently unavailable in Windows
     /// Check that the temporary file doesn't leak file descriptors.
     func testLeaks() throws {
         // We check this by testing that we get back the same FD after a
@@ -150,4 +151,5 @@ class TemporaryFileTests: XCTestCase {
         let endFD = try Int(withTemporaryFile { return $0.fileHandle.fileDescriptor })
         XCTAssertEqual(initialFD, endFD)
     }
+  #endif
 }