Skip to content

Commit 74df691

Browse files
Merge branch '7.4' into 8.0
* 7.4: [ObjectMapper] do not require mapping a target's required promoted property when not on source (#2) run tests with PHPUnit 12.3 [GitHub] Update .github/PULL_REQUEST_TEMPLATE.md to remove SF 7.2 as it's not supported anymore [CI] fixed the Intl data tests actions Tests fails due to unknown option -v which is shorthand of the --verbose as per the phpunit its removed without any replacement sebastianbergmann/phpunit#5647 (comment) [Mailer] Fix expected exception message to include quotes around "http(s)://" [WebProfilerBundle] Fix toolbar not rendering after replacing it [Validator] (60455) Validate translations for Arabic (ar) (60474) Remove translation state attribute for Twig template validator in Ukrainian translation [VarDumper] Fix dumping objects from the DOM extension [Mailer] Add MicrosoftGraph API Transport [Yaml] Fix code style [Tests] Adapt testAddHtmlContentWithErrors to be HTML5 compliant Add friendly name in the `to` field [ObjectMapper] read source metadata before transform [HtmlSanitizer] Fix force_attributes not replacing existing attribute in initial data
2 parents 42279fe + 66138b7 commit 74df691

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Tests/PropertyAccessorArrayAccessTestCase.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,27 +64,27 @@ public function testGetValueFailsIfNoSuchIndex()
6464
}
6565

6666
#[DataProvider('getValidPropertyPaths')]
67-
public function testSetValue($collection, $path)
67+
public function testSetValue($collection, $path, $value)
6868
{
6969
$this->propertyAccessor->setValue($collection, $path, 'Updated');
7070

7171
$this->assertSame('Updated', $this->propertyAccessor->getValue($collection, $path));
7272
}
7373

7474
#[DataProvider('getValidPropertyPaths')]
75-
public function testIsReadable($collection, $path)
75+
public function testIsReadable($collection, $path, $value)
7676
{
7777
$this->assertTrue($this->propertyAccessor->isReadable($collection, $path));
7878
}
7979

8080
#[DataProvider('getValidPropertyPaths')]
81-
public function testIsWritable($collection, $path)
81+
public function testIsWritable($collection, $path, $value)
8282
{
8383
$this->assertTrue($this->propertyAccessor->isWritable($collection, $path));
8484
}
8585

8686
#[DataProvider('getInvalidPropertyPaths')]
87-
public function testIsNotWritable($collection, $path)
87+
public function testIsNotWritable($collection, $path, $value)
8888
{
8989
$this->assertFalse($this->propertyAccessor->isWritable($collection, $path));
9090
}

Tests/PropertyAccessorTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ public function testGetValueReadsMagicCallThatReturnsConstant()
306306
}
307307

308308
#[DataProvider('getValidWritePropertyPaths')]
309-
public function testSetValue(array|object $objectOrArray, string $path)
309+
public function testSetValue(array|object $objectOrArray, string $path, ?string $value)
310310
{
311311
$this->propertyAccessor->setValue($objectOrArray, $path, 'Updated');
312312

@@ -402,7 +402,7 @@ public function testGetValueWhenArrayValueIsNull()
402402
}
403403

404404
#[DataProvider('getValidReadPropertyPaths')]
405-
public function testIsReadable(array|object $objectOrArray, string $path)
405+
public function testIsReadable(array|object $objectOrArray, string $path, ?string $value)
406406
{
407407
$this->assertTrue($this->propertyAccessor->isReadable($objectOrArray, $path));
408408
}
@@ -447,7 +447,7 @@ public function testIsReadableRecognizesMagicCallIfEnabled()
447447
}
448448

449449
#[DataProvider('getValidWritePropertyPaths')]
450-
public function testIsWritable(array|object $objectOrArray, string $path)
450+
public function testIsWritable(array|object $objectOrArray, string $path, ?string $value)
451451
{
452452
$this->assertTrue($this->propertyAccessor->isWritable($objectOrArray, $path));
453453
}

0 commit comments

Comments
 (0)