Enable "native_constant_invocation" CS rule

nicolas-grekas · nicolas-grekas · commit e86b53d99b40 · 2020-09-02T18:06:40.000+02:00
diff --git a/Core/Authentication/Token/AbstractToken.php b/Core/Authentication/Token/AbstractToken.php
@@ -233,7 +233,7 @@ public function __toString()
     protected function doSerialize($serialized, $isCalledFromOverridingMethod)
     {
         if (null === $isCalledFromOverridingMethod) {
-            $trace = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 3);
+            $trace = debug_backtrace(\DEBUG_BACKTRACE_PROVIDE_OBJECT, 3);
             $isCalledFromOverridingMethod = isset($trace[2]['function'], $trace[2]['object']) && 'serialize' === $trace[2]['function'] && $this === $trace[2]['object'];
         }
 
diff --git a/Core/Authorization/AccessDecisionManager.php b/Core/Authorization/AccessDecisionManager.php
@@ -62,7 +62,7 @@ public function __construct($voters = [], $strategy = self::STRATEGY_AFFIRMATIVE
      */
     public function setVoters(array $voters)
     {
-        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 3.3 and will be removed in 4.0. Pass the voters to the constructor instead.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 3.3 and will be removed in 4.0. Pass the voters to the constructor instead.', __METHOD__), \E_USER_DEPRECATED);
 
         $this->voters = $voters;
     }
@@ -191,7 +191,7 @@ private function vote($voter, TokenInterface $token, $subject, $attributes)
         }
 
         if (method_exists($voter, 'vote')) {
-            @trigger_error(sprintf('Calling vote() on an voter without %1$s is deprecated as of 3.4 and will be removed in 4.0. Implement the %1$s on your voter.', VoterInterface::class), E_USER_DEPRECATED);
+            @trigger_error(sprintf('Calling vote() on an voter without %1$s is deprecated as of 3.4 and will be removed in 4.0. Implement the %1$s on your voter.', VoterInterface::class), \E_USER_DEPRECATED);
 
             // making the assumption that the signature matches
             return $voter->vote($token, $subject, $attributes);
diff --git a/Core/Authorization/TraceableAccessDecisionManager.php b/Core/Authorization/TraceableAccessDecisionManager.php
@@ -67,7 +67,7 @@ public function decide(TokenInterface $token, array $attributes, $object = null)
      */
     public function setVoters(array $voters)
     {
-        @trigger_error(sprintf('The %s() method is deprecated since Symfony 3.3 and will be removed in 4.0. Pass voters to the decorated AccessDecisionManager instead.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The %s() method is deprecated since Symfony 3.3 and will be removed in 4.0. Pass voters to the decorated AccessDecisionManager instead.', __METHOD__), \E_USER_DEPRECATED);
 
         if (!method_exists($this->manager, 'setVoters')) {
             return;
diff --git a/Core/Encoder/Argon2iPasswordEncoder.php b/Core/Encoder/Argon2iPasswordEncoder.php
@@ -26,7 +26,7 @@ public static function isSupported()
             return true;
         }
 
-        return version_compare(\extension_loaded('sodium') ? SODIUM_LIBRARY_VERSION : phpversion('libsodium'), '1.0.9', '>=');
+        return version_compare(\extension_loaded('sodium') ? \SODIUM_LIBRARY_VERSION : phpversion('libsodium'), '1.0.9', '>=');
     }
 
     /**
@@ -79,15 +79,15 @@ public function isPasswordValid($encoded, $raw, $salt)
 
     private function encodePasswordNative($raw)
     {
-        return password_hash($raw, PASSWORD_ARGON2I);
+        return password_hash($raw, \PASSWORD_ARGON2I);
     }
 
     private function encodePasswordSodiumFunction($raw)
     {
         $hash = sodium_crypto_pwhash_str(
             $raw,
-            SODIUM_CRYPTO_PWHASH_OPSLIMIT_INTERACTIVE,
-            SODIUM_CRYPTO_PWHASH_MEMLIMIT_INTERACTIVE
+            \SODIUM_CRYPTO_PWHASH_OPSLIMIT_INTERACTIVE,
+            \SODIUM_CRYPTO_PWHASH_MEMLIMIT_INTERACTIVE
         );
         sodium_memzero($raw);
 
diff --git a/Core/Encoder/BCryptPasswordEncoder.php b/Core/Encoder/BCryptPasswordEncoder.php
@@ -71,7 +71,7 @@ public function encodePassword($raw, $salt)
             // Ignore $salt, the auto-generated one is always the best
         }
 
-        return password_hash($raw, PASSWORD_BCRYPT, $options);
+        return password_hash($raw, \PASSWORD_BCRYPT, $options);
     }
 
     /**
diff --git a/Core/Exception/AuthenticationException.php b/Core/Exception/AuthenticationException.php
@@ -60,7 +60,7 @@ public function serialize()
     protected function doSerialize($serialized, $isCalledFromOverridingMethod)
     {
         if (null === $isCalledFromOverridingMethod) {
-            $trace = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 3);
+            $trace = debug_backtrace(\DEBUG_BACKTRACE_PROVIDE_OBJECT, 3);
             $isCalledFromOverridingMethod = isset($trace[2]['function'], $trace[2]['object']) && 'serialize' === $trace[2]['function'] && $this === $trace[2]['object'];
         }
 
diff --git a/Core/Exception/NonceExpiredException.php b/Core/Exception/NonceExpiredException.php
@@ -11,7 +11,7 @@
 
 namespace Symfony\Component\Security\Core\Exception;
 
-@trigger_error(sprintf('The %s class and the whole HTTP digest authentication system is deprecated since Symfony 3.4 and will be removed in 4.0.', NonceExpiredException::class), E_USER_DEPRECATED);
+@trigger_error(sprintf('The %s class and the whole HTTP digest authentication system is deprecated since Symfony 3.4 and will be removed in 4.0.', NonceExpiredException::class), \E_USER_DEPRECATED);
 
 /**
  * NonceExpiredException is thrown when an authentication is rejected because
diff --git a/Csrf/Tests/TokenStorage/NativeSessionTokenStorageTest.php b/Csrf/Tests/TokenStorage/NativeSessionTokenStorageTest.php
@@ -47,11 +47,11 @@ public function testStoreTokenInClosedSessionWithExistingSessionId()
     {
         session_id('foobar');
 
-        $this->assertSame(PHP_SESSION_NONE, session_status());
+        $this->assertSame(\PHP_SESSION_NONE, session_status());
 
         $this->storage->setToken('token_id', 'TOKEN');
 
-        $this->assertSame(PHP_SESSION_ACTIVE, session_status());
+        $this->assertSame(\PHP_SESSION_ACTIVE, session_status());
         $this->assertSame([self::SESSION_NAMESPACE => ['token_id' => 'TOKEN']], $_SESSION);
     }
 
diff --git a/Csrf/TokenStorage/NativeSessionTokenStorage.php b/Csrf/TokenStorage/NativeSessionTokenStorage.php
@@ -112,7 +112,7 @@ public function clear()
 
     private function startSession()
     {
-        if (PHP_SESSION_NONE === session_status()) {
+        if (\PHP_SESSION_NONE === session_status()) {
             session_start();
         }
 
diff --git a/Guard/AbstractGuardAuthenticator.php b/Guard/AbstractGuardAuthenticator.php
@@ -27,7 +27,7 @@ abstract class AbstractGuardAuthenticator implements AuthenticatorInterface
      */
     public function supports(Request $request)
     {
-        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 3.4 and will be removed in 4.0. Implement the "%s::supports()" method in class "%s" instead.', __METHOD__, AuthenticatorInterface::class, static::class), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 3.4 and will be removed in 4.0. Implement the "%s::supports()" method in class "%s" instead.', __METHOD__, AuthenticatorInterface::class, static::class), \E_USER_DEPRECATED);
 
         return true;
     }
diff --git a/Guard/Authenticator/AbstractFormLoginAuthenticator.php b/Guard/Authenticator/AbstractFormLoginAuthenticator.php
@@ -61,7 +61,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
      */
     public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey)
     {
-        @trigger_error(sprintf('The AbstractFormLoginAuthenticator::onAuthenticationSuccess() implementation was deprecated in Symfony 3.1 and will be removed in Symfony 4.0. You should implement this method yourself in %s and remove getDefaultSuccessRedirectUrl().', static::class), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The AbstractFormLoginAuthenticator::onAuthenticationSuccess() implementation was deprecated in Symfony 3.1 and will be removed in Symfony 4.0. You should implement this method yourself in %s and remove getDefaultSuccessRedirectUrl().', static::class), \E_USER_DEPRECATED);
 
         if (!method_exists($this, 'getDefaultSuccessRedirectUrl')) {
             throw new \Exception(sprintf('You must implement onAuthenticationSuccess() or getDefaultSuccessRedirectUrl() in "%s".', static::class));
diff --git a/Guard/Firewall/GuardAuthenticationListener.php b/Guard/Firewall/GuardAuthenticationListener.php
@@ -132,7 +132,7 @@ private function executeGuardAuthenticator($uniqueGuardKey, GuardAuthenticatorIn
                 }
 
                 if ($guardAuthenticator instanceof AbstractGuardAuthenticator) {
-                    @trigger_error(sprintf('Returning null from "%1$s::getCredentials()" is deprecated since Symfony 3.4 and will throw an \UnexpectedValueException in 4.0. Return false from "%1$s::supports()" instead.', \get_class($guardAuthenticator)), E_USER_DEPRECATED);
+                    @trigger_error(sprintf('Returning null from "%1$s::getCredentials()" is deprecated since Symfony 3.4 and will throw an \UnexpectedValueException in 4.0. Return false from "%1$s::supports()" instead.', \get_class($guardAuthenticator)), \E_USER_DEPRECATED);
 
                     return;
                 }
diff --git a/Http/EntryPoint/DigestAuthenticationEntryPoint.php b/Http/EntryPoint/DigestAuthenticationEntryPoint.php
@@ -33,7 +33,7 @@ class DigestAuthenticationEntryPoint implements AuthenticationEntryPointInterfac
 
     public function __construct($realmName, $secret, $nonceValiditySeconds = 300, LoggerInterface $logger = null)
     {
-        @trigger_error(sprintf('The %s class and the whole HTTP digest authentication system is deprecated since Symfony 3.4 and will be removed in 4.0.', __CLASS__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The %s class and the whole HTTP digest authentication system is deprecated since Symfony 3.4 and will be removed in 4.0.', __CLASS__), \E_USER_DEPRECATED);
 
         $this->realmName = $realmName;
         $this->secret = $secret;
diff --git a/Http/Firewall/ContextListener.php b/Http/Firewall/ContextListener.php
@@ -196,7 +196,7 @@ protected function refreshUser(TokenInterface $token)
                         continue;
                     }
 
-                    @trigger_error('Refreshing a deauthenticated user is deprecated as of 3.4 and will trigger a logout in 4.0.', E_USER_DEPRECATED);
+                    @trigger_error('Refreshing a deauthenticated user is deprecated as of 3.4 and will trigger a logout in 4.0.', \E_USER_DEPRECATED);
                 }
 
                 $token->setUser($refreshedUser);
diff --git a/Http/Firewall/DigestAuthenticationListener.php b/Http/Firewall/DigestAuthenticationListener.php
@@ -44,7 +44,7 @@ class DigestAuthenticationListener implements ListenerInterface
 
     public function __construct(TokenStorageInterface $tokenStorage, UserProviderInterface $provider, $providerKey, DigestAuthenticationEntryPoint $authenticationEntryPoint, LoggerInterface $logger = null)
     {
-        @trigger_error(sprintf('The %s class and the whole HTTP digest authentication system is deprecated since Symfony 3.4 and will be removed in 4.0.', __CLASS__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The %s class and the whole HTTP digest authentication system is deprecated since Symfony 3.4 and will be removed in 4.0.', __CLASS__), \E_USER_DEPRECATED);
 
         if (empty($providerKey)) {
             throw new \InvalidArgumentException('$providerKey must not be empty.');
@@ -175,10 +175,10 @@ class DigestData
 
     public function __construct($header)
     {
-        @trigger_error(sprintf('The %s class and the whole HTTP digest authentication system is deprecated since Symfony 3.4 and will be removed in 4.0.', __CLASS__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The %s class and the whole HTTP digest authentication system is deprecated since Symfony 3.4 and will be removed in 4.0.', __CLASS__), \E_USER_DEPRECATED);
 
         $this->header = $header;
-        preg_match_all('/(\w+)=("((?:[^"\\\\]|\\\\.)+)"|([^\s,$]+))/', $header, $matches, PREG_SET_ORDER);
+        preg_match_all('/(\w+)=("((?:[^"\\\\]|\\\\.)+)"|([^\s,$]+))/', $header, $matches, \PREG_SET_ORDER);
         foreach ($matches as $match) {
             if (isset($match[1]) && isset($match[3])) {
                 $this->elements[$match[1]] = isset($match[4]) ? $match[4] : $match[3];
diff --git a/Http/HttpUtils.php b/Http/HttpUtils.php
@@ -162,7 +162,7 @@ public function generateUri($request, $path)
         // fortunately, they all are, so we have to remove entire query string
         $position = strpos($url, '?');
         if (false !== $position) {
-            $fragment = parse_url($url, PHP_URL_FRAGMENT);
+            $fragment = parse_url($url, \PHP_URL_FRAGMENT);
             $url = substr($url, 0, $position);
             // fragment must be preserved
             if ($fragment) {
diff --git a/Http/Logout/LogoutUrlGenerator.php b/Http/Logout/LogoutUrlGenerator.php
@@ -55,7 +55,7 @@ public function registerListener($key, $logoutPath, $csrfTokenId, $csrfParameter
             if (__CLASS__ !== static::class) {
                 $r = new \ReflectionMethod($this, __FUNCTION__);
                 if (__CLASS__ !== $r->getDeclaringClass()->getName()) {
-                    @trigger_error(sprintf('The "%s()" method will have a 6th `string $context = null` argument in version 4.0. Not defining it is deprecated since Symfony 3.3.', __METHOD__), E_USER_DEPRECATED);
+                    @trigger_error(sprintf('The "%s()" method will have a 6th `string $context = null` argument in version 4.0. Not defining it is deprecated since Symfony 3.3.', __METHOD__), \E_USER_DEPRECATED);
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ public function __toString()`
`233`	`233`	`protected function doSerialize($serialized, $isCalledFromOverridingMethod)`
`234`	`234`	`{`
`235`	`235`	`if (null === $isCalledFromOverridingMethod) {`
`236`		`- $trace = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 3);`
	`236`	`+ $trace = debug_backtrace(\DEBUG_BACKTRACE_PROVIDE_OBJECT, 3);`
`237`	`237`	`$isCalledFromOverridingMethod = isset($trace[2]['function'], $trace[2]['object']) && 'serialize' === $trace[2]['function'] && $this === $trace[2]['object'];`
`238`	`238`	`}`
`239`	`239`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public function __construct($voters = [], $strategy = self::STRATEGY_AFFIRMATIVE`
`62`	`62`	`*/`
`63`	`63`	`public function setVoters(array $voters)`
`64`	`64`	`{`
`65`		`- @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 3.3 and will be removed in 4.0. Pass the voters to the constructor instead.', __METHOD__), E_USER_DEPRECATED);`
	`65`	`+ @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 3.3 and will be removed in 4.0. Pass the voters to the constructor instead.', __METHOD__), \E_USER_DEPRECATED);`
`66`	`66`
`67`	`67`	`$this->voters = $voters;`
`68`	`68`	`}`
`@@ -191,7 +191,7 @@ private function vote($voter, TokenInterface $token, $subject, $attributes)`
`191`	`191`	`}`
`192`	`192`
`193`	`193`	`if (method_exists($voter, 'vote')) {`
`194`		`- @trigger_error(sprintf('Calling vote() on an voter without %1$s is deprecated as of 3.4 and will be removed in 4.0. Implement the %1$s on your voter.', VoterInterface::class), E_USER_DEPRECATED);`
	`194`	`+ @trigger_error(sprintf('Calling vote() on an voter without %1$s is deprecated as of 3.4 and will be removed in 4.0. Implement the %1$s on your voter.', VoterInterface::class), \E_USER_DEPRECATED);`
`195`	`195`
`196`	`196`	`// making the assumption that the signature matches`
`197`	`197`	`return $voter->vote($token, $subject, $attributes);`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public function decide(TokenInterface $token, array $attributes, $object = null)`
`67`	`67`	`*/`
`68`	`68`	`public function setVoters(array $voters)`
`69`	`69`	`{`
`70`		`- @trigger_error(sprintf('The %s() method is deprecated since Symfony 3.3 and will be removed in 4.0. Pass voters to the decorated AccessDecisionManager instead.', __METHOD__), E_USER_DEPRECATED);`
	`70`	`+ @trigger_error(sprintf('The %s() method is deprecated since Symfony 3.3 and will be removed in 4.0. Pass voters to the decorated AccessDecisionManager instead.', __METHOD__), \E_USER_DEPRECATED);`
`71`	`71`
`72`	`72`	`if (!method_exists($this->manager, 'setVoters')) {`
`73`	`73`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public static function isSupported()`
`26`	`26`	`return true;`
`27`	`27`	`}`
`28`	`28`
`29`		`- return version_compare(\extension_loaded('sodium') ? SODIUM_LIBRARY_VERSION : phpversion('libsodium'), '1.0.9', '>=');`
	`29`	`+ return version_compare(\extension_loaded('sodium') ? \SODIUM_LIBRARY_VERSION : phpversion('libsodium'), '1.0.9', '>=');`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`/**`
`@@ -79,15 +79,15 @@ public function isPasswordValid($encoded, $raw, $salt)`
`79`	`79`
`80`	`80`	`private function encodePasswordNative($raw)`
`81`	`81`	`{`
`82`		`- return password_hash($raw, PASSWORD_ARGON2I);`
	`82`	`+ return password_hash($raw, \PASSWORD_ARGON2I);`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`private function encodePasswordSodiumFunction($raw)`
`86`	`86`	`{`
`87`	`87`	`$hash = sodium_crypto_pwhash_str(`
`88`	`88`	`$raw,`
`89`		`- SODIUM_CRYPTO_PWHASH_OPSLIMIT_INTERACTIVE,`
`90`		`- SODIUM_CRYPTO_PWHASH_MEMLIMIT_INTERACTIVE`
	`89`	`+ \SODIUM_CRYPTO_PWHASH_OPSLIMIT_INTERACTIVE,`
	`90`	`+ \SODIUM_CRYPTO_PWHASH_MEMLIMIT_INTERACTIVE`
`91`	`91`	`);`
`92`	`92`	`sodium_memzero($raw);`
`93`	`93`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ public function encodePassword($raw, $salt)`
`71`	`71`	`// Ignore $salt, the auto-generated one is always the best`
`72`	`72`	`}`
`73`	`73`
`74`		`- return password_hash($raw, PASSWORD_BCRYPT, $options);`
	`74`	`+ return password_hash($raw, \PASSWORD_BCRYPT, $options);`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public function serialize()`
`60`	`60`	`protected function doSerialize($serialized, $isCalledFromOverridingMethod)`
`61`	`61`	`{`
`62`	`62`	`if (null === $isCalledFromOverridingMethod) {`
`63`		`- $trace = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 3);`
	`63`	`+ $trace = debug_backtrace(\DEBUG_BACKTRACE_PROVIDE_OBJECT, 3);`
`64`	`64`	`$isCalledFromOverridingMethod = isset($trace[2]['function'], $trace[2]['object']) && 'serialize' === $trace[2]['function'] && $this === $trace[2]['object'];`
`65`	`65`	`}`
`66`	`66`
Original file line number	Diff line number	Diff line change
`@@ -47,11 +47,11 @@ public function testStoreTokenInClosedSessionWithExistingSessionId()`
`47`	`47`	`{`
`48`	`48`	`session_id('foobar');`
`49`	`49`
`50`		`- $this->assertSame(PHP_SESSION_NONE, session_status());`
	`50`	`+ $this->assertSame(\PHP_SESSION_NONE, session_status());`
`51`	`51`
`52`	`52`	`$this->storage->setToken('token_id', 'TOKEN');`
`53`	`53`
`54`		`- $this->assertSame(PHP_SESSION_ACTIVE, session_status());`
	`54`	`+ $this->assertSame(\PHP_SESSION_ACTIVE, session_status());`
`55`	`55`	`$this->assertSame([self::SESSION_NAMESPACE => ['token_id' => 'TOKEN']], $_SESSION);`
`56`	`56`	`}`
`57`	`57`
Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ public function clear()`
`112`	`112`
`113`	`113`	`private function startSession()`
`114`	`114`	`{`
`115`		`- if (PHP_SESSION_NONE === session_status()) {`
	`115`	`+ if (\PHP_SESSION_NONE === session_status()) {`
`116`	`116`	`session_start();`
`117`	`117`	`}`
`118`	`118`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ abstract class AbstractGuardAuthenticator implements AuthenticatorInterface`
`27`	`27`	`*/`
`28`	`28`	`public function supports(Request $request)`
`29`	`29`	`{`
`30`		`- @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 3.4 and will be removed in 4.0. Implement the "%s::supports()" method in class "%s" instead.', __METHOD__, AuthenticatorInterface::class, static::class), E_USER_DEPRECATED);`
	`30`	`+ @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 3.4 and will be removed in 4.0. Implement the "%s::supports()" method in class "%s" instead.', __METHOD__, AuthenticatorInterface::class, static::class), \E_USER_DEPRECATED);`
`31`	`31`
`32`	`32`	`return true;`
`33`	`33`	`}`