Skip to content

Commit 1043fb1

Browse files
committed
minor #908 [StimulusBundle] Marking only the AssetMapper integration as experimental (weaverryan)
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [StimulusBundle] Marking only the AssetMapper integration as experimental | Q | A | ------------- | --- | Bug fix? | yesish | New feature? | no | Tickets | Addresses #907 (comment) | License | MIT StimulusBundle should not really be experimental. The `stimulus_*` Twig functions were ported from WebpackEncoreBundle and should work the same (if they don't, that would be a bug). The only part that should be experimental is the AssetMapper integration. Cheers! Commits ------- 71abb6f [StimulusBundle] Marking only the AssetMapper integration as experimental
2 parents 867a489 + 71abb6f commit 1043fb1

File tree

7 files changed

+3
-18
lines changed

7 files changed

+3
-18
lines changed

src/StimulusBundle/README.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
# StimulusBundle: Symfony integration with Stimulus!
22

3-
**EXPERIMENTAL** This bundle is currently experimental. It is possible that
4-
backwards-compatibility breaks could happen between minor versions.
5-
63
This bundle adds integration between Symfony, Stimulus and Symfony UX:
74

85
- A) Twig `stimulus_*` functions & filters to add Stimulus controllers, actions & targets in your templates;
9-
- B) Integration with Symfony UX & AssetMapper;
6+
- B) Integration with Symfony UX & AssetMapper (this integration is [experimental](https://symfony.com/doc/current/contributing/code/experimental.html)
107
- C) A helper service to build the Stimulus data attributes and use them in your services.
118

129
[Read the documentation][1]

src/StimulusBundle/doc/index.rst

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
StimulusBundle: Symfony integration with Stimulus
22
=================================================
33

4-
**EXPERIMENTAL** This bundle is currently experimental. It is possible that
5-
backwards-compatibility breaks could happen between minor versions.
6-
74
This bundle adds integration between Symfony, `Stimulus`_ and Symfony UX:
85

96
A) Twig `stimulus_*` functions & filters to add Stimulus controllers, actions & targets in your templates;
10-
B) Integration with Symfony UX & AssetMapper;
7+
B) Integration with Symfony UX & AssetMapper (this integration is `experimental`_)
118
C) A helper service to build the Stimulus data attributes and use them in your services.
129

1310
Installation
@@ -314,3 +311,4 @@ is running in debug mode.
314311
.. _`parameters`: https://stimulus.hotwired.dev/reference/actions#action-parameters
315312
.. _`Stimulus Targets`: https://stimulus.hotwired.dev/reference/targets
316313
.. _`StimulusBundle Flex recipe`: https://github.com/symfony/recipes/tree/main/symfony/stimulus-bundle
314+
.. _`experimental`: https://symfony.com/doc/current/contributing/code/experimental.html

src/StimulusBundle/src/DependencyInjection/StimulusExtension.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
use Symfony\Component\HttpKernel\DependencyInjection\Extension;
2424

2525
/**
26-
* @experimental
27-
*
2826
* @author Ryan Weaver <[email protected]>
2927
*/
3028
final class StimulusExtension extends Extension implements PrependExtensionInterface, ConfigurationInterface

src/StimulusBundle/src/Dto/StimulusAttributes.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
/**
1717
* Helper to build Stimulus-related HTML attributes.
1818
*
19-
* @experimental
20-
*
2119
* @author Ryan Weaver <[email protected]>
2220
*/
2321
class StimulusAttributes implements \Stringable, \IteratorAggregate

src/StimulusBundle/src/Helper/StimulusHelper.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
use Twig\Loader\ArrayLoader;
1717

1818
/**
19-
* @experimental
20-
*
2119
* @author Ryan Weaver <[email protected]>
2220
*/
2321
final class StimulusHelper

src/StimulusBundle/src/StimulusBundle.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
use Symfony\UX\StimulusBundle\DependencyInjection\Compiler\RemoveAssetMapperServicesCompiler;
1515

1616
/**
17-
* @experimental
18-
*
1917
* @author Ryan Weaver <[email protected]>
2018
*/
2119
final class StimulusBundle extends Bundle

src/StimulusBundle/src/Twig/StimulusTwigExtension.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
use Twig\TwigFunction;
1919

2020
/**
21-
* @experimental
22-
*
2321
* @author Ryan Weaver <[email protected]>
2422
*/
2523
final class StimulusTwigExtension extends AbstractExtension

0 commit comments

Comments
 (0)