Skip to content

Commit 8ab561f

Browse files
committed
bug #2952 Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from vendor/ PHP packages (Kocal)
This PR was merged into the 2.x branch. Discussion ---------- Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from `vendor/` PHP packages | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #2951 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Since #2932 Dropping any fancy stuff from our `package.json` since it can breaks when people install JS packages through the PHP packages I will edit the "test apps" jobs to use `npm` to install dependencies, so we will be sure in the future we are not breaking things again. Commits ------- 4c24ce6 Fix package.json files to not use "catalog" feature from PNPM, as it breaks installation from `vendor/` PHP packages
2 parents 0ecca4c + 4c24ce6 commit 8ab561f

File tree

22 files changed

+310
-351
lines changed

22 files changed

+310
-351
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@
1414
},
1515
"devDependencies": {
1616
"@biomejs/biome": "^2.0.4",
17-
"@testing-library/dom": "catalog:",
18-
"@testing-library/jest-dom": "catalog:",
17+
"@testing-library/dom": "^10.4.0",
18+
"@testing-library/jest-dom": "^6.6.3",
1919
"@types/node": "^22.6.0",
2020
"lightningcss": "^1.28.2",
2121
"pkg-types": "^2.2.0",
2222
"playwright": "^1.47.0",
2323
"tinyglobby": "^0.2.14",
2424
"tsup": "^8.5.0",
25-
"vitest": "catalog:"
25+
"vitest": "^3.2.4"
2626
},
2727
"version": "2.27.0"
2828
}

0 commit comments

Comments
 (0)