Skip to content

Commit a6c5500

Browse files
HypeMCnicolas-grekas
authored andcommitted
[HttpKernel][Workflow] Declare arguments explicitly
1 parent d2c4ffb commit a6c5500

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ CHANGELOG
66

77
* Add method `getEnabledTransition()` to `WorkflowInterface`
88
* Add `$nbToken` argument to `Marking::mark()` and `Marking::unmark()`
9+
* Add `$asArc` argument to `Transition::getFroms()` and `Transition::getTos()`
910
* Remove `Event::getWorkflow()` method
1011

1112
*Before*

Transition.php

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,27 +46,23 @@ public function getName(): string
4646
}
4747

4848
/**
49-
* @param bool $asArc
50-
*
5149
* @return $asArc is true ? array<Arc> : array<string>
5250
*/
53-
public function getFroms(/* bool $asArc = false */): array
51+
public function getFroms(bool $asArc = false): array
5452
{
55-
if (1 <= \func_num_args() && func_get_arg(0)) {
53+
if ($asArc) {
5654
return $this->fromArcs;
5755
}
5856

5957
return array_column($this->fromArcs, 'place');
6058
}
6159

6260
/**
63-
* @param bool $asArc
64-
*
6561
* @return $asArc is true ? array<Arc> : array<string>
6662
*/
67-
public function getTos(/* bool $asArc = false */): array
63+
public function getTos(bool $asArc = false): array
6864
{
69-
if (1 <= \func_num_args() && func_get_arg(0)) {
65+
if ($asArc) {
7066
return $this->toArcs;
7167
}
7268

0 commit comments

Comments
 (0)