[Tests] avoid relying on implicit toStrings

ljharb · ljharb · commit ceca8d5ad88a · 2025-02-07T11:50:26.000-08:00
diff --git a/example/array.js b/example/array.js
@@ -25,7 +25,7 @@ test('array', function (t) {
 		[[ 1, 2, [3, 4]], [5, 6]]
 	];
 
-	Function(['fn', 'g'], output)(
+	Function('fn', 'g', String(output))(
 		function (xs) {
 			t.same(arrays.shift(), xs);
 			return xs;
diff --git a/example/fail.js b/example/fail.js
@@ -25,7 +25,7 @@ test('array', function (t) {
 		[ [ 1, 2, [ 3, 4 ] ], [ 5, 6 ] ]
 	];
 
-	Function(['fn', 'g'], output)(
+	Function('fn', 'g', String(output))(
 		function (xs) {
 			t.same(arrays.shift(), xs);
 			return xs;
diff --git a/example/nested.js b/example/nested.js
@@ -34,7 +34,7 @@ test('nested array test', function (t) {
 		[[1, 2, [3, 4]], [5, 6]]
 	];
 
-	Function(['fn', 'g'], output)(
+	Function('fn', 'g', String(output))(
 		function (xs) {
 			t.same(arrays.shift(), xs);
 			return xs;
diff --git a/example/nested_fail.js b/example/nested_fail.js
@@ -34,7 +34,7 @@ test('nested array test', function (t) {
 		[ [ 1, 2, [ 3, 4 ] ], [ 5, 6 ] ]
 	];
 
-	Function(['fn', 'g'], output)(
+	Function('fn', 'g', String(output))(
 		function (xs) {
 			t.same(arrays.shift(), xs);
 			return xs;
diff --git a/example/not_enough_fail.js b/example/not_enough_fail.js
@@ -25,7 +25,7 @@ test('array', function (t) {
 		[[1, 2, [3, 4]], [5, 6]]
 	];
 
-	Function(['fn', 'g'], output)(
+	Function('fn', 'g', String(output))(
 		function (xs) {
 			t.same(arrays.shift(), xs);
 			return xs;
diff --git a/example/too_many_fail.js b/example/too_many_fail.js
@@ -25,7 +25,7 @@ test('array', function (t) {
 		[[1, 2, [3, 4]], [5, 6]]
 	];
 
-	Function(['fn', 'g'], output)(
+	Function('fn', 'g', String(output))(
 		function (xs) {
 			t.same(arrays.shift(), xs);
 			return xs;
diff --git a/test/array.js b/test/array.js
@@ -50,7 +50,7 @@ tap.test('array test', function (tt) {
 			[[1, 2, [3, 4]], [5, 6]]
 		];
 
-		Function(['fn', 'g'], output)(
+		Function('fn', 'g', String(output))(
 			function (xs) {
 				t.same(arrays.shift(), xs);
 				return xs;
diff --git a/test/exit/fail.js b/test/exit/fail.js
@@ -25,7 +25,7 @@ test('array', function (t) {
 		[[1, 2, [3, 4]], [5, 6]]
 	];
 
-	Function(['fn', 'g'], output)(
+	Function('fn', 'g', String(output))(
 		function (xs) {
 			t.same(arrays.shift(), xs);
 			return xs;
diff --git a/test/exit/ok.js b/test/exit/ok.js
@@ -26,7 +26,7 @@ test('array', function (t) {
 		[[1, 2, [3, 4]], [5, 6]]
 	];
 
-	Function(['fn', 'g'], output)(
+	Function('fn', 'g', String(output))(
 		function (xs) {
 			t.same(arrays.shift(), xs);
 			return xs;
diff --git a/test/exit/too_few.js b/test/exit/too_few.js
@@ -25,7 +25,7 @@ test('array', function (t) {
 		[[1, 2, [3, 4]], [5, 6]]
 	];
 
-	Function(['fn', 'g'], output)(
+	Function('fn', 'g', String(output))(
 		function (xs) {
 			t.same(arrays.shift(), xs);
 			return xs;
diff --git a/test/fail.js b/test/fail.js
@@ -67,7 +67,7 @@ tap.test('array test', function (tt) {
 			[[1, 2, [3, 4]], [5, 6]]
 		];
 
-		Function(['fn', 'g'], output)(
+		Function('fn', 'g', String(output))(
 			function (xs) {
 				t.same(arrays.shift(), xs);
 				return xs;
diff --git a/test/nested.js b/test/nested.js
@@ -66,7 +66,7 @@ tap.test('array test', function (tt) {
 			[[1, 2, [3, 4]], [5, 6]]
 		];
 
-		Function(['fn', 'g'], output)(
+		Function('fn', 'g', String(output))(
 			function (xs) {
 				t.same(arrays.shift(), xs);
 				return xs;
diff --git a/test/throws.js b/test/throws.js
@@ -364,7 +364,7 @@ tap.test('failures', function (tt) {
 			function () { throw new SyntaxError('Wrong value'); },
 			function (error) {
 				t.ok(error instanceof SyntaxError, 'error is SyntaxError');
-				t.ok((/value/).test(error), 'error matches /value/');
+				t.ok((/value/).test(String(error)), 'error matches /value/');
 				// Avoid returning anything from validation functions besides `true`.
 				// Otherwise, it's not clear what part of the validation failed. Instead,
 				// throw an error about the specific validation that failed (as done in this
diff --git a/test/too_many.js b/test/too_many.js
@@ -68,7 +68,7 @@ tap.test('array test', function (tt) {
 			[[1, 2, [3, 4]], [5, 6]]
 		];
 
-		Function(['fn', 'g'], output)(
+		Function('fn', 'g', String(output))(
 			function (xs) {
 				t.same(arrays.shift(), xs);
 				return xs;
