box: refactored tests with box.New

Tests now use `box.MustNew` instead of `box.New`.

Added TestMocked_BoxNew for box.New creating a workable object
by means of checking length of Request[] in mockDoer after subrequest.

Closes #448

Author: laines-it

CHANGELOG.md

@@ -11,16 +11,15 @@ Versioning](http://semver.org/spec/v2.0.0.html) except to the first release.
 ### Added
 
 * New types for MessagePack extensions compatible with go-option (#459).
-* Added `box.MustNew` wrapper for `box.New`: panics when `box.New` returns an error (#448).
+* Added `box.MustNew` wrapper for `box.New` without an error (#448).
 
 ### Changed
 
 * Required Go version is `1.24` now (#456).
+* `box.New` returns an error instead of panic (#448).
 
 ### Fixed
 
-* `box.New` returns an error instead of panic (#448).
-
 ## [v2.4.1] - 2025-10-16
 
 This maintenance release marks the end of active development on the `v2`

MIGRATION.md

@@ -9,6 +9,8 @@ TODO
 ### <a id="major-changes-v3">Major changes</a>
 
 * Required Go version is `1.24` now.
+* `box.New` returns an error instead of panic
+* Added `box.MustNew` wrapper for `box.New` without an error
 
 ## Migration from v1.x.x to v2.x.x
 

box/box.go

@@ -24,11 +24,10 @@ func New(conn tarantool.Doer) (*Box, error) {
 }
 
 // MustNew returns a new instance of the box structure, which implements the Box interface.
+// It panics if conn == nil.
 func MustNew(conn tarantool.Doer) *Box {
 	b, err := New(conn)
 	if err != nil {
-		// Check if the provided Tarantool connection is nil, and if it is, panic with an error
-		// message. panic early helps to catch and fix nil pointer issues in the code
 		panic(err)
 	}
 	return b

box/box_test.go

@@ -26,6 +26,22 @@ func TestMustNew(t *testing.T) {
 	require.Panics(t, func() { box.MustNew(nil) })
 }
 
+func TestMocked_BoxNew(t *testing.T) {
+	t.Parallel()
+
+	mock := test_helpers.NewMockDoer(t,
+		test_helpers.NewMockResponse(t, "valid"),
+	)
+
+	b, err := box.New(&mock)
+	require.NoError(t, err)
+	require.NotNil(t, b)
+
+	assert.Len(t, mock.Requests, 0)
+	b.Schema().User().Exists(box.NewInfoRequest().Ctx(), "")
+	require.Len(t, mock.Requests, 1)
+}
+
 func TestMocked_BoxInfo(t *testing.T) {
 	t.Parallel()
 
@@ -44,8 +60,7 @@ func TestMocked_BoxInfo(t *testing.T) {
 	mock := test_helpers.NewMockDoer(t,
 		test_helpers.NewMockResponse(t, data),
 	)
-	b, err := box.New(&mock)
-	require.NoError(t, err)
+	b := box.MustNew(&mock)
 
 	info, err := b.Info()
 	require.NoError(t, err)
@@ -65,8 +80,7 @@ func TestMocked_BoxSchemaUserInfo(t *testing.T) {
 	mock := test_helpers.NewMockDoer(t,
 		test_helpers.NewMockResponse(t, data),
 	)
-	b, err := box.New(&mock)
-	require.NoError(t, err)
+	b := box.MustNew(&mock)
 
 	privs, err := b.Schema().User().Info(context.Background(), "username")
 	require.NoError(t, err)
@@ -91,9 +105,8 @@ func TestMocked_BoxSessionSu(t *testing.T) {
 		test_helpers.NewMockResponse(t, []interface{}{}),
 		errors.New("user not found or supplied credentials are invalid"),
 	)
-	b, err := box.New(&mock)
-	require.NoError(t, err)
+	b := box.MustNew(&mock)
 
-	err = b.Session().Su(context.Background(), "admin")
+	err := b.Session().Su(context.Background(), "admin")
 	require.NoError(t, err)
 }

box/example_test.go

@@ -45,10 +45,7 @@ func ExampleBox_Info() {
 
 	// Or use simple Box implementation.
 
-	b, err := box.New(client)
-	if err != nil {
-		log.Fatalf("Failed get box info: %s", err)
-	}
+	b := box.MustNew(client)
 
 	info, err := b.Info()
 	if err != nil {
@@ -91,10 +88,7 @@ func ExampleSchemaUser_Exists() {
 	}
 
 	// Or use simple User implementation.
-	b, err := box.New(client)
-	if err != nil {
-		log.Fatalf("Failed get box info: %s", err)
-	}
+	b := box.MustNew(client)
 
 	exists, err := b.Schema().User().Exists(ctx, "user")
 	if err != nil {
@@ -127,11 +121,7 @@ func ExampleSchemaUser_Create() {
 	}
 
 	// Create SchemaUser.
-	b, err := box.New(client)
-	if err != nil {
-		log.Fatalf("Failed to connect: %s", err)
-	}
-	schemaUser := b.Schema().User()
+	schemaUser := box.MustNew(client).Schema().User()
 
 	// Create a new user.
 	username := "new_user"
@@ -164,11 +154,7 @@ func ExampleSchemaUser_Drop() {
 	}
 
 	// Create SchemaUser.
-	b, err := box.New(client)
-	if err != nil {
-		log.Fatalf("Failed to connect: %s", err)
-	}
-	schemaUser := b.Schema().User()
+	schemaUser := box.MustNew(client).Schema().User()
 
 	// Drop an existing user.
 	username := "new_user"
@@ -207,11 +193,7 @@ func ExampleSchemaUser_Password() {
 	}
 
 	// Create SchemaUser.
-	b, err := box.New(client)
-	if err != nil {
-		log.Fatalf("Failed to connect: %s", err)
-	}
-	schemaUser := b.Schema().User()
+	schemaUser := box.MustNew(client).Schema().User()
 
 	// Get the password hash.
 	password := "my-password"
@@ -240,11 +222,7 @@ func ExampleSchemaUser_Info() {
 	}
 
 	// Create SchemaUser.
-	b, err := box.New(client)
-	if err != nil {
-		log.Fatalf("Failed to connect: %s", err)
-	}
-	schemaUser := b.Schema().User()
+	schemaUser := box.MustNew(client).Schema().User()
 
 	info, err := schemaUser.Info(ctx, "test")
 	if err != nil {

box/session_test.go

@@ -10,8 +10,7 @@ import (
 )
 
 func TestBox_Session(t *testing.T) {
-	b, err := box.New(th.Ptr(th.NewMockDoer(t)))
-	require.NoError(t, err)
+	b := box.MustNew(th.Ptr(th.NewMockDoer(t)))
 	require.NotNil(t, b.Session())
 }