Fix deprecation warnings #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm getting a ton of error messages in my logs like: ``` Deprecated: Return type of TBela\CSS\Element::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in [...]/src/ArrayTrait.php on line 72 ``` and ``` Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in [...]/src/Value.php on line 590 ```
Owner
|
thanks, I will review the updates ASAP |
Author
|
(bulk-closing PRs for libraries I'm no longer using) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using php 8.2 I'm getting a ton of error messages in my logs like:
and
I'm not sure if this will break compatibility with php 8.0, I hope that the automated test suite will say if that's the case (if so, maybe the
#[\ReturnTypeWillChange]approach would work?)There are still two deprecation warnings coming from the upstream
opis/closurelibrary though...