Clean up tests broken by use of the TypedArray constructor argument factory

Author: gibson042

test/built-ins/TypedArray/prototype/copyWithin/bit-precision.js

@@ -16,7 +16,7 @@ includes: [nans.js, compareArray.js, testTypedArray.js]
 features: [TypedArray]
 ---*/
 
-function body(FloatArray) {
+testWithTypedArrayConstructors(function body(FloatArray) {
   var subject = new FloatArray(NaNs.length * 2);
 
   NaNs.forEach(function(v, i) {
@@ -39,6 +39,4 @@ function body(FloatArray) {
   );
 
   assert(compareArray(originalBytes, copiedBytes));
-}
-
-testWithTypedArrayConstructors((body), floatArrayConstructors);
+}, floatArrayConstructors);

test/built-ins/TypedArray/prototype/map/return-new-typedarray-conversion-operation-consistent-nan.js

@@ -53,7 +53,7 @@ includes: [nans.js, testTypedArray.js, compareArray.js]
 features: [TypedArray]
 ---*/
 
-function body(FloatArray) {
+testWithTypedArrayConstructors(function body(FloatArray) {
   var sample = new FloatArray(NaNs);
   var sampleBytes, resultBytes;
   var i = 0;
@@ -66,6 +66,4 @@ function body(FloatArray) {
   resultBytes = new Uint8Array(result.buffer);
 
   assert(compareArray(sampleBytes, resultBytes));
-}
-
-testWithTypedArrayConstructors((body), floatArrayConstructors);
+}, floatArrayConstructors);

test/built-ins/TypedArray/prototype/set/bit-precision.js

@@ -19,7 +19,7 @@ includes: [nans.js, compareArray.js, testTypedArray.js]
 features: [TypedArray]
 ---*/
 
-function body(FA) {
+testWithTypedArrayConstructors(function body(FA) {
   var source = new FA(NaNs);
   var target = new FA(NaNs.length);
   var sourceBytes, targetBytes;
@@ -30,6 +30,4 @@ function body(FA) {
   targetBytes = new Uint8Array(target.buffer);
 
   assert(compareArray(sourceBytes, targetBytes))
-}
-
-testWithTypedArrayConstructors((body), floatArrayConstructors);
+}, floatArrayConstructors);

test/built-ins/TypedArray/prototype/slice/bit-precision.js

@@ -24,7 +24,7 @@ includes: [nans.js, compareArray.js, testTypedArray.js]
 features: [TypedArray]
 ---*/
 
-function body(FloatArray) {
+testWithTypedArrayConstructors(function body(FloatArray) {
   var subject = new FloatArray(NaNs);
   var sliced, subjectBytes, slicedBytes;
 
@@ -34,6 +34,4 @@ function body(FloatArray) {
   slicedBytes = new Uint8Array(sliced.buffer);
 
   assert(compareArray(subjectBytes, slicedBytes));
-}
-
-testWithTypedArrayConstructors((body), floatArrayConstructors);
+}, floatArrayConstructors);

test/built-ins/TypedArray/prototype/subarray/BigInt/speciesctor-get-species-custom-ctor-invocation.js

@@ -8,6 +8,11 @@ info: |
   22.2.3.27 %TypedArray%.prototype.subarray( begin , end )
 
   ...
+  15. If O.[[ArrayLength]] is auto and end is undefined, then
+      a. Let argumentsList be « buffer, 𝔽(beginByteOffset) ».
+  16. Else,
+      ...
+      f. Let argumentsList be « buffer, 𝔽(beginByteOffset), 𝔽(newLength) ».
   17. Return ? TypedArraySpeciesCreate(O, argumentsList).
 
   22.2.4.7 TypedArraySpeciesCreate ( exemplar, argumentList )
@@ -31,7 +36,7 @@ info: |
   3. If argumentList is a List of a single Number, then
     ...
   4. Return newTypedArray.
-includes: [testTypedArray.js]
+includes: [compareArray.js, testTypedArray.js]
 features: [BigInt, Symbol.species, TypedArray]
 ---*/
 
@@ -49,10 +54,10 @@ testWithBigIntTypedArrayConstructors(function(TA, makeCtorArg) {
 
   sample.subarray(1);
 
-  assert.sameValue(result.length, 3, "called with 3 arguments");
-  assert.sameValue(result[0], sample.buffer, "[0] is sample.buffer");
-  assert.sameValue(result[1], expectedOffset, "[1] is the byte offset pos");
-  assert.sameValue(result[2], 2, "[2] is expected length");
+  var expectArgs = sample.buffer.resizable
+    ? [sample.buffer, expectedOffset]
+    : [sample.buffer, expectedOffset, 2];
+  assert.compareArray(result, expectArgs, "Constructor called with arguments");
 
   assert(
     ctorThis instanceof sample.constructor[Symbol.species],

test/built-ins/TypedArray/prototype/subarray/speciesctor-get-species-custom-ctor-invocation.js

@@ -8,6 +8,11 @@ info: |
   22.2.3.27 %TypedArray%.prototype.subarray( begin , end )
 
   ...
+  15. If O.[[ArrayLength]] is auto and end is undefined, then
+      a. Let argumentsList be « buffer, 𝔽(beginByteOffset) ».
+  16. Else,
+      ...
+      f. Let argumentsList be « buffer, 𝔽(beginByteOffset), 𝔽(newLength) ».
   17. Return ? TypedArraySpeciesCreate(O, argumentsList).
 
   22.2.4.7 TypedArraySpeciesCreate ( exemplar, argumentList )
@@ -31,7 +36,7 @@ info: |
   3. If argumentList is a List of a single Number, then
     ...
   4. Return newTypedArray.
-includes: [testTypedArray.js]
+includes: [compareArray.js, testTypedArray.js]
 features: [Symbol.species, TypedArray]
 ---*/
 
@@ -49,10 +54,10 @@ testWithTypedArrayConstructors(function(TA, makeCtorArg) {
 
   sample.subarray(1);
 
-  assert.sameValue(result.length, 3, "called with 3 arguments");
-  assert.sameValue(result[0], sample.buffer, "[0] is sample.buffer");
-  assert.sameValue(result[1], expectedOffset, "[1] is the byte offset pos");
-  assert.sameValue(result[2], 2, "[2] is expected length");
+  var expectArgs = sample.buffer.resizable
+    ? [sample.buffer, expectedOffset]
+    : [sample.buffer, expectedOffset, 2];
+  assert.compareArray(result, expectArgs, "Constructor called with arguments");
 
   assert(
     ctorThis instanceof sample.constructor[Symbol.species],

test/built-ins/TypedArrayConstructors/ctors/object-arg/conversion-operation-consistent-nan.js

@@ -58,13 +58,11 @@ includes: [nans.js, testTypedArray.js, compareArray.js]
 features: [TypedArray]
 ---*/
 
-function body(FloatArray) {
+testWithTypedArrayConstructors(function body(FloatArray) {
   var first = new FloatArray(NaNs);
   var second = new FloatArray(NaNs);
   var firstBytes = new Uint8Array(first.buffer);
   var secondBytes = new Uint8Array(second.buffer);
 
   assert(compareArray(firstBytes, secondBytes));
-}
-
-testWithTypedArrayConstructors((body), floatArrayConstructors);
+}, floatArrayConstructors);

test/built-ins/TypedArrayConstructors/ctors/object-arg/iterated-array-with-modified-array-iterator.js

@@ -34,16 +34,16 @@ ArrayIteratorPrototype.next = function() {
   return {value, done};
 };
 
-testWithTypedArrayConstructors(function(TypedArray, makeCtorArg) {
+testWithTypedArrayConstructors(function(TypedArray) {
   // Reset `values` array.
   values = [1, 2, 3, 4];
 
   // Constructor called with array which uses the modified array iterator.
-  var ta = new TypedArray(makeCtorArg([0]));
+  var ta = new TypedArray([0]);
 
   assert.sameValue(ta.length, 4);
   assert.sameValue(ta[0], 4);
   assert.sameValue(ta[1], 3);
   assert.sameValue(ta[2], 2);
   assert.sameValue(ta[3], 1);
-});
+}, null, ["passthrough"]);