Refactor outputs

Author: posquit0

modules/subnet-group/outputs.tf

@@ -40,73 +40,73 @@ output "subnets" {
 
 output "db_subnet_group_id" {
   description = "The ID of the RDS Subnet Group."
-  value       = element(concat(aws_db_subnet_group.this.*.id, [""]), 0)
+  value       = try(aws_db_subnet_group.this.*.id[0], null)
 }
 
 output "db_subnet_group_arn" {
   description = "The ARN of the RDS Subnet Group."
-  value       = element(concat(aws_db_subnet_group.this.*.arn, [""]), 0)
+  value       = try(aws_db_subnet_group.this.*.arn[0], null)
 }
 
 output "cache_subnet_group_id" {
   description = "The ID of the Elasticache Subnet Group."
-  value       = element(concat(aws_elasticache_subnet_group.this.*.id, [""]), 0)
+  value       = try(aws_elasticache_subnet_group.this.*.id[0], null)
 }
 
 # INFO: Not support arn output
 # output "cache_subnet_group_arn" {
 #   description = "The ARN of the Elasticache Subnet Group."
-#   value       = element(concat(aws_elasticache_subnet_group.this.*.arn, [""]), 0)
+#   value       = try(aws_elasticache_subnet_group.this.*.arn[0], null)
 # }
 
 output "redshift_subnet_group_id" {
   description = "The ID of the Redshift Subnet Group."
-  value       = element(concat(aws_redshift_subnet_group.this.*.id, [""]), 0)
+  value       = try(aws_redshift_subnet_group.this.*.id[0], null)
 }
 
 output "redshift_subnet_group_arn" {
   description = "The ARN of the Redshift Subnet Group."
-  value       = element(concat(aws_redshift_subnet_group.this.*.arn, [""]), 0)
+  value       = try(aws_redshift_subnet_group.this.*.arn[0], null)
 }
 
 output "neptune_subnet_group_id" {
   description = "The ID of the Neptune DB Subnet Group."
-  value       = element(concat(aws_neptune_subnet_group.this.*.id, [""]), 0)
+  value       = try(aws_neptune_subnet_group.this.*.id[0], null)
 }
 
 output "neptune_subnet_group_arn" {
   description = "The ARN of the Neptune Subnet Group."
-  value       = element(concat(aws_neptune_subnet_group.this.*.arn, [""]), 0)
+  value       = try(aws_neptune_subnet_group.this.*.arn[0], null)
 }
 
 output "docdb_subnet_group_id" {
   description = "The ID of the DocumentDB Subnet Group."
-  value       = element(concat(aws_docdb_subnet_group.this.*.id, [""]), 0)
+  value       = try(aws_docdb_subnet_group.this.*.id[0], null)
 }
 
 output "docdb_subnet_group_arn" {
   description = "The ARN of the DocumentDB Subnet Group."
-  value       = element(concat(aws_docdb_subnet_group.this.*.arn, [""]), 0)
+  value       = try(aws_docdb_subnet_group.this.*.arn[0], null)
 }
 
 output "dax_subnet_group_id" {
   description = "The ID of the DAX Subnet Group."
-  value       = element(concat(aws_dax_subnet_group.this.*.id, [""]), 0)
+  value       = try(aws_dax_subnet_group.this.*.id[0], null)
 }
 
 # INFO: Not support arn output
 # output "dax_subnet_group_arn" {
 #   description = "The ARN of the DAX Subnet Group."
-#   value       = element(concat(aws_dax_subnet_group.this.*.arn, [""]), 0)
+#   value       = try(aws_dax_subnet_group.this.*.arn[0], null)
 # }
 
 output "dms_replication_subnet_group_id" {
   description = "The ID of the DMS Replication Subnet Group."
-  value       = element(concat(aws_dms_replication_subnet_group.this.*.id, [""]), 0)
+  value       = try(aws_dms_replication_subnet_group.this.*.id[0], null)
 }
 
 # INFO: Not support arn output
 # output "dms_replication_subnet_group_arn" {
 #   description = "The ARN of the DMS Replication Subnet Group."
-#   value       = element(concat(aws_dms_replication_subnet_group.this.*.arn, [""]), 0)
+#   value       = try(aws_dms_replication_subnet_group.this.*.arn[0], null)
 # }

modules/vpc/outputs.tf

@@ -80,12 +80,12 @@ output "dhcp_options_enabled" {
 
 output "dhcp_options_id" {
   description = "The ID of the DHCP Options Set."
-  value       = element(concat(aws_vpc_dhcp_options.this.*.id, [""]), 0)
+  value       = try(aws_vpc_dhcp_options.this.*.id[0], null)
 }
 
 output "dhcp_options_arn" {
   description = "The ARN of the DHCP Options Set."
-  value       = element(concat(aws_vpc_dhcp_options.this.*.arn, [""]), 0)
+  value       = try(aws_vpc_dhcp_options.this.*.arn[0], null)
 }
 
 output "internet_gateway_enabled" {
@@ -95,12 +95,12 @@ output "internet_gateway_enabled" {
 
 output "internet_gateway_id" {
   description = "The ID of the Internet Gateway."
-  value       = element(concat(aws_internet_gateway.this.*.id, [""]), 0)
+  value       = try(aws_internet_gateway.this.*.id[0], null)
 }
 
 output "internet_gateway_arn" {
   description = "The ARN of the Internet Gateway."
-  value       = element(concat(aws_internet_gateway.this.*.arn, [""]), 0)
+  value       = try(aws_internet_gateway.this.*.arn[0], null)
 }
 
 output "egress_only_internet_gateway_enabled" {
@@ -110,7 +110,7 @@ output "egress_only_internet_gateway_enabled" {
 
 output "egress_only_internet_gateway_id" {
   description = "The ID of the Egress Only Internet Gateway."
-  value       = element(concat(aws_egress_only_internet_gateway.this.*.id, [""]), 0)
+  value       = try(aws_egress_only_internet_gateway.this.*.id[0], null)
 }
 
 output "vpn_gateway_enabled" {
@@ -120,15 +120,15 @@ output "vpn_gateway_enabled" {
 
 output "vpn_gateway_id" {
   description = "The ID of the Virtual Private Gateway."
-  value       = element(concat(aws_vpn_gateway.this.*.id, [""]), 0)
+  value       = try(aws_vpn_gateway.this.*.id[0], null)
 }
 
 output "vpn_gateway_arn" {
   description = "The ARN of the Virtual Private Gateway."
-  value       = element(concat(aws_vpn_gateway.this.*.arn, [""]), 0)
+  value       = try(aws_vpn_gateway.this.*.arn[0], null)
 }
 
 output "vpn_gateway_asn" {
   description = "The Autonomous System Number (ASN) for the Amazon side of the gateway. By default the virtual private gateway is created with the current default Amazon ASN."
-  value       = element(concat(aws_vpn_gateway.this.*.amazon_side_asn, [""]), 0)
+  value       = try(aws_vpn_gateway.this.*.amazon_side_asn[0], null)
 }