Pin pylint to 1.8.1 and fix lint warnings (#825)

Author: jart

.travis.yml

@@ -46,7 +46,7 @@ before_install:
         ;;
     esac
 
-    pip install pylint
+    pip install pylint==1.8.1
     pip install futures==3.1.1
     pip install grpcio==1.6.3
 

tensorboard/backend/event_processing/event_file_inspector.py

@@ -385,6 +385,7 @@ def get_inspection_units(logdir='', event_file='', tag=''):
         name=event_file,
         generator=generator,
         field_to_obs=get_field_to_observations_map(generator, tag))]
+  return []
 
 
 def inspect(logdir='', event_file='', tag=''):

tensorboard/backend/event_processing/event_file_loader.py

@@ -69,6 +69,7 @@ def main(argv):
   loader = EventFileLoader(argv[1])
   for event in loader.Load():
     print(event)
+  return 0
 
 
 if __name__ == '__main__':

tensorboard/plugins/debugger/debugger_plugin.py

@@ -344,7 +344,7 @@ def _obtain_health_pills_at_step(self, events_directory, node_names, step):
 
     if not file_paths:
       raise IOError(
-          'No events files found that matches the pattern %r.', pattern)
+          'No events files found that matches the pattern %r.' % pattern)
 
     # Sort by name (and thus by timestamp).
     file_paths.sort()

tensorboard/plugins/debugger/debugger_plugin_testlib.py

@@ -18,6 +18,7 @@
 from __future__ import division
 from __future__ import print_function
 
+# pylint: disable=ungrouped-imports, wrong-import-order
 import os
 import json
 import threading
@@ -27,7 +28,6 @@
 from werkzeug import wrappers
 from werkzeug import test as werkzeug_test
 
-# pylint: disable=ungrouped-imports, wrong-import-order
 from google.protobuf  import json_format
 from tensorboard.backend import application
 from tensorboard.backend.event_processing import plugin_event_multiplexer as event_multiplexer  # pylint: disable=line-too-long

tensorboard/plugins/debugger/debugger_server_lib.py

@@ -145,7 +145,7 @@ def on_value_event(self, event):
           ("A event with a health pill has an invalid node name and output "
            "slot combination, (i.e., an unexpected debug op): %r"),
           node_name_and_output_slot)
-      return None
+      return
 
     if self._session_run_index >= 0:
       event.step = self._session_run_index

tensorboard/plugins/debugger/numerics_alert.py

@@ -327,7 +327,7 @@ def extract_numerics_alert(event):
   debug_op_suffix = ":DebugNumericSummary"
   if not value.node_name.endswith(debug_op_suffix):
     raise ValueError(
-        "Event proto input does not have the expected debug op suffix %s",
+        "Event proto input does not have the expected debug op suffix %s" %
         debug_op_suffix)
   tensor_name = value.node_name[:-len(debug_op_suffix)]
 
@@ -339,3 +339,4 @@ def extract_numerics_alert(event):
     return NumericsAlert(
         device_name, tensor_name, event.wall_time, nan_count, neg_inf_count,
         pos_inf_count)
+  return None

tensorboard/plugins/debugger/session_debug_test.py

@@ -35,9 +35,8 @@
 
 import numpy as np
 import portpicker  # pylint: disable=import-error
-import tensorflow as tf
-
-from tensorflow.python import debug as tf_debug
+import tensorflow as tf  # pylint: disable=wrong-import-order
+from tensorflow.python import debug as tf_debug  # pylint: disable=wrong-import-order
 
 from tensorboard.plugins.debugger import constants
 from tensorboard.plugins.debugger import debugger_server_lib

tensorboard/program.py

@@ -245,7 +245,7 @@ def make_simple_server(tb_app, host=None, port=None, path_prefix=None):
         server = serving.make_server('::', port, tb_app, threaded=True)
       final_host = socket.gethostname()
     server.daemon_threads = True
-  except socket.error as socket_error:
+  except socket.error:
     if port == 0:
       msg = 'TensorBoard unable to find any open port'
     else:
@@ -254,7 +254,7 @@ def make_simple_server(tb_app, host=None, port=None, path_prefix=None):
           % port)
     tf.logging.error(msg)
     print(msg)
-    raise socket_error
+    raise
   server.handle_error = _handle_error
   final_port = server.socket.getsockname()[1]
   tensorboard_url = 'http://%s:%d%s' % (final_host, final_port, path_prefix)

tensorboard/scripts/generate_testdata.py

@@ -219,6 +219,7 @@ def main(unused_argv=None):
       print("Refusing to overwrite target %s without --overwrite" % target)
       return -2
   GenerateTestData(target)
+  return 0
 
 
 if __name__ == "__main__":