chore: Change Kafka vendor configuration from class to interface (#1519)

Author: HofmeisterAn

src/Testcontainers.Kafka/ApacheConfiguration.cs

@@ -1,7 +1,7 @@
 namespace Testcontainers.Kafka;
 
-/// <inheritdoc cref="KafkaVendorConfiguration" />
-internal sealed class ApacheConfiguration : KafkaVendorConfiguration
+/// <inheritdoc cref="IKafkaVendorConfiguration" />
+internal sealed class ApacheConfiguration : IKafkaVendorConfiguration
 {
     static ApacheConfiguration()
     {
@@ -17,25 +17,25 @@ private ApacheConfiguration()
     /// <summary>
     /// Gets the singleton instance of the Apache vendor configuration.
     /// </summary>
-    public static KafkaVendorConfiguration Instance { get; }
+    public static IKafkaVendorConfiguration Instance { get; }
         = new ApacheConfiguration();
 
     /// <inheritdoc />
-    public override KafkaVendor Vendor
+    public KafkaVendor Vendor
         => KafkaVendor.ApacheSoftwareFoundation;
 
     /// <inheritdoc />
-    public override ConsensusProtocol ConsensusProtocol
+    public ConsensusProtocol ConsensusProtocol
         => ConsensusProtocol.KRaft;
 
     /// <inheritdoc />
-    public override bool IsImageFromVendor(IImage image)
+    public bool IsImageFromVendor(IImage image)
     {
         return image.Repository.Contains("apache") || image.Repository.Contains("bitnami");
     }
 
     /// <inheritdoc />
-    public override void Validate(KafkaConfiguration resourceConfiguration)
+    public void Validate(KafkaConfiguration resourceConfiguration)
     {
         const string message = "Local ZooKeeper is not supported for Apache Kafka images. Configure an external ZooKeeper.";
 
@@ -48,7 +48,7 @@ public override void Validate(KafkaConfiguration resourceConfiguration)
     }
 
     /// <inheritdoc />
-    public override string CreateStartupScript(KafkaConfiguration resourceConfiguration, KafkaContainer container)
+    public string CreateStartupScript(KafkaConfiguration resourceConfiguration, KafkaContainer container)
     {
         var additionalAdvertisedListeners = string.Join(",", container.AdvertisedListeners ?? Array.Empty<string>());
 

src/Testcontainers.Kafka/ConfluentConfiguration.cs

@@ -1,7 +1,7 @@
 namespace Testcontainers.Kafka;
 
-/// <inheritdoc cref="KafkaVendorConfiguration" />
-internal sealed class ConfluentConfiguration : KafkaVendorConfiguration
+/// <inheritdoc cref="IKafkaVendorConfiguration" />
+internal sealed class ConfluentConfiguration : IKafkaVendorConfiguration
 {
     static ConfluentConfiguration()
     {
@@ -17,25 +17,25 @@ private ConfluentConfiguration()
     /// <summary>
     /// Gets the singleton instance of the Confluent vendor configuration.
     /// </summary>
-    public static KafkaVendorConfiguration Instance { get; }
+    public static IKafkaVendorConfiguration Instance { get; }
         = new ConfluentConfiguration();
 
     /// <inheritdoc />
-    public override KafkaVendor Vendor
+    public KafkaVendor Vendor
         => KafkaVendor.Confluent;
 
     /// <inheritdoc />
-    public override ConsensusProtocol ConsensusProtocol
+    public ConsensusProtocol ConsensusProtocol
         => ConsensusProtocol.ZooKeeper;
 
     /// <inheritdoc />
-    public override bool IsImageFromVendor(IImage image)
+    public bool IsImageFromVendor(IImage image)
     {
         return image.Repository.Contains("confluentinc");
     }
 
     /// <inheritdoc />
-    public override void Validate(KafkaConfiguration resourceConfiguration)
+    public void Validate(KafkaConfiguration resourceConfiguration)
     {
         const string message = "KRaft is not supported for Confluent Platform images with versions earlier than 7.0.0.";
 
@@ -47,7 +47,7 @@ public override void Validate(KafkaConfiguration resourceConfiguration)
     }
 
     /// <inheritdoc />
-    public override string CreateStartupScript(KafkaConfiguration resourceConfiguration, KafkaContainer container)
+    public string CreateStartupScript(KafkaConfiguration resourceConfiguration, KafkaContainer container)
     {
         var additionalAdvertisedListeners = string.Join(",", container.AdvertisedListeners ?? Array.Empty<string>());
 

src/Testcontainers.Kafka/KafkaVendorConfiguration.cs renamed to src/Testcontainers.Kafka/IKafkaVendorConfiguration.cs

@@ -3,36 +3,36 @@ namespace Testcontainers.Kafka;
 /// <summary>
 /// Represents the configuration for a Kafka vendor.
 /// </summary>
-internal abstract class KafkaVendorConfiguration
+internal interface IKafkaVendorConfiguration
 {
     /// <summary>
     /// Gets the Kafka vendor.
     /// </summary>
-    public abstract KafkaVendor Vendor { get; }
+    public KafkaVendor Vendor { get; }
 
     /// <summary>
     /// Gets the consensus protocol.
     /// </summary>
-    public abstract ConsensusProtocol ConsensusProtocol { get; }
+    public ConsensusProtocol ConsensusProtocol { get; }
 
     /// <summary>
     /// Determines whether the specified Docker image belongs to this vendor.
     /// </summary>
     /// <param name="image">The Docker image.</param>
     /// <returns><c>true</c> if the image belongs to this vendor; otherwise, <c>false</c>.</returns>
-    public abstract bool IsImageFromVendor(IImage image);
+    public bool IsImageFromVendor(IImage image);
 
     /// <summary>
     /// Validates the resource configuration.
     /// </summary>
     /// <param name="resourceConfiguration">The resource configuration.</param>
-    public abstract void Validate(KafkaConfiguration resourceConfiguration);
+    public void Validate(KafkaConfiguration resourceConfiguration);
 
     /// <summary>
     /// Creates the startup script.
     /// </summary>
     /// <param name="resourceConfiguration">The resource configuration.</param>
     /// <param name="container">The Kafka container.</param>
     /// <returns>The startup script as a string.</returns>
-    public abstract string CreateStartupScript(KafkaConfiguration resourceConfiguration, KafkaContainer container);
+    public string CreateStartupScript(KafkaConfiguration resourceConfiguration, KafkaContainer container);
 }

src/Testcontainers.Kafka/KafkaBuilder.cs

@@ -22,7 +22,7 @@ public sealed class KafkaBuilder : ContainerBuilder<KafkaBuilder, KafkaContainer
 
     private const string ProtocolPrefix = "TC";
 
-    private static readonly KafkaVendorConfiguration[] VendorConfigurations = new[] { ApacheConfiguration.Instance, ConfluentConfiguration.Instance };
+    private static readonly IKafkaVendorConfiguration[] VendorConfigurations = new[] { ApacheConfiguration.Instance, ConfluentConfiguration.Instance };
 
     /// <summary>
     /// Initializes a new instance of the <see cref="KafkaBuilder" /> class.