-
Notifications
You must be signed in to change notification settings - Fork 159
feat: support Cypress 15 #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Cypress 15 #282
Conversation
What is the status on merging this? I'd like to migrate to cypress v15 |
Any chance to approve this PR? |
Can we get this merged and released as it is preventing people moving to cypress 15 |
I created another PR that resolve @MikeMcC399 comment as I am not sure if @AtofStryker is maintaining this PR if you are still please shout and ill close my one :) |
This comment was marked as resolved.
This comment was marked as resolved.
All good, I think it is just a concern that a maintainer approves the CI and it fails and we have to wait another while before it is run again this is just to mitigate if @AtofStryker updates his PR ill close mine |
This comment was marked as outdated.
This comment was marked as outdated.
No worries i did close the PR |
@MikeMcC399 that should be fine given that the min version is Cypress 12 on the package. I can go ahead and get this updated. likely want to add node support in the matrix as well. Hopefully a maintainer can look at this soon |
The workflow .github/workflows/validate.yml actually needs quite a bit of maintenance done on it to bring it up-to-date, as all of the actions it's using are old versions. The |
@MikeMcC399 good to know. I think starting small and see if we can get someone to take a look at this would be best. I did push up 9782734 to update the github actions node versions |
Are you the right person to ping to get this PR reviewed and merged? Or perhaps there are other maintainers for this repo? It will also need the branch protection rules updating to remove the Node.js 18 job as being required, since this version is in end-of-life and no longer supported by Cypress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I copied it and tested it in my fork 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really a maintainer anymore, but since it doesn't seem like there's anyone else I'll go ahead and merge this since it's pretty straightforward.
Awesome, thank you @kentcdodds |
🎉 This PR is included in version 10.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adds support for Cypress 15, which released on August 20th, 2025
What:
Why:
How:
Checklist: