Skip to content

Conversation

AtofStryker
Copy link
Contributor

Adds support for Cypress 15, which released on August 20th, 2025

What:

Why:

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@stealthrabbi
Copy link

What is the status on merging this? I'd like to migrate to cypress v15

@h2oearth
Copy link

h2oearth commented Sep 1, 2025

Any chance to approve this PR?

@Archangelza1
Copy link

Can we get this merged and released as it is preventing people moving to cypress 15

MikeMcC399

This comment was marked as resolved.

@Archangelza1
Copy link

I created another PR that resolve @MikeMcC399 comment as I am not sure if @AtofStryker is maintaining this PR if you are still please shout and ill close my one :)

@MikeMcC399

This comment was marked as resolved.

@Archangelza1
Copy link

@Archangelza1

I created another PR that resolve @MikeMcC399 comment as I am not sure if @AtofStryker is maintaining this PR if you are still please shout and ill close my one :)

I don't think that adding a new PR will speed things up . I expect the hold up is going to be getting maintainer attention. Your PR #285 is also held up waiting for maintainer approval to run the workflow.

All good, I think it is just a concern that a maintainer approves the CI and it fails and we have to wait another while before it is run again this is just to mitigate if @AtofStryker updates his PR ill close mine

@MikeMcC399

This comment was marked as outdated.

@Archangelza1
Copy link

@Archangelza1

All good, I think it is just a concern that a maintainer approves the CI and it fails and we have to wait another while before it is run again this is just to mitigate if @AtofStryker updates his PR ill close mine

Bear in mind that I left my comment yesterday, Mon Sep 1, 2025, and this day was a federal holiday across the whole of the United States of America, so there have been zero available USA business hours for a reaction.

No worries i did close the PR

@AtofStryker
Copy link
Contributor Author

@AtofStryker

This PR is going to fail in CI as soon as a maintainer approves your workflow. (I copied it and ran it locally in my fork to check.)

To fix this issue, .github/workflows/validate.yml would need to be modified to drop Node.js 18:

Reference for other readers:

@MikeMcC399 that should be fine given that the min version is Cypress 12 on the package. I can go ahead and get this updated. likely want to add node support in the matrix as well. Hopefully a maintainer can look at this soon

@MikeMcC399
Copy link
Contributor

@AtofStryker

that should be fine given that the min version is Cypress 12 on the package. I can go ahead and get this updated. likely want to > add node support in the matrix as well. Hopefully a maintainer can look at this soon

The workflow .github/workflows/validate.yml actually needs quite a bit of maintenance done on it to bring it up-to-date, as all of the actions it's using are old versions. The release job also provokes a deprecation warning about set-output. I would offer to clean that up in a separate PR. It would of course need a maintainer to review and merge. Reading between the lines, it seems that @kentcdodds is the sole maintainer here, but I could be mistaken. Perhaps you'd like to ping him when your PR is ready? I'm afraid that there isn't much active maintainer monitoring going on here at the moment.

@AtofStryker
Copy link
Contributor Author

@AtofStryker

that should be fine given that the min version is Cypress 12 on the package. I can go ahead and get this updated. likely want to > add node support in the matrix as well. Hopefully a maintainer can look at this soon

The workflow .github/workflows/validate.yml actually needs quite a bit of maintenance done on it to bring it up-to-date, as all of the actions it's using are old versions. The release job also provokes a deprecation warning about set-output. I would offer to clean that up in a separate PR. It would of course need a maintainer to review and merge. Reading between the lines, it seems that @kentcdodds is the sole maintainer here, but I could be mistaken. Perhaps you'd like to ping him when your PR is ready? I'm afraid that there isn't much active maintainer monitoring going on here at the moment.

@MikeMcC399 good to know. I think starting small and see if we can get someone to take a look at this would be best. I did push up 9782734 to update the github actions node versions

@MikeMcC399
Copy link
Contributor

@kentcdodds

Are you the right person to ping to get this PR reviewed and merged? Or perhaps there are other maintainers for this repo?

It will also need the branch protection rules updating to remove the Node.js 18 job as being required, since this version is in end-of-life and no longer supported by Cypress.

Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I copied it and tested it in my fork 👍🏻

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really a maintainer anymore, but since it doesn't seem like there's anyone else I'll go ahead and merge this since it's pretty straightforward.

@h2oearth
Copy link

h2oearth commented Sep 2, 2025

I'm not really a maintainer anymore, but since it doesn't seem like there's anyone else I'll go ahead and merge this since it's pretty straightforward.

Awesome, thank you @kentcdodds

@kentcdodds kentcdodds merged commit e6ac135 into testing-library:main Sep 2, 2025
4 checks passed
Copy link

github-actions bot commented Sep 2, 2025

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants