Skip to content

Commit 9b90f0a

Browse files
y-hsgwy-hsgw
committed
test: remove unnecessary waitFor calls
1 parent e277165 commit 9b90f0a

File tree

1 file changed

+48
-44
lines changed

1 file changed

+48
-44
lines changed

‎tests/lib/rules/no-wait-for-side-effects.test.ts‎

Lines changed: 48 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -387,8 +387,6 @@ ruleTester.run(RULE_NAME, rule, {
387387
output: `
388388
import { waitFor } from '${testingFramework}';
389389
render(<App />)
390-
await waitFor(function() {
391-
})
392390
`,
393391
},
394392
{
@@ -402,8 +400,6 @@ ruleTester.run(RULE_NAME, rule, {
402400
output: `
403401
import { waitFor } from '${testingFramework}';
404402
render(<App />)
405-
waitFor(function() {
406-
})
407403
`,
408404
},
409405
{
@@ -417,8 +413,6 @@ ruleTester.run(RULE_NAME, rule, {
417413
output: `
418414
import { waitFor } from '${testingFramework}';
419415
const { container } = renderHelper(<App />)
420-
await waitFor(function() {
421-
})
422416
`,
423417
},
424418
{
@@ -449,8 +443,6 @@ ruleTester.run(RULE_NAME, rule, {
449443
import { waitFor } from '${testingFramework}';
450444
import { renderHelper } from 'somewhere-else';
451445
renderHelper(<App />)
452-
await waitFor(() => {
453-
})
454446
`,
455447
},
456448
{
@@ -467,8 +459,6 @@ ruleTester.run(RULE_NAME, rule, {
467459
import { waitFor } from '${testingFramework}';
468460
import { renderHelper } from 'somewhere-else';
469461
const { container } = renderHelper(<App />)
470-
await waitFor(() => {
471-
})
472462
`,
473463
},
474464
{
@@ -487,8 +477,6 @@ ruleTester.run(RULE_NAME, rule, {
487477
import { renderHelper } from 'somewhere-else';
488478
let container;
489479
({ container } = renderHelper(<App />))
490-
await waitFor(() => {
491-
})
492480
`,
493481
},
494482
{
@@ -602,8 +590,6 @@ ruleTester.run(RULE_NAME, rule, {
602590
output: `
603591
import { waitFor } from '${testingFramework}';
604592
render(<App />)
605-
await waitFor(() => {
606-
})
607593
`,
608594
},
609595
{
@@ -617,8 +603,6 @@ ruleTester.run(RULE_NAME, rule, {
617603
output: `
618604
import { waitFor } from '${testingFramework}';
619605
const { container } = render(<App />)
620-
await waitFor(() => {
621-
})
622606
`,
623607
},
624608
{
@@ -632,8 +616,6 @@ ruleTester.run(RULE_NAME, rule, {
632616
output: `
633617
import { waitFor } from '${testingFramework}';
634618
result = render(<App />)
635-
await waitFor(() => {
636-
})
637619
`,
638620
},
639621
{
@@ -657,8 +639,6 @@ ruleTester.run(RULE_NAME, rule, {
657639
import { waitFor } from '${testingFramework}';
658640
const a = 5,
659641
{ container } = render(<App />)
660-
await waitFor(() => {
661-
})
662642
`,
663643
},
664644
{
@@ -674,8 +654,6 @@ ruleTester.run(RULE_NAME, rule, {
674654
import { waitFor } from '${testingFramework}';
675655
const { rerender } = render(<App />)
676656
rerender(<App />)
677-
await waitFor(() => {
678-
})
679657
`,
680658
},
681659
{
@@ -702,8 +680,6 @@ ruleTester.run(RULE_NAME, rule, {
702680
import { waitFor } from '${testingFramework}';
703681
render(<App />)
704682
fireEvent.keyDown(input, {key: 'ArrowDown'})
705-
await waitFor(() => {
706-
})
707683
`,
708684
],
709685
},
@@ -731,8 +707,6 @@ ruleTester.run(RULE_NAME, rule, {
731707
import { waitFor } from '${testingFramework}';
732708
render(<App />)
733709
userEvent.click(button)
734-
await waitFor(() => {
735-
})
736710
`,
737711
],
738712
},
@@ -777,8 +751,6 @@ ruleTester.run(RULE_NAME, rule, {
777751
output: `
778752
import { waitFor } from '${testingFramework}';
779753
fireEvent.keyDown(input, {key: 'ArrowDown'})
780-
await waitFor(() => {
781-
})
782754
`,
783755
},
784756
{
@@ -792,8 +764,6 @@ ruleTester.run(RULE_NAME, rule, {
792764
output: `
793765
import { waitFor, fireEvent as renamedFireEvent } from '${testingFramework}';
794766
renamedFireEvent.keyDown(input, {key: 'ArrowDown'})
795-
await waitFor(() => {
796-
})
797767
`,
798768
},
799769
]
@@ -810,8 +780,6 @@ ruleTester.run(RULE_NAME, rule, {
810780
output: `
811781
import { waitFor, fireEvent } from '~/test-utils';
812782
fireEvent.keyDown(input, {key: 'ArrowDown'})
813-
await waitFor(() => {
814-
})
815783
`,
816784
},
817785
...SUPPORTED_TESTING_FRAMEWORKS.flatMap<RuleInvalidTestCase>(
@@ -861,8 +829,6 @@ ruleTester.run(RULE_NAME, rule, {
861829
output: `
862830
import { waitFor } from '${testingFramework}';
863831
fireEvent.keyDown(input, {key: 'ArrowDown'})
864-
await waitFor(function() {
865-
})
866832
`,
867833
},
868834
{
@@ -926,8 +892,6 @@ ruleTester.run(RULE_NAME, rule, {
926892
output: `
927893
import { waitFor } from '${testingFramework}';
928894
userEvent.click(button)
929-
await waitFor(() => {
930-
})
931895
`,
932896
},
933897
{
@@ -943,8 +907,6 @@ ruleTester.run(RULE_NAME, rule, {
943907
import { waitFor } from '${testingFramework}';
944908
import renamedUserEvent from '@testing-library/user-event'
945909
renamedUserEvent.click(button)
946-
await waitFor(() => {
947-
})
948910
`,
949911
},
950912
]
@@ -963,8 +925,6 @@ ruleTester.run(RULE_NAME, rule, {
963925
import { waitFor } from '~/test-utils';
964926
import userEvent from '@testing-library/user-event'
965927
userEvent.click();
966-
await waitFor(() => {
967-
})
968928
`,
969929
},
970930
...SUPPORTED_TESTING_FRAMEWORKS.flatMap<RuleInvalidTestCase>(
@@ -1014,8 +974,6 @@ ruleTester.run(RULE_NAME, rule, {
1014974
output: `
1015975
import { waitFor } from '${testingFramework}';
1016976
userEvent.click(button)
1017-
await waitFor(function() {
1018-
})
1019977
`,
1020978
},
1021979
{
@@ -1215,7 +1173,55 @@ ruleTester.run(RULE_NAME, rule, {
12151173
const a = userEvent.click(button);
12161174
const b = fireEvent.click(button);
12171175
const wrapper = render(<App />);
1176+
`,
1177+
],
1178+
},
1179+
{
1180+
// Issue #368, https://github.com/testing-library/eslint-plugin-testing-library/issues/368
1181+
code: `
1182+
import { waitFor } from '${testingFramework}';
1183+
import userEvent from '@testing-library/user-event'
12181184
await waitFor(() => {
1185+
const a = userEvent.click(button);
1186+
const b = fireEvent.click(button);
1187+
const c = "hoge";
1188+
const wrapper = render(<App />);
1189+
})
1190+
`,
1191+
errors: [
1192+
{ line: 5, column: 11, messageId: 'noSideEffectsWaitFor' },
1193+
{ line: 6, column: 11, messageId: 'noSideEffectsWaitFor' },
1194+
{ line: 8, column: 11, messageId: 'noSideEffectsWaitFor' },
1195+
],
1196+
output: [
1197+
`
1198+
import { waitFor } from '${testingFramework}';
1199+
import userEvent from '@testing-library/user-event'
1200+
const a = userEvent.click(button);
1201+
await waitFor(() => {
1202+
const b = fireEvent.click(button);
1203+
const c = "hoge";
1204+
const wrapper = render(<App />);
1205+
})
1206+
`,
1207+
`
1208+
import { waitFor } from '${testingFramework}';
1209+
import userEvent from '@testing-library/user-event'
1210+
const a = userEvent.click(button);
1211+
const b = fireEvent.click(button);
1212+
await waitFor(() => {
1213+
const c = "hoge";
1214+
const wrapper = render(<App />);
1215+
})
1216+
`,
1217+
`
1218+
import { waitFor } from '${testingFramework}';
1219+
import userEvent from '@testing-library/user-event'
1220+
const a = userEvent.click(button);
1221+
const b = fireEvent.click(button);
1222+
const wrapper = render(<App />);
1223+
await waitFor(() => {
1224+
const c = "hoge";
12191225
})
12201226
`,
12211227
],
@@ -1243,8 +1249,6 @@ ruleTester.run(RULE_NAME, rule, {
12431249
12441250
it("some test", async () => {
12451251
await fireEvent.click(screen.getByTestId("something"));
1246-
await waitFor(async () => {
1247-
});
12481252
});
12491253
`,
12501254
},

0 commit comments

Comments
 (0)