From e4dd6b29cad3bed236f8ea17f032a3e7d713e879 Mon Sep 17 00:00:00 2001 From: Jeroen Ooms Date: Thu, 28 Aug 2025 13:16:50 +0200 Subject: [PATCH 1/2] Fix unit tests. I think this is what was intended. --- tests/testthat/test-form.R | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/testthat/test-form.R b/tests/testthat/test-form.R index dca259fd..1293d93e 100644 --- a/tests/testthat/test-form.R +++ b/tests/testthat/test-form.R @@ -32,7 +32,7 @@ test_that("has useful print method", { test_that("select options are named character vector", { - select <- minimal_html("select parsing", ' + select <- minimal_html('
@@ -58,7 +58,7 @@ test_that("select values are inherited from names", { }) test_that("parse_fields gets the button", { - select <- minimal_html("button test", ' + select <- minimal_html('
@@ -77,7 +77,7 @@ test_that("handles different encoding types", { }) test_that("validates its inputs", { - select <- minimal_html("button test", ' + select <- minimal_html('
From 09709d098201de92ab276d35f2f65f5b4e97712d Mon Sep 17 00:00:00 2001 From: Jeroen Ooms Date: Fri, 22 Aug 2025 20:15:57 +0200 Subject: [PATCH 2/2] Test on some more platforms with different libxml2 versions. --- .github/workflows/distros.yml | 38 +++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 .github/workflows/distros.yml diff --git a/.github/workflows/distros.yml b/.github/workflows/distros.yml new file mode 100644 index 00000000..abd34b02 --- /dev/null +++ b/.github/workflows/distros.yml @@ -0,0 +1,38 @@ +name: Distros + +on: + push: + branches: [main, master] + pull_request: + branches: [main, master] + +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + +jobs: + rhel: + runs-on: ubuntu-24.04${{matrix.arch=='arm64' && '-arm' || ''}} + name: ${{ matrix.distro }} ${{ matrix.arch }} + strategy: + fail-fast: false + matrix: + distro: [ 'rocky-8', 'rocky-9', 'debian-13', 'debian-14'] + arch: [ 'amd64', 'arm64' ] + container: + image: ghcr.io/r-devel/${{ matrix.distro }}:latest + steps: + - uses: actions/checkout@v4 + + - uses: r-lib/actions/setup-r-dependencies@v2 + with: + extra-packages: any::rcmdcheck + needs: check + + - uses: r-lib/actions/check-r-package@v2 + with: + args: '"--no-manual"' + env: + NOT_CRAN: false + _R_CHECK_DOC_SIZES_: FALSE + LANG: en_US.UTF-8