Duplicate tolerations in kube-controllers deployment

[wedaly]

Tigera-operator currently appends c.cfg.Installation.ControlPlaneTolerations with rmeta.TolerateCriticalAddonsAndControlPlane in the kube-controllers deployment:

operator/pkg/render/kubecontrollers/kube-controllers.go

Line 636 in ed26c42

tolerations := append(c.cfg.Installation.ControlPlaneTolerations, rmeta.TolerateCriticalAddonsAndControlPlane...)

When the installation ControlPlaneTolerations includes CriticalAddonsOnly, the toleration is duplicated, which can cause errors in Prometheus as reported in Azure/AKS#4282

[caseydavenport]

xref a similar issue: projectcalico/calico#8371

[github-actions]

This issue is stale because it has been open for 30 days with no activity.