Skip to content

Commit 3bf002e

Browse files
committed
tweaks
1 parent 7c1fd47 commit 3bf002e

File tree

3 files changed

+47
-1
lines changed

3 files changed

+47
-1
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ node cli.js \
1313
-T ghp_0123456789abcdefghijABCDEFGHIJabcdefgh \
1414
--octoherd-bypass-confirms true \
1515
--library @time-loop/cdk-ecs-fargate \
16-
--versionRequirement \>=5.15.2
16+
--versionRequirement \>=5.15.2 | \
17+
tee raw.txt | grep NOT | sort | tee non-compliant.txt && wc -l non-compliant.txt
1718
```
1819

1920
## Options

UPGRADING_PROJEN.md

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
2+
# Upgrading Projen
3+
4+
## GitHub Actions Breaking Change
5+
6+
GitHub recently decided to push a breaking change to the `upload-artifact` action, while violating semver.
7+
This wreaked havoc on our CI/CD pipelines.
8+
So... we had to manually upgrade projen using the following steps
9+
10+
```bash
11+
git co main
12+
git pull --ff-only
13+
git co -b github-actions/update-projen-main
14+
15+
pnpm i && pnpm update-projen
16+
17+
git add . && git commit -m "fix(deps): upgrade projen [INFRA-23096]\n\nPick up projen fix to GitHub Actions breaking change. Related GH issue: https://github.com/actions/upload-artifact/issues/602 . Related slack thread is here: https://clickup.enterprise.slack.com/archives/C03F94339PV/p1725475644645509\n"
18+
19+
# If you're lucky, there's a pre-existing PR you can overwrite.
20+
git push --force
21+
gh pr view --web
22+
23+
# Otherwise...
24+
#gh pr create --assignee @me --reviewer @time-loop/cloud-platform --fill && gh pr merge --squash --auto
25+
```
26+
27+
### IntegRunner Test Failures
28+
29+
First of all, we had an issue with older versions of integrunner crashing when running the test suite.
30+
Fix here was to upgrade `cdkVersion` to latest.
31+
32+
Once they're running, you can see snapshot changes triggering failures (which is expected).
33+
Fix here is to update snapshot files. And of course, ensure that it's an intended change.
34+
35+
```bash
36+
npx projen integ:update --parallel-regions us-west-2
37+
```
38+
39+
We currently run our integ tests in `us-west-2`.
40+
Without specifying the `--parallel-regions` flag, the command will try running tests in multiple regions.
41+
Which... will fail.
42+
43+
Anyway, that should generate a bunch of new snapshot files, commit and push.

script.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ export async function script(
5555
return;
5656
}
5757

58+
// @ts-ignore - Buffer is available in Node.js
5859
const pnpmBuffer = Buffer.from(pnpmFile.content, 'base64').toString(
5960
'ascii'
6061
);
@@ -97,6 +98,7 @@ export async function script(
9798
}
9899

99100
// Parse out the contents
101+
// @ts-ignore - Buffer is available in Node.js
100102
const buffer = Buffer.from(yarnFile.content, 'base64').toString('ascii');
101103
const yarnLock = lockfile.parse(buffer);
102104

0 commit comments

Comments
 (0)