Allow selecting pre-written BarGlyph’s by a symbol name, add two Gray code sequences #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Nice! All this needs is a test. |
Adds two bar glyph sequences based on Gray codes on quarter-blocks and braille characters in Unicode.
Author
|
Sorry, forgot about this. Tests added |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
==========================================
+ Coverage 93.48% 96.51% +3.03%
==========================================
Files 1 1
Lines 399 574 +175
==========================================
+ Hits 373 554 +181
+ Misses 26 20 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two bar glyph sequences based on Gray codes on quarter-blocks and
braille characters in Unicode.
This pr contains no proper feature improvements, I just thought it was a cool concept from Knuth's art of computer programming, volume 4, and it makes for a pretty progress bar.