builder/createInlineAsm:with independant logic to avoid goto operate

Author: luoliwoshang

compiler/inlineasm.go

@@ -29,6 +29,35 @@ func (b *builder) createInlineAsm(args []ssa.Value) (llvm.Value, error) {
 	return b.CreateCall(fnType, target, nil, ""), nil
 }
 
+// collectInlineAsmRegisters extracts register values from the map referrers,
+// stopping when it encounters the AsmFull call itself to avoid processing
+// MapUpdate operations that happen after the call.
+func (b *builder) collectInlineAsmRegisters(instr *ssa.CallCommon, registerMap *ssa.MakeMap) (map[string]llvm.Value, error) {
+	registers := map[string]llvm.Value{}
+	for _, r := range *registerMap.Referrers() {
+		switch r := r.(type) {
+		case *ssa.DebugRef:
+			// ignore
+		case *ssa.MapUpdate:
+			if r.Block() != registerMap.Block() {
+				return nil, b.makeError(instr.Pos(), "register value map must be created in the same basic block")
+			}
+			key := constant.StringVal(r.Key.(*ssa.Const).Value)
+			registers[key] = b.getValue(r.Value.(*ssa.MakeInterface).X, getPos(instr))
+		case *ssa.Call:
+			if r.Common() == instr {
+				// Stop processing when we encounter the AsmFull call itself
+				// to avoid including MapUpdate operations that happen after the call
+				return registers, nil
+			}
+		default:
+			return nil, b.makeError(instr.Pos(), "don't know how to handle argument to inline assembly: "+r.String())
+		}
+	}
+
+	return registers, nil
+}
+
 // This is a compiler builtin, which allows assembly to be called in a flexible
 // way.
 //
@@ -46,28 +75,13 @@ func (b *builder) createInlineAsm(args []ssa.Value) (llvm.Value, error) {
 func (b *builder) createInlineAsmFull(instr *ssa.CallCommon) (llvm.Value, error) {
 	asmString := constant.StringVal(instr.Args[0].(*ssa.Const).Value)
 	registers := map[string]llvm.Value{}
+
 	if registerMap, ok := instr.Args[1].(*ssa.MakeMap); ok {
-		for _, r := range *registerMap.Referrers() {
-			switch r := r.(type) {
-			case *ssa.DebugRef:
-				// ignore
-			case *ssa.MapUpdate:
-				if r.Block() != registerMap.Block() {
-					return llvm.Value{}, b.makeError(instr.Pos(), "register value map must be created in the same basic block")
-				}
-				key := constant.StringVal(r.Key.(*ssa.Const).Value)
-				registers[key] = b.getValue(r.Value.(*ssa.MakeInterface).X, getPos(instr))
-			case *ssa.Call:
-				if r.Common() == instr {
-					// Stop processing when we encounter the AsmFull call itself
-					// to avoid including MapUpdate operations that happen after the call
-					goto done
-				}
-			default:
-				return llvm.Value{}, b.makeError(instr.Pos(), "don't know how to handle argument to inline assembly: "+r.String())
-			}
+		var err error
+		registers, err = b.collectInlineAsmRegisters(instr, registerMap)
+		if err != nil {
+			return llvm.Value{}, err
 		}
-	done:
 	}
 	// TODO: handle dollar signs in asm string
 	registerNumbers := map[string]int{}