-
-
Notifications
You must be signed in to change notification settings - Fork 5k
toolbox*: update project name #19769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The project was renamed to "Toolbx" to improve searchability back in 2021: <containers/containertoolbx.org#1> The command name and a few other places (environment variables, runtime paths, etc.) kept the previous name for backward compatibility, but otherwise the new name is to be used: <containers/toolbox#1446>
|
@waldyrious tldr-bot has listed some issues with these pages. Can you run the script to at least update the links for the translations? (Comment edited by @waldyrious to avoid quoting the long output by tldr-bot.) |
Co-authored-by: Darío Hereñú <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
@sebastiaanspeck Running the script is proving to be challenging. I tried to do Btw, I noticed out that the out-of-sync issues (regarding the more information link) were caused by #19678 — I wonder, why didn't tldr-bot comment there? 🤔 |
Can you maybe run the script completely and only commit the files that are already in this PR?
Because that PR didn't touch the translations 😄 |
I could, but it didn't occur to me, and now I already did the change by hand 😅 But I'll keep that in mind for next time!
Oh! That seems like a point to be improved, then. IMHO the PR that makes the modification to the English page is where the bot should raise the issue of outdated translations, rather than subsequent PRs that touch those translated files to do unrelated changes. |
My goal is to pester translations as little as possible. I'm currently waiting for systemd to do a version bump on their documentations, update systemctl anchors and then run the script on the whole project. |
I disagree on this. If you get bothered for every English page that you outdate a translation (of a language you probably don't speak) feels very contra-productive. For this case we have tldr-maintenance in which maintainers of a specific language can see which pages need attention. If you touch the translation in a PR that is the moment you want to draw attention. |
Fair point 👍
So, here I tend to disagree for the same reason: we'd be bothering contributors that modify a translation page, asking them to fix issues they didn't cause, and that they're not responsible for fixing. On the other hand, it does make sense that someone who modified a translation is likely to have the knowledge required to perform the fixes. Perhaps a compromise could be to trigger the bot's message only if the PR is exclusively modifying pages in a single language, since that gives a stronger signal that the author is indeed knowledgeable on that particular language and not merely performing a mechanical fix (as was the case here). The bot could also be made to show the "more information out of sync" warnings in all cases, since those are easy fixes for anyone regardless of language proficiency, and the "page out of date" warnings only in single-language PRs. WDYT? |
Feel free to give it a shot :) |
The project was renamed to "Toolbx" to improve searchability back in 2021:
containers/containertoolbx.org#1
The command name and a few other places (environment variables, runtime paths, etc.)
kept the previous name for backward compatibility, but otherwise the new name is to be used:
containers/toolbox#1446
Checklist
common,linux,osx,windows,sunos,android, etc.