Skip to content

Conversation

@waldyrious
Copy link
Member

The project was renamed to "Toolbx" to improve searchability back in 2021:
containers/containertoolbx.org#1

The command name and a few other places (environment variables, runtime paths, etc.)
kept the previous name for backward compatibility, but otherwise the new name is to be used:
containers/toolbox#1446

Checklist

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR contains at most 5 new pages.
  • The PR is authored by me, or has been human-reviewed if it was created with AI or machine translation software.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):
  • Reference issue: #

The project was renamed to "Toolbx" to improve searchability back in 2021:
<containers/containertoolbx.org#1>

The command name and a few other places (environment variables, runtime paths, etc.)
kept the previous name for backward compatibility, but otherwise the new name is to be used:
<containers/toolbox#1446>
@github-actions github-actions bot added mass changes Changes that affect multiple pages. page edit Changes to an existing page(s). translation edit Changes to an existing translation page(s). labels Dec 6, 2025
@sebastiaanspeck
Copy link
Member

sebastiaanspeck commented Dec 7, 2025

@waldyrious tldr-bot has listed some issues with these pages.

Can you run the script to at least update the links for the translations?

(Comment edited by @waldyrious to avoid quoting the long output by tldr-bot.)

@tldr-bot

This comment has been minimized.

@waldyrious
Copy link
Member Author

@sebastiaanspeck Running the script is proving to be challenging. I tried to do python3 scripts/set-more-info-link.py -p linux/toolbox.md -S but it seems the script is unable to process both the -p and -S options at the same time. And even if it did support that usage, I'd need to run it several times to modify the various English pages modified in this PR. So I ended up performing the fixes by hand.

Btw, I noticed out that the out-of-sync issues (regarding the more information link) were caused by #19678 — I wonder, why didn't tldr-bot comment there? 🤔

@sebastiaanspeck
Copy link
Member

@sebastiaanspeck Running the script is proving to be challenging. I tried to do python3 scripts/set-more-info-link.py -p linux/toolbox.md -S but it seems the script is unable to process both the -p and -S options at the same time. And even if it did support that usage, I'd need to run it several times to modify the various English pages modified in this PR. So I ended up performing the fixes by hand.

Can you maybe run the script completely and only commit the files that are already in this PR?

Btw, I noticed out that the out-of-sync issues (regarding the more information link) were caused by #19678 — I wonder, why didn't tldr-bot comment there? 🤔

Because that PR didn't touch the translations 😄

@waldyrious
Copy link
Member Author

Can you maybe run the script completely and only commit the files that are already in this PR?

I could, but it didn't occur to me, and now I already did the change by hand 😅 But I'll keep that in mind for next time!

Btw, I noticed out that the out-of-sync issues (regarding the more information link) were caused by #19678 — I wonder, why didn't tldr-bot comment there? 🤔

Because that PR didn't touch the translations 😄

Oh! That seems like a point to be improved, then. IMHO the PR that makes the modification to the English page is where the bot should raise the issue of outdated translations, rather than subsequent PRs that touch those translated files to do unrelated changes.

@Managor
Copy link
Member

Managor commented Dec 8, 2025

Because that PR didn't touch the translations 😄

My goal is to pester translations as little as possible. I'm currently waiting for systemd to do a version bump on their documentations, update systemctl anchors and then run the script on the whole project.

@sebastiaanspeck
Copy link
Member

Btw, I noticed out that the out-of-sync issues (regarding the more information link) were caused by #19678 — I wonder, why didn't tldr-bot comment there? 🤔

Because that PR didn't touch the translations 😄

Oh! That seems like a point to be improved, then. IMHO the PR that makes the modification to the English page is where the bot should raise the issue of outdated translations, rather than subsequent PRs that touch those translated files to do unrelated changes.

I disagree on this. If you get bothered for every English page that you outdate a translation (of a language you probably don't speak) feels very contra-productive. For this case we have tldr-maintenance in which maintainers of a specific language can see which pages need attention. If you touch the translation in a PR that is the moment you want to draw attention.

@waldyrious
Copy link
Member Author

If you get bothered for every English page that you outdate a translation (of a language you probably don't speak) feels very contra-productive.

Fair point 👍

If you touch the translation in a PR that is the moment you want to draw attention.

So, here I tend to disagree for the same reason: we'd be bothering contributors that modify a translation page, asking them to fix issues they didn't cause, and that they're not responsible for fixing. On the other hand, it does make sense that someone who modified a translation is likely to have the knowledge required to perform the fixes.

Perhaps a compromise could be to trigger the bot's message only if the PR is exclusively modifying pages in a single language, since that gives a stronger signal that the author is indeed knowledgeable on that particular language and not merely performing a mechanical fix (as was the case here).

The bot could also be made to show the "more information out of sync" warnings in all cases, since those are easy fixes for anyone regardless of language proficiency, and the "page out of date" warnings only in single-language PRs.

WDYT?

@sebastiaanspeck
Copy link
Member

If you get bothered for every English page that you outdate a translation (of a language you probably don't speak) feels very contra-productive.

Fair point 👍

If you touch the translation in a PR that is the moment you want to draw attention.

So, here I tend to disagree for the same reason: we'd be bothering contributors that modify a translation page, asking them to fix issues they didn't cause, and that they're not responsible for fixing. On the other hand, it does make sense that someone who modified a translation is likely to have the knowledge required to perform the fixes.

Perhaps a compromise could be to trigger the bot's message only if the PR is exclusively modifying pages in a single language, since that gives a stronger signal that the author is indeed knowledgeable on that particular language and not merely performing a mechanical fix (as was the case here).

The bot could also be made to show the "more information out of sync" warnings in all cases, since those are easy fixes for anyone regardless of language proficiency, and the "page out of date" warnings only in single-language PRs.

WDYT?

Feel free to give it a shot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mass changes Changes that affect multiple pages. page edit Changes to an existing page(s). translation edit Changes to an existing translation page(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants