Skip to content

Conversation

@themighty1
Copy link
Member

@themighty1 themighty1 commented Jul 24, 2025

This PR fixes problems related to running browser benches reliably.

  • restart RPC server periodically to avoid OOM (see explanation below)
  • disables registering a tracing subscriber in the wasm build
  • increase timeout for long running benches
  • dont log a non-critical chrome debug protocol error

Depends on: #945

Memory leak

The memory leak can be seen on the below screenshots taken a few minutes apart. The memory grows until 4GB and then an oom panic happens. Chrome memory profiling tools suggested that at the time of the panic, 4GB of memory was retained by wasm-bindgen's CLOSURE_DTORS.

2GB 3GB

@themighty1 themighty1 requested a review from heeckhau July 24, 2025 11:09
@themighty1
Copy link
Member Author

Some of the issues raised here were addressed in separate PRs.
For the remaining issues I opened a fresh PR to keep things clean #962

@themighty1 themighty1 closed this Aug 12, 2025
@themighty1 themighty1 deleted the fix/harness_browser_fixes branch August 26, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants