Fixing array_filter() that was too bread with 0 as a version number

Author: lstrojny

php/src/UAParser/Result/AbstractVersionedSoftware.php

@@ -23,6 +23,6 @@ public function toString()
     /** @return string */
     protected function formatVersion()
     {
-        return join('.', array_filter(func_get_args()));
+        return join('.', array_filter(func_get_args(), 'is_numeric'));
     }
 }

php/tests/UAParser/Tests/Result/OperatingSystemTest.php

@@ -0,0 +1,33 @@
+<?php
+/**
+ * ua-parser
+ *
+ * Copyright (c) 2011-2012 Dave Olsen, http://dmolsen.com
+ *
+ * Released under the MIT license
+ */
+namespace UAParser\Tests\Result;
+
+use PHPUnit_Framework_TestCase as AbstractTestCase;
+use UAParser\Result\UserAgent;
+
+class UserAgentTest extends AbstractTestCase
+{
+    /** @var UserAgent */
+    private $userAgent;
+
+    public function setUp()
+    {
+        $this->userAgent = new UserAgent();
+    }
+
+    public function testBugWith0InVersion()
+    {
+        $this->userAgent->major = 0;
+        $this->userAgent->minor = 0;
+        $this->userAgent->patch = 0;
+
+        $this->assertSame('0.0.0', $this->userAgent->toVersion());
+        $this->assertSame('Other 0.0.0', $this->userAgent->toString());
+    }
+}

php/tests/UAParser/Tests/Result/UserAgentTest.php

@@ -0,0 +1,34 @@
+<?php
+/**
+ * ua-parser
+ *
+ * Copyright (c) 2011-2012 Dave Olsen, http://dmolsen.com
+ *
+ * Released under the MIT license
+ */
+namespace UAParser\Tests\Result;
+
+use PHPUnit_Framework_TestCase as AbstractTestCase;
+use UAParser\Result\OperatingSystem;
+
+class OperatingSystemTest extends AbstractTestCase
+{
+    /** @var OperatingSystem */
+    private $operatingSystem;
+
+    public function setUp()
+    {
+        $this->operatingSystem = new OperatingSystem();
+    }
+
+    public function testBugWith0InVersion()
+    {
+        $this->operatingSystem->major = 0;
+        $this->operatingSystem->minor = 0;
+        $this->operatingSystem->patch = 0;
+        $this->operatingSystem->patchMinor = 0;
+
+        $this->assertSame('0.0.0.0', $this->operatingSystem->toVersion());
+        $this->assertSame('Other 0.0.0.0', $this->operatingSystem->toString());
+    }
+}