Skip to content

Commit 3d47409

Browse files
authored
add get token request result call (#143)
1 parent e79a0b6 commit 3d47409

File tree

7 files changed

+29
-17
lines changed

7 files changed

+29
-17
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "token-io",
3-
"version": "1.5.19",
3+
"version": "1.5.20",
44
"description": "",
55
"main": "dist/token-io.min.js",
66
"scripts": {

src/http/AuthHttpClient.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1294,16 +1294,18 @@ class AuthHttpClient {
12941294
/**
12951295
* Sign with a Token signature a token request state payload.
12961296
*
1297+
* @param {string} tokenRequestId - token request id
12971298
* @param {string} tokenId - token id
12981299
* @param {string} state - url state
12991300
* @return {Object} response - response to the api call
13001301
*/
1301-
async signTokenRequestState(tokenId, state) {
1302+
async signTokenRequestState(tokenRequestId, tokenId, state) {
13021303
const req = {
13031304
payload: {
13041305
tokenId,
13051306
state,
13061307
},
1308+
tokenRequestId
13071309
};
13081310

13091311
const request = {

src/http/HttpClient.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -319,15 +319,15 @@ class HttpClient {
319319
}
320320

321321
/**
322-
* Get a token ID based on its token request ID.
322+
* Get the token request result based on its token request ID.
323323
*
324324
* @param {string} tokenRequestId - token request id
325325
* @return {Object} response - response to the API call
326326
*/
327-
async getTokenId(tokenRequestId) {
327+
async getTokenRequestResult(tokenRequestId) {
328328
const request = {
329329
method: 'get',
330-
url: `/token-requests/${tokenRequestId}/token_id`
330+
url: `/token-requests/${tokenRequestId}/token_request_result`
331331
};
332332
return this._instance(request);
333333
}

src/main/Member.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,13 +1025,14 @@ export default class Member {
10251025
/**
10261026
* Sign with a Token signature a token request state payload.
10271027
*
1028+
* @param {string} tokenRequestId - token request id
10281029
* @param {string} tokenId - token id
10291030
* @param {string} state - url state
10301031
* @return {Object} response - response to the api call
10311032
*/
1032-
signTokenRequestState(tokenId, state) {
1033+
signTokenRequestState(tokenRequestId, tokenId, state) {
10331034
return Util.callAsync(this.signTokenRequestState, async () => {
1034-
const res = await this._client.signTokenRequestState(tokenId, state);
1035+
const res = await this._client.signTokenRequestState(tokenRequestId, tokenId, state);
10351036
return res.data.signature;
10361037
});
10371038
}

src/main/Token.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -478,15 +478,18 @@ class Token {
478478
}
479479

480480
/**
481-
* Get a token ID based on its token request ID.
481+
* Get the token request result based on its token request ID.
482482
*
483483
* @param {string} tokenRequestId - token request id
484-
* @return {Promise} tokenId - token id
484+
* @return {Promise} tokenId - token id and signature
485485
*/
486-
getTokenId(tokenRequestId) {
487-
return Util.callAsync(this.getTokenId, async () => {
488-
const res = await this._unauthenticatedClient.getTokenId(tokenRequestId);
489-
return res.data.tokenId;
486+
getTokenRequestResult(tokenRequestId) {
487+
return Util.callAsync(this.getTokenRequestResult, async () => {
488+
const res = await this._unauthenticatedClient.getTokenRequestResult(tokenRequestId);
489+
return {
490+
tokenId: res.data.tokenId,
491+
signature: res.data.signature
492+
};
490493
});
491494
}
492495
}

src/sample/TokenRequestUrlSample.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,18 +34,23 @@ class TokenRequestUrlSample {
3434
/**
3535
* Generates a callback URL from a token request URL.
3636
*
37+
* @param {string} tokenRequestId - token request id
3738
* @param {object} grantor - grantor of the token
3839
* @param {object} grantee - grantee of the token
3940
* @param {string} tokenRequestUrl - token request URL
4041
* @return {Promise} promise - promise of callback URL
4142
*/
42-
static async getCallbackUrlFromTokenRequestUrl(grantor, grantee, tokenRequestUrl) {
43+
static async getCallbackUrlFromTokenRequestUrl(
44+
tokenRequestId,
45+
grantor,
46+
grantee,
47+
tokenRequestUrl) {
4348
const urlParams = Util.parseParamsFromUrl(tokenRequestUrl);
4449
const state = encodeURIComponent(urlParams.state);
4550

4651
const token = await this.generateValidAccessToken(grantor, grantee);
4752

48-
const signature = await grantor.signTokenRequestState(token.id, state);
53+
const signature = await grantor.signTokenRequestState(tokenRequestId, token.id, state);
4954
const callbackUrl = `http://localhost/path?tokenId=${token.id}` +
5055
`&state=${state}&signature=${encodeURIComponent(JSON.stringify(signature))}`;
5156

test/sample/TokenRequestUrlSample.spec.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ describe('TokenRequestUrl test', () => {
2626
const requestUrl = TokenRequestUrlSample
2727
.generateTokenRequestUrl(requestId, originalState, csrfToken);
2828
const callbackUrl = await TokenRequestUrlSample
29-
.getCallbackUrlFromTokenRequestUrl(grantor, grantee, requestUrl);
29+
.getCallbackUrlFromTokenRequestUrl(requestId, grantor, grantee, requestUrl);
3030
const callback = await TokenRequestUrlSample
3131
.parseTokenRequestCallbackUrl(callbackUrl, csrfToken);
3232
assert.equal(originalState, callback.innerState);
@@ -36,6 +36,7 @@ describe('TokenRequestUrl test', () => {
3636
it('Should request a signature', async () => {
3737
if (BROWSER) return;
3838
const state = Util.generateNonce();
39+
const tokenRequestId = Util.generateNonce();
3940

4041
const grantor = await CreateMemberSample();
4142
const grantee = await CreateMemberSample();
@@ -45,7 +46,7 @@ describe('TokenRequestUrl test', () => {
4546
});
4647
const token = await TokenRequestUrlSample.generateValidAccessToken(grantor, grantee);
4748

48-
const signature = await grantor.signTokenRequestState(token.id, state);
49+
const signature = await grantor.signTokenRequestState(tokenRequestId, token.id, state);
4950

5051
const tokenMember = await TokenRequestUrlSample.getTokenMember();
5152
const signingKey = Util.getSigningKey(tokenMember.keys, signature);

0 commit comments

Comments
 (0)