Add script name support using minimal change

Author: LostKobrakai

lib/fun_with_flags/ui/router.ex

@@ -283,10 +283,12 @@ defmodule FunWithFlags.UI.Router do
 
 
   defp extract_namespace(conn, opts) do
-    ns = opts[:namespace] || ""
+    ns = opts[:namespace] || namespace_from_script_name(conn.script_name)
     Plug.Conn.assign(conn, :namespace, "/" <> ns)
   end
 
+  defp namespace_from_script_name([]), do: ""
+  defp namespace_from_script_name(list), do: Path.join(list)
 
   defp assign_csrf_token(conn, _opts) do
     csrf_token = Plug.CSRFProtection.get_csrf_token()
@@ -297,7 +299,7 @@ defmodule FunWithFlags.UI.Router do
   # Custom CSRF protection plug. It wraps the default plug provided
   # by `Plug`, it calls `Plug.Conn.fetch_session/1` (no-op if already
   # fetched), and it bails out gracefully if no session is configured.
-  # 
+  #
   defp protect_from_forgery(conn, opts) do
     try do
       conn

test/fun_with_flags/ui/router_test.exs

@@ -18,6 +18,18 @@ defmodule FunWithFlags.UI.RouterTest do
 
   @opts Router.init([])
 
+  describe "script_name" do
+    test "redirects to /flags" do
+      conn =
+        conn(:get, "/")
+        |> Map.put(:script_name, ["pear"])
+        |> Router.call(@opts)
+
+      assert 302 = conn.status
+      assert ["/pear/flags"] = get_resp_header(conn, "location")
+    end
+  end
+
   describe "GET /" do
     test "redirects to /flags" do
       conn = request!(:get, "/")
@@ -112,7 +124,7 @@ defmodule FunWithFlags.UI.RouterTest do
   describe "DELETE /flags/:name/boolean" do
     test "when the flag exists, it deletes its boolean gate and redirects to the flag page" do
       {:ok, true} = FunWithFlags.enable :frozen_yogurt
-      {:ok, true} = FunWithFlags.enable :frozen_yogurt, for_group: "some_group" 
+      {:ok, true} = FunWithFlags.enable :frozen_yogurt, for_group: "some_group"
 
       assert %Flag{name: :frozen_yogurt, gates: [%Gate{type: :boolean}, %Gate{type: :group}]} = FunWithFlags.get_flag(:frozen_yogurt)
 
@@ -128,7 +140,7 @@ defmodule FunWithFlags.UI.RouterTest do
   describe "DELETE /flags/:name/percentage" do
     test "when the flag exists, it deletes its current percentage gate and redirects to the flag page" do
       {:ok, true} = FunWithFlags.enable :pizza, for_percentage_of: {:time, 0.5}
-      {:ok, true} = FunWithFlags.enable :pizza, for_group: "some_group" 
+      {:ok, true} = FunWithFlags.enable :pizza, for_group: "some_group"
 
       assert %Flag{name: :pizza, gates: [%Gate{type: :percentage_of_time, for: 0.5}, %Gate{type: :group}]} = FunWithFlags.get_flag(:pizza)