Skip to content

Commit edafc71

Browse files
authored
Explain run status on run inspector panel (#2342)
1 parent 792c973 commit edafc71

File tree

1 file changed

+13
-5
lines changed
  • apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam.spans.$spanParam

1 file changed

+13
-5
lines changed

apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam.spans.$spanParam/route.tsx

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,10 @@ import { RunTag } from "~/components/runs/v3/RunTag";
4545
import { SpanEvents } from "~/components/runs/v3/SpanEvents";
4646
import { SpanTitle } from "~/components/runs/v3/SpanTitle";
4747
import { TaskRunAttemptStatusCombo } from "~/components/runs/v3/TaskRunAttemptStatus";
48-
import { TaskRunStatusCombo, TaskRunStatusReason } from "~/components/runs/v3/TaskRunStatus";
48+
import {
49+
descriptionForTaskRunStatus,
50+
TaskRunStatusCombo,
51+
} from "~/components/runs/v3/TaskRunStatus";
4952
import { WaitpointDetailTable } from "~/components/runs/v3/WaitpointDetails";
5053
import { RuntimeIcon } from "~/components/RuntimeIcon";
5154
import { WarmStartCombo } from "~/components/WarmStarts";
@@ -402,7 +405,10 @@ function RunBody({
402405
<Property.Item>
403406
<Property.Label>Status</Property.Label>
404407
<Property.Value>
405-
<TaskRunStatusCombo status={run.status} />
408+
<SimpleTooltip
409+
button={<TaskRunStatusCombo status={run.status} />}
410+
content={descriptionForTaskRunStatus(run.status)}
411+
/>
406412
</Property.Value>
407413
</Property.Item>
408414
<Property.Item>
@@ -766,9 +772,11 @@ function RunBody({
766772
</div>
767773
) : (
768774
<div className="flex flex-col gap-4 pt-3">
769-
<div className="space-y-2 border-b border-grid-bright pb-3">
770-
<TaskRunStatusCombo status={run.status} className="text-sm" />
771-
<TaskRunStatusReason status={run.status} statusReason={run.statusReason} />
775+
<div className="border-b border-grid-bright pb-3">
776+
<SimpleTooltip
777+
button={<TaskRunStatusCombo status={run.status} className="text-sm" />}
778+
content={descriptionForTaskRunStatus(run.status)}
779+
/>
772780
</div>
773781
<RunTimeline run={run} />
774782

0 commit comments

Comments
 (0)