Commit 05ca898
committed
Fix testDirectTrinoClientLongQuery
Example timings of processing pages in DirectTrinoClient during a local
run:
```
0.007584s
9.58E-4s
0.001542s
0.001792s
0.002708s
0.406709s
```
In this test, after processing each page, `DirectTrinoClient` waits 0.5s
and sends a heartbeat. The `query.client.timeout` is set to 1s.
Considering that processing the last page took 0.4s, it’s easy to
imagine that sometimes the total interval between sending heartbeats
exceeds 1s.
This test doesn’t care about the query output, so using `EXPLAIN ANALYZE`
and ignoring the results is fine. Now the example timings look as follows:
```
0.006958s
0.00125s
0.001292s
0.001875s
0.001333s
0.039125s
```
As an experiment, I reverted the bugfix that this test is validating,
and the test failed with EXPLAIN ANALYZE, so the intended behavior is
still covered.1 parent b0738cb commit 05ca898
File tree
1 file changed
+1
-1
lines changed- testing/trino-tests/src/test/java/io/trino/client/direct
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
0 commit comments